From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F431C433E7 for ; Wed, 14 Oct 2020 11:21:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2F29208B3 for ; Wed, 14 Oct 2020 11:21:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wildgooses.com header.i=@wildgooses.com header.b="SoIXu9Cc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729372AbgJNLVO (ORCPT ); Wed, 14 Oct 2020 07:21:14 -0400 Received: from mail1.nippynetworks.com ([91.220.24.129]:44076 "EHLO mail1.nippynetworks.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727865AbgJNLVN (ORCPT ); Wed, 14 Oct 2020 07:21:13 -0400 Received: from macbookpro-ed.wildgooses.lan (unknown [212.69.38.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256)) (No client certificate requested) (Authenticated sender: ed@wildgooses.com) by mail1.nippynetworks.com (Postfix) with ESMTPSA id 4CB92r2KlfzTh4d; Wed, 14 Oct 2020 12:21:08 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wildgooses.com; s=dkim; t=1602674471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MqppSAJ/nKG+OEqXPwbLp9Euk/mEALvMk5IqKFtZ9Dc=; b=SoIXu9CcbxRZbIoWljtTLLF7r6Hwv/U4wiLon3QYSgZkjewBy2B551U/Exi2YfnlkLIIPD IYShJpl0yZEWqlZL5yeWnsxSvQD7UzVcbe/Cid9NTg9z+GFpe+3FR3X7VvB8uBYbejBCBp hW0a4u6DtJYtiZF61KHdnPT226OubuM= Subject: Re: [PATCH 1/2] x86: Remove led/gpio setup from pcengines platform driver To: Hans de Goede , "Enrico Weigelt, metux IT consult" , linux-kernel@vger.kernel.org Cc: fe@dev.tdt.de, "Enrico Weigelt, metux IT consult" , Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org References: <20200921215919.3072-1-lists@wildgooses.com> <8058a804-a793-a5f8-d086-0bb0f600aef9@metux.net> <65efe44a-bbef-f982-462a-385fffe493a0@wildgooses.com> <0de126c4-f2aa-a817-0a38-32bf3ede84d1@redhat.com> From: Ed W Message-ID: Date: Wed, 14 Oct 2020 12:21:07 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <0de126c4-f2aa-a817-0a38-32bf3ede84d1@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-GB Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On 14/10/2020 09:41, Hans de Goede wrote: > > So I have a suggested compromise: > > Keep the current LED/gpio setup code, but make executing it conditional > on the BIOS version and skip the LED/gpio setup when the new BIOS is > present to avoid having duplicate LED entries, etc. in that case. > > I guess this would still break userspace because if I understand things > correctly the new ACPI based setup uses different LED names ? That > seems unfortunate, but I guess that from the kernel pov we can just > blame the BIOS for this, and since we definitely do not want duplicate > LED entries for the same LED, this seems the least bad choice. > > Enrico, would that work for you ? I'm cool with this. Enrico? I may have some time imminently to have a stab at a new patch. Obviously any help structuring this would be appreciated - it feels clumsy using the existing detection mechanism, I think whatever I come up with you should kick back and recommend a new board detection structure, but perhaps we can shortcut that step with a few comments up front? Cheers Ed W