From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2340036683D for ; Wed, 4 Mar 2026 03:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595310; cv=none; b=SKhWvGC2GoeO7IIOXmMqAM6Zl/+WFJEShtSO5W8hpl5vmDFIUS+rInG9Bq4TCBr1a4RI3GcMf+BV2ilHlno8cnnQhohiZVzePBtTclU+ZVX4NOaK1XBrhdhPLYV2YcTbr6ZoZZhvxx5yP9tHAglM2kRT+Mronim3v5gC+tm4OaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772595310; c=relaxed/simple; bh=XLiJ2nD8DJIVsSYbftRzQJ/qqbqmFgul82tptWrTWOA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FLYgtUtzgQw/Cy6q3zLT5Q8xAcePEW+vJ0VwrnJwlqgD+zdGma6Ov6s+6otTpNvAuE9U6XbzTsiCSKSLnsmVPw+sb4OstljY9QZgnxjLWPuOK6SbbO5j86SyRVHfyYR95v0KX23Y3vqaBlyvPNRkGSI7sn2EI4pCbbe9PyhJ79o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=QHE4RM62; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="QHE4RM62" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7d4c383f2fcso4377081a34.0 for ; Tue, 03 Mar 2026 19:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1772595307; x=1773200107; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=QHE4RM62ShmC9lkYBjI9BTR61WUA9T4Vs0ivgp/Wt9OxDzDmewU11m8TnHYRqeKNik qTU3GSlU+AOMYC6oZoW1fwF/WSipxsmrzao959qmDvz3IrjtLyP8C9NfKOSEnuvAGdIA PF8UhVYUZQoMy/RSmrgeZHYmkxqghuzD7bc3hAtlqgz3+QwYcvwogaIr3j8U0BktD89/ NccLyWS40wcykSXmvE5hyZ0yYpmm71Np4XoFq0dPZ+7DOB/4vJW7t2XiqLMGS075pLs8 RAzKhuriSCjvqOqd64AXiES81pF1x5KuNybaAyvnsVPRQAxs04zQFpPReNbYc641VK0Z +31A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772595307; x=1773200107; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=ihQrXlbd/G4lYoX3EJIAMNoL+sB7oaPagU1urj8IIrVWiNu1O+zMOufhkv8DxfEI+y lC80bwAP/PBOGLMGInSt9LqiKuJsfAyx2Et775isZ5yH34VsqwSlmVTlY+lKIKNwa8yh hqDppQUihs18A1aPPZrQhjyrCDe2bc9ACB3hJn5HesU5/qke5GiTt2EguJ29/yhaWOgY psQ5KjckWKa4TdZMP4hdSXH5HguW1j7/5tuGvJEVFgmA/I+0SAeuZ5xIFpNkSdNNfei6 hUAZgfFPze6DLNhDmBNfQH5Pvb5FgcVNzvOXaHNOpCbNG3rUs6277JyS7oTm/g3f/ZKC JX7w== X-Forwarded-Encrypted: i=1; AJvYcCXGep+C7OsNySIKbuqoSff9pZRLxiA7DyRWCtZbvkh3Y8LplVBp0az2xYqkJ6aRLdr9jFF+gtID2A==@lists.linux.dev X-Gm-Message-State: AOJu0YyvHmZ9fRXxlmdTUBNYMvHM9B/ftYbtlAlo2fLLjVysA3lc4Psc GgwrmPo+omSTxh5FlxBky6E80F86an2gHl/XTGitDjGtS/1jn5sVdBYL5sNPMSIctUQ= X-Gm-Gg: ATEYQzz5Zt3nfFgBpx0gdikwlRUBMmpccI9sJJzdSyxfL35yx3BFj9skf1modOosRJu THXyNogm95bboIKfT8l5CDkOkrCi1vlOs+oyGgWZQubKaiDiBT1NJfSLP6PkdW3hwdcMSUH+mp3 oMRkQT5sGOiZ71AbdSVRZoi8k6BfVYB5ybkLtRJSoxyQp6bE3SXxGtfmEev5shzZ44FBbEtGFu5 hxpY1fVNh+8KpuY66ePsnRMPddkW1OMbXX4HRQq0CPQqIN3dMpIZzVcjkBqPDckoZ1HOgAyPAPh aQT2ik44ewilAeOqydeXYIlSDf1rNesbrr/Rh5X6DW+inK6nGMSrWacYCsCNFnuIPq5k/CBfm3b d7VlFG7UNfItaIM0UYoMNpr/i3nBM3fd6X+3x4XDaeh+QUUSIRTSxGh8rVVFZkPuLqkGr7P7pO0 lFYeQbZnp5WoDYxNrwxzqReCjFtn+W/Cb2lgpPnrnufceknWh7ua7Cc07PDINETLlnzLJYpoW5S GEiy1keaw== X-Received: by 2002:a05:6830:6185:b0:7c7:6977:17cb with SMTP id 46e09a7af769-7d6d139f788mr450044a34.21.1772595307034; Tue, 03 Mar 2026 19:35:07 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d586653f6asm15202012a34.19.2026.03.03.19.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 19:35:06 -0800 (PST) Message-ID: Date: Tue, 3 Mar 2026 20:35:01 -0700 Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] mm: globalize rest_of_page() macro To: Yury Norov , Sean Christopherson Cc: Jakub Kicinski , Andrew Morton , "David S. Miller" , "Michael S. Tsirkin" , Theodore Ts'o , Albert Ou , Alexander Duyck , Alexander Gordeev , Alexander Viro , Alexandra Winter , Andreas Dilger , Andrew Lunn , Anna Schumaker , Anton Yakovlev , Arnaldo Carvalho de Melo , Aswin Karuvally , Borislav Petkov , Carlos Maiolino , Catalin Marinas , Chao Yu , Christian Borntraeger , Christian Brauner , Claudio Imbrenda , Dave Hansen , David Airlie , Dominique Martinet , Dongsheng Yang , Eric Dumazet , Eric Van Hensbergen , Heiko Carstens , Herbert Xu , Ingo Molnar , Jaegeuk Kim , Jani Nikula , Janosch Frank , Jaroslav Kysela , Joonas Lahtinen , Latchesar Ionkov , Linus Walleij , Madhavan Srinivasan , Mark Brown , Michael Ellerman , Miklos Szeredi , Namhyung Kim , Palmer Dabbelt , Paolo Abeni , Paolo Bonzini , Paul Walmsley , Peter Zijlstra , Rodrigo Vivi , Simona Vetter , Takashi Iwai , Thomas Gleixner , Trond Myklebust , Tvrtko Ursulin , Vasily Gorbik , Will Deacon , Yury Norov , Zheng Gu , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, dm-devel@lists.linux.dev, netdev@vger.kernel.org, linux-spi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, v9fs@lists.linux.dev, virtualization@lists.linux.dev, linux-sound@vger.kernel.org References: <20260304012717.201797-1-ynorov@nvidia.com> <20260303182845.250bb2de@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/3/26 8:32 PM, Yury Norov wrote: > My motivation is that it helps to simplify constructions like this: > > - loff_t cmp_len = min(PAGE_SIZE - offset_in_page(srcoff), > - PAGE_SIZE - offset_in_page(dstoff)); > + loff_t cmp_len = min(rest_of_page(srcoff), rest_of_page(dstoff)); > > Or this: > > - if (folio_test_highmem(dst_folio) && > - chunk > PAGE_SIZE - offset_in_page(dst_off)) > - chunk = PAGE_SIZE - offset_in_page(dst_off); > - if (folio_test_highmem(src_folio) && > - chunk > PAGE_SIZE - offset_in_page(src_off)) > - chunk = PAGE_SIZE - offset_in_page(src_off); > + if (folio_test_highmem(dst_folio) && chunk > rest_of_page(dst_off)) > + chunk = rest_of_page(dst_off); > + if (folio_test_highmem(src_folio) && chunk > rest_of_page(src_off)) > + chunk = rest_of_page(src_off); > > To a point where I don't have to use my brains to decode them. I agree > it's an easy math. It's just too bulky to my (and 9p guys too) taste. The thing is, now I have to go lookup what on earth rest_of_page() does, whereas PAGE_SIZE - offset_in_page(page) is immediately obvious. It's a classic case of "oh let's add this helper to simplify things" which really just makes it worse, because now you have to jump to the definition of rest_of_page(). IOW, just no. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F262BEDEC01 for ; Wed, 4 Mar 2026 03:35:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:From:References:To:MIME-Version:Date:Message-ID:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PkOesxzGtHoRAVb0ERV0LWe0EQ+9ulpTH9y42O7E+GU=; b=QWxHslN0GBveXF8LYfP5RqksCH opIqNWj3jfEVCyS3aRkZKNz+ALYXc7KFrjTx8ZPwImA61ZxotlkKwWEnsa9wywXL3dQpiHAYrAvPq pAPTSa0wO114xqDxB9ujkWIgmqQ2Ovmi8/XJjPSmnJIkqcNNvvW5yqIoSiPcoBhEqzyE=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxd1N-0001wG-JZ; Wed, 04 Mar 2026 03:35:37 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxd14-0001vo-A4 for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Mar 2026 03:35:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=Sm5bk4E8jTCcbFw5Ah4qlTopeX QFHk97zUWIq6yLr4R0QtcfgyNDpr28mpjeKxEW5K2KFGyHLMxmgZaVxmOPHYhgTIwyEgQILsFyOHG cLl37xjHjopCf0Zl0BsMwwocwB1vR3Ca2rj6e9IRxOArXxIjubXubLzjxZ5Yl1ZmqTPs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=QFCwNqAw+b3PtD4pDVrYQWD2D0 wcnKOuAGe9bY8JVLwm5aN7NpUarVukfwAmZYREwvkS33oH3zZmX0BmNVb2x41KYshZy/HV2goUIbg w9lmPSXH45IiszPHKbshS1eEY1s3KYOf5d4DPXWJ1ZcNeoL54ajY/v2Mosp56IkSf6g4=; Received: from mail-ot1-f54.google.com ([209.85.210.54]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.95) id 1vxd13-0005hI-Oh for linux-f2fs-devel@lists.sourceforge.net; Wed, 04 Mar 2026 03:35:18 +0000 Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7d4be7c4ebeso3198659a34.1 for ; Tue, 03 Mar 2026 19:35:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1772595307; x=1773200107; darn=lists.sourceforge.net; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=iU7v0aVbIHmHuzGdUHH8JeF+JtmKG2biV8Wi3kqAH0PY/JWTNDHozxX/iFm6KZ3e0E pXRfHy0m72iFpmYZxxgtP6L5lokNWkzakqfaNjX2KkHkLJFbDuVW2x1vQcJe1Dl1LJE7 2ZbbJyTtKphqATMoSru5joefEWAiJBFWFzCKnXSPSNz+ZDsVCxLwpGUcw8iPYc48/UKD oZPEhD/oL0XjHuVbuhGO8RT23LnoKDE2mz+3MkxBtw4FHSZFfuw7ViQ8Fb/RgEeU+9rP XMZOa27nf4M9gnWh0TrCbImHlr6yxx9RAdIS0orndmbjODcg2/zR8PPnieEgqOx19w9j hPNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772595307; x=1773200107; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=GRkOYt/4ubfwrz52mxhcr9asis4atUz4LHQ/rGBuzl/9ScFZnqBGcYeayEF5XNdDg0 qKz2WEkdRkT/+kkEtQU0QPVk/Vw4/FJHNGD93eutlp0Vx3bZd63pLiYUO2sJmjJ0O9oY vTGU1unJIQQbRd5qN/PNfBpo8JoIn87hKTBjGhZ9qiFKzD/8NJbZBoThk67WXZQFfQfw AOOC0qFe0GePUxo2dcz2eTDyE7ybHiXGtKu1QOG+lokMFGKXRKQZ8QNwUM0vp/Kbc/+F FWS9e5NinLkMxSRjbT+lHcuF+6waljTSQvAcjMVybBImUfXoKRCCEZIc4qyzeIOuvVlB Jkbw== X-Forwarded-Encrypted: i=1; AJvYcCV+A2fi6UevspnnjOUIB2dIJ56N1IGqx0Y+aY+Uha8gNwcgdDehgFzsKwJ7z8bpaNvD1oWKe0zvKnfxDZuyuTrD@lists.sourceforge.net X-Gm-Message-State: AOJu0YyfFQOxoLL6SXp81XAAjkS1va+qJPsvErV77TIOGTNNoStfiPgF jVDTEGU+U+rK9EYj+wkM+x2wb6JmMFXwqt67RViDbncXcGb6cnPbwoAEJ+wn4WbnRJA= X-Gm-Gg: ATEYQzyHu389jOfjn5utPm8g8xfk+OPA8tj/7rKXUlffYzZOyn+2P2Ef+rv0mY7Z+7s sIOzRlpaF8S8+Rv+5xzvrZCNH/D3rzAbZAy1XAzVk0qaiMekAvB3piRCjYZ2a8iJO52aVWGQ1U+ h3PwGNchVx6aHGrnQj87wrEK0+x/WFhV67mwZUmYIVDpbkGRu39i95i2Hrxz6+0qwCH8HCCvN1n lHxNrZHJGPfMtZ2rTXiyHPMy5DJAC94uA0bvW4plOfD+Lx/8YARTu3DDbchU4A1kq0Gy4isUGER Q7TbGOVR3PkuDzztA1GxfHlkhpfBJKxs1ukXteTaY0rcOllXEilA1uojOlcNzI++q8XLNDfq8Hw swoQzdctACcpmJRA+qwo+AS94DYXjvTwAZuwi5O6tjsVLRFFqK9kgWtaSwfuh9BNBG2Q1nv382q mqnRZUbsO0OX/64zIsy3d3uoU+E6oWlzP9w5ap3KCCwYs7OcqMxeXE3ReKPFtTyv2dvmLmxgLHu ctyOEAnmg== X-Received: by 2002:a05:6830:6185:b0:7c7:6977:17cb with SMTP id 46e09a7af769-7d6d139f788mr450044a34.21.1772595307034; Tue, 03 Mar 2026 19:35:07 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d586653f6asm15202012a34.19.2026.03.03.19.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 19:35:06 -0800 (PST) Message-ID: Date: Tue, 3 Mar 2026 20:35:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Yury Norov , Sean Christopherson References: <20260304012717.201797-1-ynorov@nvidia.com> <20260303182845.250bb2de@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: X-Headers-End: 1vxd13-0005hI-Oh Subject: Re: [f2fs-dev] [PATCH 0/8] mm: globalize rest_of_page() macro X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Zheng Gu , kvm@vger.kernel.org, "Michael S. Tsirkin" , Peter Zijlstra , Catalin Marinas , Alexander Duyck , Dave Hansen , dri-devel@lists.freedesktop.org, Jaroslav Kysela , linux-perf-users@vger.kernel.org, linux-mm@kvack.org, Eric Dumazet , Andreas Dilger , linux-nfs@vger.kernel.org, Dongsheng Yang , Joonas Lahtinen , Alexander Gordeev , Claudio Imbrenda , David Airlie , linux-riscv@lists.infradead.org, Simona Vetter , linux-s390@vger.kernel.org, Madhavan Srinivasan , Yury Norov , Herbert Xu , Alexandra Winter , Miklos Szeredi , Michael Ellerman , linux-ext4@vger.kernel.org, x86@kernel.org, Tvrtko Ursulin , linux-spi@vger.kernel.org, Ingo Molnar , Aswin Karuvally , intel-gfx@lists.freedesktop.org, Jakub Kicinski , Christian Borntraeger , Carlos Maiolino , Dominique Martinet , Thomas Gleixner , dm-devel@lists.linux.dev, Albert Ou , Vasily Gorbik , Heiko Carstens , Will Deacon , linux-f2fs-devel@lists.sourceforge.net, Arnaldo Carvalho de Melo , linux-crypto@vger.kernel.org, linux-block@vger.kernel.org, Mark Brown , Borislav Petkov , Alexander Viro , Rodrigo Vivi , Jaegeuk Kim , virtualization@lists.linux.dev, Eric Van Hensbergen , Paul Walmsley , linux-arm-kernel@lists.infradead.org, Janosch Frank , Jani Nikula , Christian Brauner , Paolo Abeni , Theodore Ts'o , v9fs@lists.linux.dev, netdev@vger.kernel.org, Linus Walleij , linux-sound@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, Andrew Lunn , Palmer Dabbelt , Anton Yakovlev , Anna Schumaker , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Namhyung Kim , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Trond Myklebust Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 3/3/26 8:32 PM, Yury Norov wrote: > My motivation is that it helps to simplify constructions like this: > > - loff_t cmp_len = min(PAGE_SIZE - offset_in_page(srcoff), > - PAGE_SIZE - offset_in_page(dstoff)); > + loff_t cmp_len = min(rest_of_page(srcoff), rest_of_page(dstoff)); > > Or this: > > - if (folio_test_highmem(dst_folio) && > - chunk > PAGE_SIZE - offset_in_page(dst_off)) > - chunk = PAGE_SIZE - offset_in_page(dst_off); > - if (folio_test_highmem(src_folio) && > - chunk > PAGE_SIZE - offset_in_page(src_off)) > - chunk = PAGE_SIZE - offset_in_page(src_off); > + if (folio_test_highmem(dst_folio) && chunk > rest_of_page(dst_off)) > + chunk = rest_of_page(dst_off); > + if (folio_test_highmem(src_folio) && chunk > rest_of_page(src_off)) > + chunk = rest_of_page(src_off); > > To a point where I don't have to use my brains to decode them. I agree > it's an easy math. It's just too bulky to my (and 9p guys too) taste. The thing is, now I have to go lookup what on earth rest_of_page() does, whereas PAGE_SIZE - offset_in_page(page) is immediately obvious. It's a classic case of "oh let's add this helper to simplify things" which really just makes it worse, because now you have to jump to the definition of rest_of_page(). IOW, just no. -- Jens Axboe _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3C4CEDEC01 for ; Wed, 4 Mar 2026 03:35:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j+sH2y4i6BFsRtuC3ZbWkwiQAFfskjQ2qDybWwU+ueM=; b=Sjvw9TfKbUN8FV g9DASdiatJ5FFRhulAAJOjBqosfREfoKz9CJ+ZMCj34HpUwNsyeIAa/aelssi3DXAgmR2jbA9Qo3a iI+hOGKtoEnca5P6GH4g0BdbY4R4ovVkWZzW+S0x3c0XvPoSq2B7djbdTSdVmysHWdT+tMdyvXlzq l6IsItOIvzHHp/qrYCPD2BZPG5iCqlL7YmxeLftH3gSwQxRGx+akNpYr1UU+Y4SbAMT2MA6hRrwzG LbXSjRD9xTjScJB4vBXthiGxgV/Sg9hoWNfgm5TMIQeaOlPjQtSrq8Jo1VP0tzPlcFRX9CDp5l4KM qc53VYOgFZNhyjV0m6xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxd0w-0000000GNjE-49Ho; Wed, 04 Mar 2026 03:35:10 +0000 Received: from mail-ot1-x335.google.com ([2607:f8b0:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxd0u-0000000GNiG-0Igj for linux-riscv@lists.infradead.org; Wed, 04 Mar 2026 03:35:09 +0000 Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-7d18f80b5c2so4853004a34.3 for ; Tue, 03 Mar 2026 19:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1772595307; x=1773200107; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=BaiT6pZ4zmrFxiyxw94lpsL7aywISFf2OUF/pF51oGdPLsWNPXHnute5xkW/cgZigV q6SIegkqr0jvA2QjyzoMPcFe2sg+fq7lr3Eq5JrDBU/qcDJFtjfFn1BxPUKCmWIq2+/Z VYo9nW4B2PGzPzUhxFiovrwp5RsQ+66L3AtaNAV5ASLxH0jK+qi654Yb3AVLX55nApm4 yRqBUyjpQqNcnhUgCN62I/y1L0b/AIg4kUNv+83sKuXmfJxRmILPhwAG1yPateBMNouM 0MwgkzZe39fBVPhbsvUKwn8619nn4rVzp/hIcYCxqJJPzb6hvUTER3LAKVAPHYvjAZ1L iRFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772595307; x=1773200107; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=jQgrtiSQB+C3OGt0oU44nQoGZVVk4qga8MbC7PGCDclVvVut2O/pmF48xSCt5pVdLo Y9RwlTNfrJ/6JwIcjPmgS/f7gG0zdTx8T8VhP+BxkpP2WsQwBrSq28wQxvOPnvIvRmH5 MVyuxaGqmn2Hv1NiFG2B62j+bSjQBwjOOujQhHJP4j/l4izEQAC9Vj5gm1Mc08G9ApT1 jyFRtZLts8i4InzKmPud8Xk5bq6QDY1HblY2jJk4vBEqORtAzfNljyGkyYvh9looozUd 3KYxTGcL4WYonnwzaOgxn30AZm0WQiQ7q9MblmDWcK80pTR67XE6Jz21sv3d6AW6WcG+ mHKQ== X-Forwarded-Encrypted: i=1; AJvYcCWjaFDmV+Il396TKWiGgzNbU46uYlor01Pz+CRvyDv85bn+jH+mrwpxLLeKBeaD/nyjrOLiSj0G1kCVQQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yx9LGzlPeto6YPDdNhGVE60jvtta+Iq2kfkEj1WV2Dg8CheYF7v ucSp9/Hzh+rHPZhw5U5mEkku5uiDQqtLc3t3dVfj4thvgOdXjI1mJUGFHliAx2uMuAs= X-Gm-Gg: ATEYQzzgy8ihhNgy5s2yMUxET2/MwrY1B+2HQaSbDrErRduhh19Zjke0v3Yk7ysUbcd P1SybWASQ9QEYQztRC3kzJTCXqo5OKlvNjNLGWOFYhpL//o+71pyMNoKfKbLkQBiZnlcu0lU+zZ 0DKwfj6WI51ww5WNtbtalmeldnhoH+2bQBEhSBxJ5wCkpX95XkXjcBZ16ue6t7x347K0yvUbWyv UyJgN2muDzjfJYTi2DtERMMXPETz3RQTxFbfOTRafZaIFBNLEGlFTieHcZGEht9muodmSikArYm 7Lpvvn2uOKa4N4RQ3mjwQZYcKU+dgAuuFCTlQNAHS3f7384QCDFM4E0ep7gr6IK/E+v6AfSBMv1 A3OXmokB5HH71e9jzpM4cy4Mx26qiURSh50xoEeKqQOpmnf0nypygZiRBJot1AqNzKma9KVuGrS byeNN9/k7WWKAbrFmKnverpxOBVA6KBE/kI5aN/wCQehKZEp3hu7IoG14I+Z0yjivU4u2tB7UqL ydb/LcCyg== X-Received: by 2002:a05:6830:6185:b0:7c7:6977:17cb with SMTP id 46e09a7af769-7d6d139f788mr450044a34.21.1772595307034; Tue, 03 Mar 2026 19:35:07 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d586653f6asm15202012a34.19.2026.03.03.19.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 19:35:06 -0800 (PST) Message-ID: Date: Tue, 3 Mar 2026 20:35:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] mm: globalize rest_of_page() macro To: Yury Norov , Sean Christopherson Cc: Jakub Kicinski , Andrew Morton , "David S. Miller" , "Michael S. Tsirkin" , Theodore Ts'o , Albert Ou , Alexander Duyck , Alexander Gordeev , Alexander Viro , Alexandra Winter , Andreas Dilger , Andrew Lunn , Anna Schumaker , Anton Yakovlev , Arnaldo Carvalho de Melo , Aswin Karuvally , Borislav Petkov , Carlos Maiolino , Catalin Marinas , Chao Yu , Christian Borntraeger , Christian Brauner , Claudio Imbrenda , Dave Hansen , David Airlie , Dominique Martinet , Dongsheng Yang , Eric Dumazet , Eric Van Hensbergen , Heiko Carstens , Herbert Xu , Ingo Molnar , Jaegeuk Kim , Jani Nikula , Janosch Frank , Jaroslav Kysela , Joonas Lahtinen , Latchesar Ionkov , Linus Walleij , Madhavan Srinivasan , Mark Brown , Michael Ellerman , Miklos Szeredi , Namhyung Kim , Palmer Dabbelt , Paolo Abeni , Paolo Bonzini , Paul Walmsley , Peter Zijlstra , Rodrigo Vivi , Simona Vetter , Takashi Iwai , Thomas Gleixner , Trond Myklebust , Tvrtko Ursulin , Vasily Gorbik , Will Deacon , Yury Norov , Zheng Gu , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, dm-devel@lists.linux.dev, netdev@vger.kernel.org, linux-spi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, v9fs@lists.linux.dev, virtualization@lists.linux.dev, linux-sound@vger.kernel.org References: <20260304012717.201797-1-ynorov@nvidia.com> <20260303182845.250bb2de@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260303_193508_125983_6DCD8642 X-CRM114-Status: GOOD ( 14.29 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 3/3/26 8:32 PM, Yury Norov wrote: > My motivation is that it helps to simplify constructions like this: > > - loff_t cmp_len = min(PAGE_SIZE - offset_in_page(srcoff), > - PAGE_SIZE - offset_in_page(dstoff)); > + loff_t cmp_len = min(rest_of_page(srcoff), rest_of_page(dstoff)); > > Or this: > > - if (folio_test_highmem(dst_folio) && > - chunk > PAGE_SIZE - offset_in_page(dst_off)) > - chunk = PAGE_SIZE - offset_in_page(dst_off); > - if (folio_test_highmem(src_folio) && > - chunk > PAGE_SIZE - offset_in_page(src_off)) > - chunk = PAGE_SIZE - offset_in_page(src_off); > + if (folio_test_highmem(dst_folio) && chunk > rest_of_page(dst_off)) > + chunk = rest_of_page(dst_off); > + if (folio_test_highmem(src_folio) && chunk > rest_of_page(src_off)) > + chunk = rest_of_page(src_off); > > To a point where I don't have to use my brains to decode them. I agree > it's an easy math. It's just too bulky to my (and 9p guys too) taste. The thing is, now I have to go lookup what on earth rest_of_page() does, whereas PAGE_SIZE - offset_in_page(page) is immediately obvious. It's a classic case of "oh let's add this helper to simplify things" which really just makes it worse, because now you have to jump to the definition of rest_of_page(). IOW, just no. -- Jens Axboe _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv