From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 3/4] mk: add new test-run make rule
Date: Thu, 16 Feb 2017 10:21:04 +0000
Message-ID: <e96fc4e1-6a93-2d52-d3bd-87c02609af93@intel.com>
References: <20170214151326.7554-1-ferruh.yigit@intel.com>
 <20170215152632.25081-1-ferruh.yigit@intel.com>
 <20170215152632.25081-3-ferruh.yigit@intel.com> <371817936.VaZMuq7BCX@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 John McNamara <john.mcnamara@intel.com>, Keith Wiles <keith.wiles@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id D6E0C39EA
 for <dev@dpdk.org>; Thu, 16 Feb 2017 11:21:07 +0100 (CET)
In-Reply-To: <371817936.VaZMuq7BCX@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/16/2017 9:26 AM, Thomas Monjalon wrote:
> 2017-02-15 15:26, Ferruh Yigit:
>> --- a/mk/rte.sdkroot.mk
>> +++ b/mk/rte.sdkroot.mk
>> @@ -92,8 +92,8 @@ default: all
>>  config showconfigs showversion showversionum:
>>  	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@
>>  
>> -.PHONY: test fast_test ring_test mempool_test perf_test coverage
>> -test fast_test ring_test mempool_test perf_test coverage:
>> +.PHONY: test test-run fast_test ring_test mempool_test perf_test coverage
>> +test test-run fast_test ring_test mempool_test perf_test coverage:
>>  	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
> 
> "test" is a shortcut for build + basic tests.
> I think test-run can be better named. It runs all the basic tests registered
> in autotests. "test-all" would be wrong. What about "test-basic"?

Right, "test-basic" matches more to existing rules (test-fast,
test-perf, ..), all has hidden "run" action implied, I will use
"test-basic" if there is no objection.

My concerns is "test-basic" "running basic tests without compilation"
may not be obvious for a newcomer.
Should I add a line to "make help" for "test" and "test-*" rules?

Like:
test      Compile tests and run basic unit tests
test-*    Run specific subset of the unit tests

thanks,
ferruh