From: Can Guo <quic_cang@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>, <mani@kernel.org>,
<stanley.chu@mediatek.com>, <adrian.hunter@intel.com>,
<beanhuo@micron.com>, <avri.altman@wdc.com>,
<junwoo80.lee@samsung.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Lu Hongfei <luhongfei@vivo.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: ufs: ufs-sysfs: Expose UFS power info
Date: Wed, 1 Nov 2023 11:52:31 +0800 [thread overview]
Message-ID: <e984ae48-5bc1-8bbb-b5cc-49832d789a47@quicinc.com> (raw)
In-Reply-To: <fe022e5f-e7da-480b-9d1c-ce2a6388d768@acm.org>
Hi Bart,
On 11/1/2023 12:23 AM, Bart Van Assche wrote:
> On 10/31/23 02:53, Can Guo wrote:
>> +What: /sys/bus/platform/drivers/ufshcd/*/power_info/mode
>> +What: /sys/bus/platform/devices/*.ufs/power_info/mode
>> +Date: September 2023
>> +Contact: Can Guo <quic_cang@quicinc.com>
>> +Description: This file shows the UniPro power mode of UFS link:
>> + == ====================================================
>> + 1 FAST_MODE
>> + 2 SLOW_MODE
>> + 4 FASTAUTO_MODE
>> + 5 SLOWAUTO_MODE
>> + == ====================================================
>> +
>> + The file is read only.
>
> For this attribute and the attributes below, shouldn't these be exported
> as text instead of as numbers? Shell scripts that read and use these
> attributes will be much easier to read if these attributes are changed
> from numeric into a textual.
Done.
Thanks,
Can Guo.
>
> Thanks,
>
> Bart.
prev parent reply other threads:[~2023-11-01 3:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 9:53 [PATCH v2] scsi: ufs: ufs-sysfs: Expose UFS power info Can Guo
2023-10-31 16:23 ` Bart Van Assche
2023-11-01 3:52 ` Can Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e984ae48-5bc1-8bbb-b5cc-49832d789a47@quicinc.com \
--to=quic_cang@quicinc.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luhongfei@vivo.com \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.