From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Del Regno <angelogioacchino.delregno@somainline.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jonathan Marek <jonathan@marek.ca>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Loic Poulain <loic.poulain@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>, Taniya Das <quic_tdas@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2 01/16] dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml
Date: Wed, 05 Jun 2024 08:07:44 -0700 [thread overview]
Message-ID: <e989c960d72a3838178edbf43eedd02b.sboyd@kernel.org> (raw)
In-Reply-To: <20240605-dt-bindings-qcom-gcc-v2-1-f947b24f1283@linaro.org>
Quoting Krzysztof Kozlowski (2024-06-05 01:09:28)
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> index bad8f019a8d3..74034e3f79b7 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-videocc.yaml
> @@ -39,26 +36,17 @@ properties:
> description:
> A phandle to an OPP node describing required MMCX performance point.
>
> - '#clock-cells':
> - const: 1
> -
> - '#reset-cells':
> - const: 1
> -
> - '#power-domain-cells':
> - const: 1
> -
> required:
> - compatible
> - - reg
> - clocks
> - power-domains
> - required-opps
> - - '#clock-cells'
> - - '#reset-cells'
> - '#power-domain-cells'
Missed removing this one?
>
> -additionalProperties: false
> +allOf:
> + - $ref: qcom,gcc.yaml#
Why not have a one-cell-clock-reset-power-domain.yaml binding that
combines all these things? It's quite common even outside of qcom.
next prev parent reply other threads:[~2024-06-05 15:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 8:09 [PATCH v2 00/16] dt-bindings: clock: qcom: reference qcom-gcc.yaml Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 01/16] dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml Krzysztof Kozlowski
2024-06-05 15:07 ` Stephen Boyd [this message]
2024-06-05 15:43 ` Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 02/16] dt-bindings: clock: qcom,videocc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 03/16] dt-bindings: clock: qcom,dispcc-sc8280xp: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 04/16] dt-bindings: clock: qcom,dispcc-sm6350: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 05/16] dt-bindings: clock: qcom,dispcc-sm8x50: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 06/16] dt-bindings: clock: qcom,gpucc-sdm660: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 07/16] dt-bindings: clock: qcom,gpucc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 08/16] dt-bindings: clock: qcom,msm8998-gpucc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 09/16] dt-bindings: clock: qcom,qcm2290-dispcc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 10/16] dt-bindings: clock: qcom,sc7180-dispcc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 11/16] dt-bindings: clock: qcom,sc7280-dispcc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 12/16] dt-bindings: clock: qcom,sdm845-dispcc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 13/16] dt-bindings: clock: qcom,sm6115-dispcc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 14/16] dt-bindings: clock: qcom,sm8450-dispcc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 15/16] dt-bindings: clock: qcom,sm8550-dispcc: " Krzysztof Kozlowski
2024-06-05 8:09 ` [PATCH v2 16/16] dt-bindings: clock: qcom,sm8450-gpucc: " Krzysztof Kozlowski
2024-06-14 22:48 ` [PATCH v2 00/16] dt-bindings: clock: qcom: reference qcom-gcc.yaml Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e989c960d72a3838178edbf43eedd02b.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.