From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from m43-7.mailgun.net ([69.72.43.7]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1je02K-0006Cm-Rr for ath11k@lists.infradead.org; Wed, 27 May 2020 17:40:19 +0000 MIME-Version: 1.0 Date: Wed, 27 May 2020 10:39:55 -0700 From: Rajkumar Manoharan Subject: Re: [PATCH v3 03/11] nl80211: add HE 6 GHz Band Capability support In-Reply-To: <4e3a5ab6eed1dc91f45a459bb616fa05a110483d.camel@sipsolutions.net> References: <1589399105-25472-1-git-send-email-rmanohar@codeaurora.org> <1589399105-25472-3-git-send-email-rmanohar@codeaurora.org> <4e3a5ab6eed1dc91f45a459bb616fa05a110483d.camel@sipsolutions.net> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, kvalo@codeaurora.org T24gMjAyMC0wNS0yNyAwNzoyNywgSm9oYW5uZXMgQmVyZyB3cm90ZToKPiBPbiBXZWQsIDIwMjAt MDUtMTMgYXQgMTI6NDQgLTA3MDAsIFJhamt1bWFyIE1hbm9oYXJhbiB3cm90ZToKPj4gCj4+ICAv KioKPj4gKyAqIGVudW0gaWVlZTgwMjExX2hlXzZnaHpfY2hhbndpZHRoIC0gSEUgNiBHSHogY2hh bm5lbCB3aWR0aAo+PiArICogQElFRUU4MDIxMV9IRV82R0haX0NIQU5XSURUSF8yME1IWjogMjAg TUh6IGJhbmR3aWR0aAo+PiArICogQElFRUU4MDIxMV9IRV82R0haX0NIQU5XSURUSF80ME1IWjog NDAgTUh6IGJhbmR3aWR0aAo+PiArICogQElFRUU4MDIxMV9IRV82R0haX0NIQU5XSURUSF84ME1I WjogODAgTUh6IGJhbmR3aWR0aAo+PiArICogQElFRUU4MDIxMV9IRV82R0haX0NIQU5XSURUSF84 MFA4ME1IWjogMTYwIG9yIDgwKzgwIE1IeiBiYW5kd2lkdGgKPj4gKyAqLwo+PiArZW51bSBpZWVl ODAyMTFfaGVfNmdoel9jaGFud2lkdGggewo+PiArCUlFRUU4MDIxMV9IRV82R0haX0NIQU5XSURU SF8yME1IWgkJPSAwLAo+PiArCUlFRUU4MDIxMV9IRV82R0haX0NIQU5XSURUSF80ME1IWgkJPSAx LAo+PiArCUlFRUU4MDIxMV9IRV82R0haX0NIQU5XSURUSF84ME1IWgkJPSAyLAo+PiArCUlFRUU4 MDIxMV9IRV82R0haX0NIQU5XSURUSF8xNjBNSFpfODBQODBNSFoJPSAzLAo+PiArfTsKPj4gKwo+ PiArLyoqCj4+ICsgKiBzdHJ1Y3QgaWVlZTgwMjExX2hlX29wZXJfNmdoel9vcF9pbmZvIC0gNiBH SHogT3BlcmF0aW9uIAo+PiBJbmZvcm1hdGlvbgo+PiArICoKPj4gKyAqIFRoaXMgc3RydWN0dXJl IGlzIGRlZmluZWQgYXMgZGVzY3JpYmVkIGluIElFRUUgUDgwMi4xMWF4L0Q2LjAsCj4+ICsgKiBG aWd1cmUgOS03ODdr4oCUNiBHSHogT3BlcmF0aW9uIEluZm9ybWF0aW9uIGZpZWxkLgo+PiArICoK Pj4gKyAqIEBwcmltYXJ5X2NoYW46IFRoZSBjaGFubmVsIG51bWJlciBvZiB0aGUgcHJpbWFyeSBj aGFubmVsIGluIHRoZSA2IAo+PiBHSHogYmFuZC4KPj4gKyAqIEBjb250cm9sOiBGaXJzdCB0d28g Yml0cyBkZWZpbmVzIGNoYW5uZWwgd2lkdGggZmllbGQgaW5kaWNhdGVzIHRoZSAKPj4gQlNTCj4+ ICsgKgljaGFubmVsIHdpZHRoIGFuZCBpcyBzZXQgdG8gMCBmb3IgMjAgTUh6LCAxIGZvciA0MCBN SHosIDIgZm9yIDgwIAo+PiBNSHosCj4+ICsgKglhbmQgMyBmb3IgODArODAgb3IgMTYwIE1Iei4K Pj4gKyAqIEBjZW50ZXJfZnJlcV9zZWcwX2lkeDogQ2hhbm5lbCBjZW50ZXIgZnJlcXVlbmN5IGlu ZGV4IGZvciB0aGUgMjAgCj4+IE1IeiwKPj4gKyAqCTQwIE1Ieiwgb3IgODAgTUh6LCBvciA4MCs4 MCBNSHouCj4+ICsgKiBAY2VudGVyX2ZyZXFfc2VnMV9pZHg6IENoYW5uZWwgY2VudGVyIGZyZXF1 ZW5jeSBpbmRleCBvZiB0aGUgMTYwIAo+PiBNSHouCj4+ICsgKiBAbWluX3JhdGU6IE1pbmltdW0g cmF0ZSwgaW4gdW5pdHMgb2YgMSBNYi9zLCB0aGF0IHRoZSBub24tQVAgU1RBIAo+PiBpcyBhbGxv d2VkCj4+ICsgKgl0byB1c2UgZm9yIHNlbmRpbmcgUFBEVXMuCj4+ICsgKi8KPj4gK3N0cnVjdCBp ZWVlODAyMTFfaGVfb3Blcl82Z2h6X29wX2luZm8gewo+PiArCXU4IHByaW1hcnlfY2hhbjsKPj4g Kwl1OCBjb250cm9sOwo+PiArCXU4IGNlbnRlcl9mcmVxX3NlZzBfaWR4Owo+PiArCXU4IGNlbnRl cl9mcmVxX3NlZzFfaWR4Owo+PiArCXU4IG1pbl9yYXRlOwo+PiArfSBfX3BhY2tlZDsKPj4gCj4g Cj4gTG9va3MgbGlrZSBJIGhhZAo+IAo+ICsvKioKPiArICogaWVlZTgwMjExX2hlXzZnaHpfb3Bl ciAtIEhFIDYgR0h6IG9wZXJhdGlvbiBJbmZvcm1hdGlvbiBmaWVsZAo+ICsgKiBAcHJpbWFyeTog cHJpbWFyeSBjaGFubmVsCj4gKyAqIEBjb250cm9sOiBjb250cm9sIGZsYWdzCj4gKyAqIEBjY2Zz MDogY2hhbm5lbCBjZW50ZXIgZnJlcXVlbmN5IHNlZ21lbnQgMAo+ICsgKiBAY2NmczE6IGNoYW5u ZWwgY2VudGVyIGZyZXF1ZW5jeSBzZWdtZW50IDEKPiArICogQG1pbnJhdGU6IG1pbmltdW0gcmF0 ZSAoaW4gMSBNYnBzIHVuaXRzKQo+ICsgKi8KPiArc3RydWN0IGllZWU4MDIxMV9oZV82Z2h6X29w ZXIgewo+ICsgICAgICAgdTggcHJpbWFyeTsKPiArI2RlZmluZSBJRUVFODAyMTFfSEVfNkdIWl9P UEVSX0NUUkxfQ0hBTldJRFRIICAweDMKPiArI2RlZmluZSAgICAgICAgICAgICAgICBJRUVFODAy MTFfSEVfNkdIWl9PUEVSX0NUUkxfQ0hBTldJRFRIXzIwTUhaICAgICAKPiAwCj4gKyNkZWZpbmUg ICAgICAgICAgICAgICAgSUVFRTgwMjExX0hFXzZHSFpfT1BFUl9DVFJMX0NIQU5XSURUSF80ME1I WiAgICAgCj4gMQo+ICsjZGVmaW5lICAgICAgICAgICAgICAgIElFRUU4MDIxMV9IRV82R0haX09Q RVJfQ1RSTF9DSEFOV0lEVEhfODBNSFogICAgIAo+IDIKPiArI2RlZmluZSAgICAgICAgICAgICAg ICBJRUVFODAyMTFfSEVfNkdIWl9PUEVSX0NUUkxfQ0hBTldJRFRIXzE2ME1IWiAgICAKPiAzCj4g KyNkZWZpbmUgSUVFRTgwMjExX0hFXzZHSFpfT1BFUl9DVFJMX0RVUF9CRUFDT04gMHg0Cj4gKyAg ICAgICB1OCBjb250cm9sOwo+ICsgICAgICAgdTggY2NmczA7Cj4gKyAgICAgICB1OCBjY2ZzMTsK PiArICAgICAgIHU4IG1pbnJhdGU7Cj4gK30gX19wYWNrZWQ7Cj4gCj4gCj4gQW55IG9iamVjdGlv biB0byB0aGF0PyBUaGUgbmFtZXMgYXJlIGdldHRpbmcgX3JlYWxseV8gbG9uZyB0aGUgd2F5IHlv dQo+IGhhZCB0aGVtIC4uLgo+IApOZWF0Li4gTEdUTS4uIDopCgo+IEZXSVcsIEkgYWxzbyBoYWQg YSBmaXggaW4gaWVlZTgwMjExX2hlX29wZXJfc2l6ZSgpIHdoZXJlIHRoZSBzaXplIG9mIAo+IHRo ZQo+IG9wZXIgaXMgbm93IHNpemVvZihzdHJ1Y3QgaWVlZTgwMjExX2hlXzZnaHpfb3BlcikuCj4g Cj4gQW5kIHRoaXMsIHRvIGZpbmQgaXQ6Cj4gCj4gKy8qKgo+ICsgKiBpZWVlODAyMTFfaGVfNmdo el9vcGVyIC0gb2J0YWluIDYgR0h6IG9wZXJhdGlvbiBmaWVsZAo+ICsgKiBAaGVfb3BlcjogSEUg b3BlcmF0aW9uIGVsZW1lbnQgKG11c3QgYmUgcHJlLXZhbGlkYXRlZCBmb3Igc2l6ZSkKPiArICog ICAgIGJ1dCBtYXkgYmUgJU5VTEwKPiArICoKPiArICogUmV0dXJuOiBhIHBvaW50ZXIgdG8gdGhl IDYgR0h6IG9wZXJhdGlvbiBmaWVsZCwgb3IgJU5VTEwKPiArICovCj4gK3N0YXRpYyBpbmxpbmUg Y29uc3Qgc3RydWN0IGllZWU4MDIxMV9oZV82Z2h6X29wZXIgKgo+ICtpZWVlODAyMTFfaGVfNmdo el9vcGVyKGNvbnN0IHN0cnVjdCBpZWVlODAyMTFfaGVfb3BlcmF0aW9uICpoZV9vcGVyKQo+ICt7 Cj4gKyAgICAgICBjb25zdCB1OCAqcmV0ID0gKHZvaWQgKikmaGVfb3Blci0+b3B0aW9uYWw7Cj4g KyAgICAgICB1MzIgaGVfb3Blcl9wYXJhbXM7Cj4gKwo+ICsgICAgICAgaWYgKCFoZV9vcGVyKQo+ ICsgICAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPiArCj4gKyAgICAgICBoZV9vcGVyX3BhcmFt cyA9IGxlMzJfdG9fY3B1KGhlX29wZXItPmhlX29wZXJfcGFyYW1zKTsKPiArCj4gKyAgICAgICBp ZiAoIShoZV9vcGVyX3BhcmFtcyAmIElFRUU4MDIxMV9IRV9PUEVSQVRJT05fNkdIWl9PUF9JTkZP KSkKPiArICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gKyAgICAgICBpZiAoaGVfb3Blcl9w YXJhbXMgJiBJRUVFODAyMTFfSEVfT1BFUkFUSU9OX1ZIVF9PUEVSX0lORk8pCj4gKyAgICAgICAg ICAgICAgIHJldCArPSAzOwo+ICsgICAgICAgaWYgKGhlX29wZXJfcGFyYW1zICYgSUVFRTgwMjEx X0hFX09QRVJBVElPTl9DT19IT1NURURfQlNTKQo+ICsgICAgICAgICAgICAgICByZXQrKzsKPiAr Cj4gKyAgICAgICByZXR1cm4gKHZvaWQgKilyZXQ7Cj4gK30KPiArCj4gCkdyZWF0LgoKPiAKPj4g ICNkZWZpbmUgSUVFRTgwMjExX1ZIVF9DQVBfTUFYX01QRFVfTEVOR1RIXzM4OTUJCQkweDAwMDAw MDAwCj4+ICAjZGVmaW5lIElFRUU4MDIxMV9WSFRfQ0FQX01BWF9NUERVX0xFTkdUSF83OTkxCQkJ MHgwMDAwMDAwMQo+PiBAQCAtMTk4Miw2ICsyMDI5LDE1IEBAIGludCBpZWVlODAyMTFfZ2V0X3Zo dF9tYXhfbnNzKHN0cnVjdCAKPj4gaWVlZTgwMjExX3ZodF9jYXAgKmNhcCwKPj4gICNkZWZpbmUg SUVFRTgwMjExX1RYX1JYX01DU19OU1NfU1VQUF9UWF9CSVRNQVBfTUFTSwkJCTB4MDdjMAo+PiAg I2RlZmluZSBJRUVFODAyMTFfVFhfUlhfTUNTX05TU19TVVBQX1JYX0JJVE1BUF9NQVNLCQkJMHhm ODAwCj4+IAo+PiArLyogODAyLjExYXggSEUgNiBHSHogQmFuZCBDYXBhYmlsaXR5ICovCj4+ICsj ZGVmaW5lIElFRUU4MDIxMV9IRV82R0haX0NBUF9NSU5fTVBEVV9TVEFSVF9TUEFDRV9NQVNLCQlH RU5NQVNLKDIsIAo+PiAwKQo+PiArI2RlZmluZSAKPj4gSUVFRTgwMjExX0hFXzZHSFpfQ0FQX01B WF9BX01QRFVfTEVOR1RIX0VYUE9ORU5UX01BU0sJR0VOTUFTSyg1LCAzKQo+PiArI2RlZmluZSBJ RUVFODAyMTFfSEVfNkdIWl9DQVBfTUFYX01QRFVfTEVOR1RIX01BU0sJCUdFTk1BU0soNywgNikK Pj4gKyNkZWZpbmUgSUVFRTgwMjExX0hFXzZHSFpfQ0FQX1NNUFNfTUFTSwkJCQlHRU5NQVNLKDEw LCA5KQo+PiArI2RlZmluZSBJRUVFODAyMTFfSEVfNkdIWl9DQVBfUkRfUkVTUAkJCQlCSVQoMTEp Cj4+ICsjZGVmaW5lIElFRUU4MDIxMV9IRV82R0haX0NBUF9SWF9BTlRFTk5BX1BBVFRFUk4JCUJJ VCgxMikKPj4gKyNkZWZpbmUgSUVFRTgwMjExX0hFXzZHSFpfQ0FQX1RYX0FOVEVOTkFfUEFUVEVS TgkJQklUKDEzKQo+IAo+IEkgZG9uJ3QgbGlrZSBHRU5NQVNLKCkgbXVjaCAuLi4gYnV0IG9rLiBG V0lXLCBJIGhhZAo+IApIb3BlIEdFTk1BU0sgZGVmaW5lZCBpbiBiYWNrcG9ydHMgZm9yIG9sZGVy IGtlcm5lbC4gSSBzdGFydGVkIHVzaW5nIHRoaXMgCnNpbmNlIGF0aDExay4KSSBmZWVsIEdFTk1B U0sgaXMgbW9yZSB1c2VyIHJlYWRhYmxlIGFuZCBhdm9pZCBtYXNraW5nIGVycm9ycy4KCj4gK3N0 cnVjdCBpZWVlODAyMTFfaGVfNmdoel9jYXBhIHsKPiArICAgICAgIC8qIHVzZXMgSUVFRTgwMjEx X0hFXzZHSFpfQ0FQXyogYmVsb3cgKi8KPiArICAgICAgIF9fbGUxNiBjYXBhOwo+ICt9IF9fcGFj a2VkOwo+ICsKPiArLyogSEUgNiBHSHogYmFuZCBjYXBhYmlsaXRpZXMgKi8KPiArLyogdXNlcyBl bnVtIGllZWU4MDIxMV9taW5fbXBkdV9zcGFjaW5nIHZhbHVlcyAqLwo+ICsjZGVmaW5lIElFRUU4 MDIxMV9IRV82R0haX0NBUF9NSU5fTVBEVV9TVEFSVCAgIDB4MDAwNwo+ICsvKiB1c2VzIGVudW0g aWVlZTgwMjExX3ZodF9tYXhfYW1wZHVfbGVuZ3RoX2V4cCB2YWx1ZXMgKi8KPiArI2RlZmluZSBJ RUVFODAyMTFfSEVfNkdIWl9DQVBfTUFYX0FNUERVX0xFTl9FWFAgICAgICAgIDB4MDAzOAo+ICsv KiB1c2VzIElFRUU4MDIxMV9WSFRfQ0FQX01BWF9NUERVX0xFTkdUSF8qIHZhbHVlcyAqLwo+ICsj ZGVmaW5lIElFRUU4MDIxMV9IRV82R0haX0NBUF9NQVhfTVBEVV9MRU4gICAgIDB4MDBjMAo+ICsv KiBXTEFOX0hUX0NBUF9TTV9QU18qIHZhbHVlcyAqLwo+ICsjZGVmaW5lIElFRUU4MDIxMV9IRV82 R0haX0NBUF9TTV9QU19TSElGVCAgICAgICA5Cj4gKyNkZWZpbmUgSUVFRTgwMjExX0hFXzZHSFpf Q0FQX1NNX1BTICAgICAgICAgICAgMHgwNjAwCj4gKyNkZWZpbmUgSUVFRTgwMjExX0hFXzZHSFpf Q0FQX1JEX1JFU1BPTkRFUiAgICAgMHgwODAwCj4gKyNkZWZpbmUgSUVFRTgwMjExX0hFXzZHSFpf Q0FQX1JYX0FOVFBBVF9DT05TICAgMHgxMDAwCj4gKyNkZWZpbmUgSUVFRTgwMjExX0hFXzZHSFpf Q0FQX1RYX0FOVFBBVF9DT05TICAgMHgyMDAwCj4gCj4gCj4gYWdhaW4sIGp1c3Qgc2hvcnRlciBu YW1lcyAuLi4KPiAKSSBhbSBmaW5lIHdpdGggdGhpcy4uIExlYXZlIGl0IHRvIHlvdS4gQ2hlZXJz LgoKLVJhamt1bWFyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwphdGgxMWsgbWFpbGluZyBsaXN0CmF0aDExa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTFrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59AE5C433DF for ; Wed, 27 May 2020 17:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3165920707 for ; Wed, 27 May 2020 17:40:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="qNwoyBru" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388327AbgE0RkK (ORCPT ); Wed, 27 May 2020 13:40:10 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:37548 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387564AbgE0RkK (ORCPT ); Wed, 27 May 2020 13:40:10 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1590601208; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=Oh7ANtUIWThyAUINewPNEEgb4BBMXxQ/28NmDP3QMpk=; b=qNwoyBruYGpX2uNq9UyKy7ltg5etoJzRdhMqwc+Ejq1wTG+lN8eJwNLdeMBuUbeNUqSu35hQ RWYU1kXxjWYJJxY1FR06ulECqC7nUxQtWYWTKjg25ak3S+zFHUI89A7rGZOxuWmfibi6xeYJ Ulzlopl2LF0utEyJsp1XvbQXPxU= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 5ecea5ed2dd9e15ae383e4df (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 27 May 2020 17:39:57 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 77304C433CB; Wed, 27 May 2020 17:39:56 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rmanohar) by smtp.codeaurora.org (Postfix) with ESMTPSA id C2339C433C9; Wed, 27 May 2020 17:39:55 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 27 May 2020 10:39:55 -0700 From: Rajkumar Manoharan To: Johannes Berg Cc: kvalo@codeaurora.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH v3 03/11] nl80211: add HE 6 GHz Band Capability support In-Reply-To: <4e3a5ab6eed1dc91f45a459bb616fa05a110483d.camel@sipsolutions.net> References: <1589399105-25472-1-git-send-email-rmanohar@codeaurora.org> <1589399105-25472-3-git-send-email-rmanohar@codeaurora.org> <4e3a5ab6eed1dc91f45a459bb616fa05a110483d.camel@sipsolutions.net> Message-ID: X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-05-27 07:27, Johannes Berg wrote: > On Wed, 2020-05-13 at 12:44 -0700, Rajkumar Manoharan wrote: >> >> /** >> + * enum ieee80211_he_6ghz_chanwidth - HE 6 GHz channel width >> + * @IEEE80211_HE_6GHZ_CHANWIDTH_20MHZ: 20 MHz bandwidth >> + * @IEEE80211_HE_6GHZ_CHANWIDTH_40MHZ: 40 MHz bandwidth >> + * @IEEE80211_HE_6GHZ_CHANWIDTH_80MHZ: 80 MHz bandwidth >> + * @IEEE80211_HE_6GHZ_CHANWIDTH_80P80MHZ: 160 or 80+80 MHz bandwidth >> + */ >> +enum ieee80211_he_6ghz_chanwidth { >> + IEEE80211_HE_6GHZ_CHANWIDTH_20MHZ = 0, >> + IEEE80211_HE_6GHZ_CHANWIDTH_40MHZ = 1, >> + IEEE80211_HE_6GHZ_CHANWIDTH_80MHZ = 2, >> + IEEE80211_HE_6GHZ_CHANWIDTH_160MHZ_80P80MHZ = 3, >> +}; >> + >> +/** >> + * struct ieee80211_he_oper_6ghz_op_info - 6 GHz Operation >> Information >> + * >> + * This structure is defined as described in IEEE P802.11ax/D6.0, >> + * Figure 9-787k—6 GHz Operation Information field. >> + * >> + * @primary_chan: The channel number of the primary channel in the 6 >> GHz band. >> + * @control: First two bits defines channel width field indicates the >> BSS >> + * channel width and is set to 0 for 20 MHz, 1 for 40 MHz, 2 for 80 >> MHz, >> + * and 3 for 80+80 or 160 MHz. >> + * @center_freq_seg0_idx: Channel center frequency index for the 20 >> MHz, >> + * 40 MHz, or 80 MHz, or 80+80 MHz. >> + * @center_freq_seg1_idx: Channel center frequency index of the 160 >> MHz. >> + * @min_rate: Minimum rate, in units of 1 Mb/s, that the non-AP STA >> is allowed >> + * to use for sending PPDUs. >> + */ >> +struct ieee80211_he_oper_6ghz_op_info { >> + u8 primary_chan; >> + u8 control; >> + u8 center_freq_seg0_idx; >> + u8 center_freq_seg1_idx; >> + u8 min_rate; >> +} __packed; >> > > Looks like I had > > +/** > + * ieee80211_he_6ghz_oper - HE 6 GHz operation Information field > + * @primary: primary channel > + * @control: control flags > + * @ccfs0: channel center frequency segment 0 > + * @ccfs1: channel center frequency segment 1 > + * @minrate: minimum rate (in 1 Mbps units) > + */ > +struct ieee80211_he_6ghz_oper { > + u8 primary; > +#define IEEE80211_HE_6GHZ_OPER_CTRL_CHANWIDTH 0x3 > +#define IEEE80211_HE_6GHZ_OPER_CTRL_CHANWIDTH_20MHZ > 0 > +#define IEEE80211_HE_6GHZ_OPER_CTRL_CHANWIDTH_40MHZ > 1 > +#define IEEE80211_HE_6GHZ_OPER_CTRL_CHANWIDTH_80MHZ > 2 > +#define IEEE80211_HE_6GHZ_OPER_CTRL_CHANWIDTH_160MHZ > 3 > +#define IEEE80211_HE_6GHZ_OPER_CTRL_DUP_BEACON 0x4 > + u8 control; > + u8 ccfs0; > + u8 ccfs1; > + u8 minrate; > +} __packed; > > > Any objection to that? The names are getting _really_ long the way you > had them ... > Neat.. LGTM.. :) > FWIW, I also had a fix in ieee80211_he_oper_size() where the size of > the > oper is now sizeof(struct ieee80211_he_6ghz_oper). > > And this, to find it: > > +/** > + * ieee80211_he_6ghz_oper - obtain 6 GHz operation field > + * @he_oper: HE operation element (must be pre-validated for size) > + * but may be %NULL > + * > + * Return: a pointer to the 6 GHz operation field, or %NULL > + */ > +static inline const struct ieee80211_he_6ghz_oper * > +ieee80211_he_6ghz_oper(const struct ieee80211_he_operation *he_oper) > +{ > + const u8 *ret = (void *)&he_oper->optional; > + u32 he_oper_params; > + > + if (!he_oper) > + return NULL; > + > + he_oper_params = le32_to_cpu(he_oper->he_oper_params); > + > + if (!(he_oper_params & IEEE80211_HE_OPERATION_6GHZ_OP_INFO)) > + return NULL; > + if (he_oper_params & IEEE80211_HE_OPERATION_VHT_OPER_INFO) > + ret += 3; > + if (he_oper_params & IEEE80211_HE_OPERATION_CO_HOSTED_BSS) > + ret++; > + > + return (void *)ret; > +} > + > Great. > >> #define IEEE80211_VHT_CAP_MAX_MPDU_LENGTH_3895 0x00000000 >> #define IEEE80211_VHT_CAP_MAX_MPDU_LENGTH_7991 0x00000001 >> @@ -1982,6 +2029,15 @@ int ieee80211_get_vht_max_nss(struct >> ieee80211_vht_cap *cap, >> #define IEEE80211_TX_RX_MCS_NSS_SUPP_TX_BITMAP_MASK 0x07c0 >> #define IEEE80211_TX_RX_MCS_NSS_SUPP_RX_BITMAP_MASK 0xf800 >> >> +/* 802.11ax HE 6 GHz Band Capability */ >> +#define IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START_SPACE_MASK GENMASK(2, >> 0) >> +#define >> IEEE80211_HE_6GHZ_CAP_MAX_A_MPDU_LENGTH_EXPONENT_MASK GENMASK(5, 3) >> +#define IEEE80211_HE_6GHZ_CAP_MAX_MPDU_LENGTH_MASK GENMASK(7, 6) >> +#define IEEE80211_HE_6GHZ_CAP_SMPS_MASK GENMASK(10, 9) >> +#define IEEE80211_HE_6GHZ_CAP_RD_RESP BIT(11) >> +#define IEEE80211_HE_6GHZ_CAP_RX_ANTENNA_PATTERN BIT(12) >> +#define IEEE80211_HE_6GHZ_CAP_TX_ANTENNA_PATTERN BIT(13) > > I don't like GENMASK() much ... but ok. FWIW, I had > Hope GENMASK defined in backports for older kernel. I started using this since ath11k. I feel GENMASK is more user readable and avoid masking errors. > +struct ieee80211_he_6ghz_capa { > + /* uses IEEE80211_HE_6GHZ_CAP_* below */ > + __le16 capa; > +} __packed; > + > +/* HE 6 GHz band capabilities */ > +/* uses enum ieee80211_min_mpdu_spacing values */ > +#define IEEE80211_HE_6GHZ_CAP_MIN_MPDU_START 0x0007 > +/* uses enum ieee80211_vht_max_ampdu_length_exp values */ > +#define IEEE80211_HE_6GHZ_CAP_MAX_AMPDU_LEN_EXP 0x0038 > +/* uses IEEE80211_VHT_CAP_MAX_MPDU_LENGTH_* values */ > +#define IEEE80211_HE_6GHZ_CAP_MAX_MPDU_LEN 0x00c0 > +/* WLAN_HT_CAP_SM_PS_* values */ > +#define IEEE80211_HE_6GHZ_CAP_SM_PS_SHIFT 9 > +#define IEEE80211_HE_6GHZ_CAP_SM_PS 0x0600 > +#define IEEE80211_HE_6GHZ_CAP_RD_RESPONDER 0x0800 > +#define IEEE80211_HE_6GHZ_CAP_RX_ANTPAT_CONS 0x1000 > +#define IEEE80211_HE_6GHZ_CAP_TX_ANTPAT_CONS 0x2000 > > > again, just shorter names ... > I am fine with this.. Leave it to you. Cheers. -Rajkumar