From: Chao Yu <chao@kernel.org>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: chao@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] erofs: allow 16-byte volume name again
Date: Sun, 16 Mar 2025 09:27:08 +0800 [thread overview]
Message-ID: <e9b19fa0-4d07-445a-aed6-e041300425ef@kernel.org> (raw)
In-Reply-To: <20250225033934.2542635-1-hsiangkao@linux.alibaba.com>
On 2025/2/25 11:39, Gao Xiang wrote:
> Actually, volume name doesn't need to include the NIL terminator if
> the string length matches the on-disk field size as mentioned in [1].
>
> I tend to relax it together with the upcoming 48-bit block addressing
> (or stable kernels which backport this fix) so that we could have a
> chance to record a 16-byte volume name like ext4.
>
> Since in-memory `volume_name` has no user, just get rid of the unneeded
> check for now. `sbi->uuid` is useless and avoid it too.
>
> Fixes: a64d9493f587 ("staging: erofs: refuse to mount images with malformed volume name")
> [1] https://lore.kernel.org/r/96efe46b-dcce-4490-bba1-a0b00932d1cc@linux.alibaba.com
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
prev parent reply other threads:[~2025-03-16 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 3:39 [PATCH] erofs: allow 16-byte volume name again Gao Xiang
2025-02-25 3:39 ` Gao Xiang
2025-03-16 1:27 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9b19fa0-4d07-445a-aed6-e041300425ef@kernel.org \
--to=chao@kernel.org \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.