From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F126F30D3FA; Tue, 16 Jun 2026 07:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781595421; cv=none; b=gKCCkKfURiHIr00qVc4CuEzvJ2P3i/xdAsNgmYbpJlSIDZIdFvVm5QUoprOT2wEibA2bGT6gAPJpk8S+jXEHDPJ3vP2jGLqhXdirtZ0sK7uazfAqvOJuM/aZjbhRoWuv5I/whMUCCnTkuMxFiqy31H4OkQ6AN8ijuuXmoxuy0is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781595421; c=relaxed/simple; bh=C0SQXZXcDK37wkHElxqiRp0RIECcOs5tuub8eZyEmJ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F73E3cb8DLmTIOJp7Z+ZhGEXu5GhG46vVvuhPFS8hRHLehJMrtoFyovYb+Q7Wdp+QVoA4MQ0L7KmDlfWE6Hkyv6tJzVEqFrOygwpapoc1l0PvBaxG5OTxCpRR41mu1XhHSGWTOaaSXFAwYq/QyEJExZaFqt5EK3gQVuGoqaeHHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WVuT1eoO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WVuT1eoO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5444F1F000E9; Tue, 16 Jun 2026 07:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781595420; bh=5Zuvpy/om7dvDoo0bahuFE1gIzJ3xVFBIKDkOPcndWI=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=WVuT1eoOY8TWzkywZHqQyFYaW5P3K31o1i1TgmDQ7B7poDBJrGLNtZoA4HLoVJHXB BeotV6NhvZOZnlmLRktEz+gAmzKry1Y+KwFLpzOTiqUx0rhc/jqypJLYq4upmu5vLs +Y8VwPCYDSgHd2FBh42LzJV6zH0vuRo/DP7bzXlUR8OrjNhZLZdK8Ba1CN/BtCCUM3 n/DDljxzH6+JlJMB2B1h6bb+AlwWfgqqC2/prIWG8kFEp322QJiYJTODdhUvV2d91J 80okA7PtATHRAxvCaNUP6gT4pv98SU9xza0S19A76Av4r00d1xhHvBrP0HMi20YhUJ oVC4UUnv/PIxg== Message-ID: Date: Tue, 16 Jun 2026 16:36:55 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/15] mm/slab: pass alloc_flags through slab_post_alloc_hook() chain To: "Vlastimil Babka (SUSE)" Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Suren Baghdasaryan , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org References: <20260615-slab_alloc_flags-v3-0-ce1146d140fb@kernel.org> <20260615-slab_alloc_flags-v3-8-ce1146d140fb@kernel.org> Content-Language: en-US From: Harry Yoo In-Reply-To: <20260615-slab_alloc_flags-v3-8-ce1146d140fb@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------EkvyZtXuR3d9K5ob5n80abvz" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------EkvyZtXuR3d9K5ob5n80abvz Content-Type: multipart/mixed; boundary="------------stFMe09eLufvGCHekZ4jWmS0"; protected-headers="v1" From: Harry Yoo To: "Vlastimil Babka (SUSE)" Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Suren Baghdasaryan , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Message-ID: Subject: Re: [PATCH v3 08/15] mm/slab: pass alloc_flags through slab_post_alloc_hook() chain References: <20260615-slab_alloc_flags-v3-0-ce1146d140fb@kernel.org> <20260615-slab_alloc_flags-v3-8-ce1146d140fb@kernel.org> In-Reply-To: <20260615-slab_alloc_flags-v3-8-ce1146d140fb@kernel.org> --------------stFMe09eLufvGCHekZ4jWmS0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 6/15/26 8:54 PM, Vlastimil Babka (SUSE) wrote: > Convert the whole following call stack to pass either slab_alloc_contex= t > (thus including alloc_flags) or just alloc_flags as necessary: >=20 > slab_post_alloc_hook() > alloc_tagging_slab_alloc_hook() > __alloc_tagging_slab_alloc_hook() > prepare_slab_obj_exts_hook() > alloc_slab_obj_exts() > memcg_slab_post_alloc_hook() > __memcg_slab_post_alloc_hook() > alloc_slab_obj_exts() >=20 > Converting all these at once avoids unnecessary churn and is mostly > mechanical. >=20 > This ultimately allows to decide if spinning is allowed using > alloc_flags in alloc_slab_obj_exts(), as well as slab_post_alloc_hook()= =2E > Aside from alloc_from_pcs_bulk() (to be handled next) there is nothing > else in slab itself relying on gfpflags_allow_spinning() which can > be false even if not called from kmalloc_nolock(). >=20 > A followup change will also use the alloc_flags availability in the cal= l > stack above to remove the __GFP_NO_OBJ_EXT flag. >=20 > For alloc_slab_obj_exts(), also replace the suboptimal "bool new_slab" > parameter with a SLAB_ALLOC_NEW_SLAB flag with identical functionality.= >=20 > To further reduce the number of parameters of slab_post_alloc_hook(), > also make 'struct list_lru *lru' (which is NULL for most callers) a new= > field of slab_alloc_context. >=20 > Link: https://patch.msgid.link/20260610-slab_alloc_flags-v2-9-7190909db= 118@kernel.org > Signed-off-by: Vlastimil Babka (SUSE) > --- Looks good to me, Reviewed-by: Harry Yoo (Oracle) --=20 Cheers, Harry / Hyeonggon --------------stFMe09eLufvGCHekZ4jWmS0-- --------------EkvyZtXuR3d9K5ob5n80abvz Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQQ1ub6gR5ogjaKRmOGXBN6rc5S1gUCajD9GAAKCRCGXBN6rc5S 1swRAQC5Heey0qs5T5oZbvAP8kXpLeXbOKeSkTmZwj4iV8q5MgD/a/a6PMtHlo/f Ji3GIS4uuYi9wu5M9w3uDj6nDa5b/Qg= =E0J3 -----END PGP SIGNATURE----- --------------EkvyZtXuR3d9K5ob5n80abvz--