All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>,
	OpenEmbedded Core Mailing List
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] openssl: Use the c_rehash shell re-implementation for target
Date: Mon, 18 Mar 2019 23:34:57 +0000	[thread overview]
Message-ID: <e9d01fa735d068ea16da35db9cf303841b67b909.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190318133618.4022-1-otavio@ossystems.com.br>

On Mon, 2019-03-18 at 10:36 -0300, Otavio Salvador wrote:
> We had a c_rehash shell re-implementation being used for the native
> package and there is no reason to not use it as well for the
> target. This allows it to be available without the need of perl being
> installed.
> 
> This partially reverts OE-Core:d2b1a889ef (openssl: move c_rehash pkg
> to avoid perl dep) but still allows the removal of perl
> dependency.
> 
> The respective re-implementation was already in use here at OE-Core
> by
> the OpenSSL 1.0 recipe (since 2016) and were removed from the target
> recipe during the upgrade to the 1.1 release. So it now aligns the
> native and target recipes.
> 
> ,----
> > Author: Otavio Salvador <otavio@ossystems.com.br>
> > Date:   Mon May 23 17:45:25 2016 -0300
> > 
> >     openssl: Add Shell-Script based c_rehash utility
> > 
> >     The PLD Linux distribution has ported the c_rehash[1] utility
> > from
> >     Perl to Shell-Script, allowing it to be shipped by default.
> > 
> >     1. 
> > https://git.pld-linux.org/?p=packages/openssl.git;a=blob;f=openssl-c_rehash.sh;h=0ea22637ee6dbce845a9e2caf62540aaaf5d0761
> > 
> >     The OpenSSL upstream intends[2] to convert the utility for C
> >     however did not yet finished the conversion.
> > 
> >     2. https://rt.openssl.org/Ticket/Display.html?id=2324
> > 
> >     This patch adds this script and thus removed the Perl
> > requirement
> >     for it.
> > 
> >     Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >     Signed-off-by: Richard Purdie <
> > richard.purdie@linuxfoundation.org>
> `----

I went to have a look at how this upstream C utility was going and
found that they've moved to github issues and there is no such issue
open.

The closest I could get to patches was http://openssl.6102.n7.nabble.com/openssl-org-3505-rewrite-c-rehash-in-C-td53069.html

Could you open a github issue asking if they can move to a C or shell
util as some projects don't want a perl dependency like that? I'd like
to understand upstream's intentions in this area. Do they have a reason
for using perl here that we're missing?

Cheers,

Richard



  parent reply	other threads:[~2019-03-18 23:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 13:36 [PATCH v2] openssl: Use the c_rehash shell re-implementation for target Otavio Salvador
2019-03-18 14:53 ` Alexander Kanavin
2019-03-18 16:00   ` Otavio Salvador
2019-03-18 16:09     ` Alexander Kanavin
2019-03-18 23:18       ` Richard Purdie
2019-03-18 23:26         ` Otavio Salvador
2019-03-18 23:34 ` Richard Purdie [this message]
2019-03-18 23:52   ` Andre McCurdy
2019-03-18 23:56     ` Richard Purdie
2019-03-19  0:10       ` Otavio Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9d01fa735d068ea16da35db9cf303841b67b909.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.