From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752827AbdLKKUJ (ORCPT ); Mon, 11 Dec 2017 05:20:09 -0500 Received: from www62.your-server.de ([213.133.104.62]:46176 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752777AbdLKKUE (ORCPT ); Mon, 11 Dec 2017 05:20:04 -0500 Subject: Re: Linux 4.15-rc3 (uml + bpf_perf_event.h) To: Richard Weinberger , Randy Dunlap , "netdev@vger.kernel.org" Cc: Linus Torvalds , Linux Kernel Mailing List , alexei.starovoitov@gmail.com, brueckner@linux.vnet.ibm.com References: <4a55b480-a35b-1432-95d6-079857bceca5@infradead.org> <7534692.EB8JgYtGIt@blindfold> From: Daniel Borkmann Message-ID: Date: Mon, 11 Dec 2017 11:19:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <7534692.EB8JgYtGIt@blindfold> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, hi Richard, [ +Hendrik for c895f6f703ad7dd2f ] On 12/11/2017 09:32 AM, Richard Weinberger wrote: > Randy, > > Am Montag, 11. Dezember 2017, 03:42:12 CET schrieb Randy Dunlap: >> On 12/10/2017 06:08 PM, Linus Torvalds wrote: >>> Another week, another rc. >> >> um (uml) won't build on i386 or x86_64: >> >> CC init/main.o >> In file included from ../include/linux/perf_event.h:18:0, >> from ../include/linux/trace_events.h:10, >> from ../include/trace/syscall.h:7, >> from ../include/linux/syscalls.h:82, >> from ../init/main.c:20: >> ../include/uapi/linux/bpf_perf_event.h:11:32: fatal error: >> asm/bpf_perf_event.h: No such file or directory #include >> >> ^ >> compilation terminated. >> ../scripts/Makefile.build:310: recipe for target 'init/main.o' failed > > How do you trigger that build failure? > Can you share your .config? Hmm, too bad kbuild bot doesn't catch issues on uml. I'm not too familiar with uml, but looks like it's the only special case where there's no arch/um/include/uapi/asm/. What is the usual convention to pull in such headers in this case? Something like the below, would that fix it for you? Thanks for your help, Daniel arch/um/include/asm/bpf_perf_event.h | 1 + include/asm-generic/bpf_perf_event.h | 1 + 2 files changed, 2 insertions(+) create mode 100644 arch/um/include/asm/bpf_perf_event.h create mode 100644 include/asm-generic/bpf_perf_event.h diff --git a/arch/um/include/asm/bpf_perf_event.h b/arch/um/include/asm/bpf_perf_event.h new file mode 100644 index 0000000..3097758 --- /dev/null +++ b/arch/um/include/asm/bpf_perf_event.h @@ -0,0 +1 @@ +#include diff --git a/include/asm-generic/bpf_perf_event.h b/include/asm-generic/bpf_perf_event.h new file mode 100644 index 0000000..67112e5 --- /dev/null +++ b/include/asm-generic/bpf_perf_event.h @@ -0,0 +1 @@ +#include -- 2.9.5