From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>
Subject: [PATCH for-4.20? 1/3] AMD/IOMMU: drop stray MSI enabling
Date: Thu, 30 Jan 2025 12:11:52 +0100 [thread overview]
Message-ID: <ea0fea03-6002-4fc6-86ac-19598c9d9ef6@suse.com> (raw)
In-Reply-To: <2bb9d3c4-0761-4d63-8193-29293e35eb04@suse.com>
While the 2nd of the commits referenced below should have moved the call
to amd_iommu_msi_enable() instead of adding another one, the situation
wasn't quite right even before: It can't have done any good to enable
MSI when no IRQ was allocated for it, yet.
Fixes: 5f569f1ac50e ("AMD/IOMMU: allow enabling with IRQ not yet set up")
Fixes: d9e49d1afe2e ("AMD/IOMMU: adjust setup of internal interrupt for x2APIC mode")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/amd/iommu_init.c
+++ b/xen/drivers/passthrough/amd/iommu_init.c
@@ -902,8 +902,6 @@ static void enable_iommu(struct amd_iomm
}
}
- amd_iommu_msi_enable(iommu, IOMMU_CONTROL_ENABLED);
-
set_iommu_ht_flags(iommu);
set_iommu_command_buffer_control(iommu, IOMMU_CONTROL_ENABLED);
next prev parent reply other threads:[~2025-01-30 11:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 11:10 [PATCH for-4.20 0/3] AMD/IOMMU: assorted corrections Jan Beulich
2025-01-30 11:11 ` Jan Beulich [this message]
2025-01-31 18:46 ` [PATCH for-4.20? 1/3] AMD/IOMMU: drop stray MSI enabling Jason Andryuk
2025-02-02 13:50 ` Andrew Cooper
2025-02-03 8:41 ` Jan Beulich
2025-02-03 14:19 ` Andrew Cooper
2025-02-03 15:53 ` Jan Beulich
2025-02-03 16:19 ` Andrew Cooper
2025-01-30 11:12 ` [PATCH for-4.20 2/3] x86/PCI: init segments earlier Jan Beulich
2025-01-31 18:47 ` Jason Andryuk
2025-02-02 14:46 ` Andrew Cooper
2025-02-03 9:09 ` Jan Beulich
2025-02-03 15:31 ` Andrew Cooper
2025-02-03 12:45 ` Roger Pau Monné
2025-02-03 13:00 ` Jan Beulich
2025-02-03 13:03 ` Jan Beulich
2025-02-03 14:23 ` Andrew Cooper
2025-02-03 15:55 ` Jan Beulich
2025-01-30 11:13 ` [PATCH for-4.20? 3/3] AMD/IOMMU: log IVHD contents Jan Beulich
2025-01-31 18:47 ` Jason Andryuk
2025-02-02 13:57 ` Andrew Cooper
2025-01-31 11:18 ` [PATCH for-4.20 0/3] AMD/IOMMU: assorted corrections Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea0fea03-6002-4fc6-86ac-19598c9d9ef6@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.