From: Oliver Neukum <oneukum@suse.com>
To: "Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Chas Williams <3chas3@gmail.com>,
Duncan Sands <duncan.sands@free.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
accessrunner-general@lists.sourceforge.net,
linux-atm-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] USB: usbfs: replace __get_free_page() with kmalloc()
Date: Mon, 31 Aug 2026 15:27:07 +0200 [thread overview]
Message-ID: <ea165ff8-cda2-4fed-9354-1d14ac2d87ca@suse.com> (raw)
In-Reply-To: <20260830-usb-v1-1-aa349c302246@kernel.org>
On 30.08.26 10:10, Mike Rapoport (Microsoft) wrote:
> do_proc_control() allocates a temporary buffer for the data stage of a
> control transfer issued from userspace.
>
> This buffer can be allocated with kmalloc() as there's nothing special
> about it to go directly to the page allocator.
You are breaking the calculation. A page has a size of exactly
PAGE_SIZE. A kmalloced object of PAGE_SIZE is larger. That is
a bad idea.
Regards
Oliver
next prev parent reply other threads:[~2026-08-31 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-30 8:10 [PATCH 0/4] USB: replace page allocator calls with kmalloc() Mike Rapoport (Microsoft)
2026-08-30 8:10 ` [PATCH 1/4] USB: usbfs: replace __get_free_page() " Mike Rapoport (Microsoft)
2026-08-31 13:27 ` Oliver Neukum [this message]
2026-08-31 14:24 ` Mike Rapoport
2026-08-31 14:30 ` Alan Stern
2026-09-02 14:36 ` Vlastimil Babka (SUSE)
2026-08-30 8:10 ` [PATCH 2/4] USB: cxacru: " Mike Rapoport (Microsoft)
2026-08-30 8:10 ` [PATCH 3/4] USB: speedtch: " Mike Rapoport (Microsoft)
2026-08-30 8:10 ` [PATCH 4/4] USB: serial: wwan: " Mike Rapoport (Microsoft)
2026-09-03 2:00 ` [PATCH 0/4] USB: replace page allocator calls " patchwork-bot+netdevbpf
2026-09-03 6:20 ` Johan Hovold
2026-09-03 10:54 ` Johan Hovold
2026-09-03 23:20 ` Jakub Kicinski
2026-09-08 9:12 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea165ff8-cda2-4fed-9354-1d14ac2d87ca@suse.com \
--to=oneukum@suse.com \
--cc=3chas3@gmail.com \
--cc=accessrunner-general@lists.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=duncan.sands@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=vbabka@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.