diff for duplicates of <ea25141d-b337-94c8-970b-1289b8dfdefb@users.sourceforge.net> diff --git a/a/1.txt b/N1/1.txt index 6561022..fcb9574 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -43,7 +43,7 @@ index b479747..496b27f 100644 static int vpbe_g_cropcap(struct vpbe_device *vpbe_dev, struct v4l2_cropcap *cropcap) { -- if (NULL = cropcap) +- if (NULL == cropcap) + if (!cropcap) return -EINVAL; cropcap->bounds.left = 0; @@ -52,7 +52,7 @@ index b479747..496b27f 100644 int curr_output = output_index; int i; -- if (NULL = mode) +- if (NULL == mode) + if (!mode) return -EINVAL; @@ -61,7 +61,7 @@ index b479747..496b27f 100644 static int vpbe_get_current_mode_info(struct vpbe_device *vpbe_dev, struct vpbe_enc_mode_info *mode_info) { -- if (NULL = mode_info) +- if (NULL == mode_info) + if (!mode_info) return -EINVAL; @@ -79,7 +79,7 @@ index b479747..496b27f 100644 int ret = 0; int i; -- if ((NULL = mode_info) || (NULL = mode_info->name)) +- if ((NULL == mode_info) || (NULL == mode_info->name)) + if (!mode_info || !mode_info->name) return -EINVAL; @@ -88,7 +88,7 @@ index b479747..496b27f 100644 } /* Only custom timing should reach here */ -- if (preset_mode = NULL) +- if (preset_mode == NULL) + if (!preset_mode) return -EINVAL; @@ -109,7 +109,7 @@ index b479747..496b27f 100644 * from the platform device by iteration of platform drivers and * matching with device name */ -- if (NULL = vpbe_dev || NULL = dev) { +- if (NULL == vpbe_dev || NULL == dev) { + if (!vpbe_dev || !dev) { printk(KERN_ERR "Null device pointers.\n"); return -ENODEV; @@ -118,7 +118,7 @@ index b479747..496b27f 100644 vpbe_dev->venc = venc_sub_dev_init(&vpbe_dev->v4l2_dev, vpbe_dev->cfg->venc.module_name); /* register venc sub device */ -- if (vpbe_dev->venc = NULL) { +- if (vpbe_dev->venc == NULL) { + if (!vpbe_dev->venc) { v4l2_err(&vpbe_dev->v4l2_dev, "vpbe unable to init venc sub device\n"); @@ -137,7 +137,7 @@ index b479747..496b27f 100644 vpbe_dev->encoders = kmalloc_array(num_encoders, sizeof(*vpbe_dev->encoders), GFP_KERNEL); -- if (NULL = vpbe_dev->encoders) { +- if (NULL == vpbe_dev->encoders) { + if (!vpbe_dev->encoders) { ret = -ENOMEM; goto fail_dev_unregister; @@ -145,7 +145,7 @@ index b479747..496b27f 100644 @@ -715,7 +714,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev) } /* Add amplifier subdevice for dm365 */ - if ((strcmp(vpbe_dev->cfg->module_name, "dm365-vpbe-display") = 0) && + if ((strcmp(vpbe_dev->cfg->module_name, "dm365-vpbe-display") == 0) && - vpbe_dev->cfg->amp != NULL) { + vpbe_dev->cfg->amp) { amp_info = vpbe_dev->cfg->amp; @@ -155,7 +155,7 @@ index b479747..496b27f 100644 struct vpbe_config *cfg; int ret = -EINVAL; -- if (pdev->dev.platform_data = NULL) { +- if (pdev->dev.platform_data == NULL) { + if (!pdev->dev.platform_data) { v4l2_err(pdev->dev.driver, "No platform data\n"); return -ENODEV; diff --git a/a/content_digest b/N1/content_digest index 8dea701..7bf271a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,7 +2,7 @@ "ref\0fdf72877-08a9-1a86-aec8-627a378258da@users.sourceforge.net\0" "From\0SF Markus Elfring <elfring@users.sourceforge.net>\0" "Subject\0[PATCH resent 03/34] [media] DaVinci-VPBE: Adjust 16 checks for null pointers\0" - "Date\0Wed, 12 Oct 2016 17:15:49 +0000\0" + "Date\0Wed, 12 Oct 2016 19:15:49 +0200\0" "To\0linux-media@vger.kernel.org" Hans Verkuil <hans.verkuil@cisco.com> Lad @@ -58,7 +58,7 @@ " static int vpbe_g_cropcap(struct vpbe_device *vpbe_dev,\n" " \t\t\t struct v4l2_cropcap *cropcap)\n" " {\n" - "-\tif (NULL = cropcap)\n" + "-\tif (NULL == cropcap)\n" "+\tif (!cropcap)\n" " \t\treturn -EINVAL;\n" " \tcropcap->bounds.left = 0;\n" @@ -67,7 +67,7 @@ " \tint curr_output = output_index;\n" " \tint i;\n" " \n" - "-\tif (NULL = mode)\n" + "-\tif (NULL == mode)\n" "+\tif (!mode)\n" " \t\treturn -EINVAL;\n" " \n" @@ -76,7 +76,7 @@ " static int vpbe_get_current_mode_info(struct vpbe_device *vpbe_dev,\n" " \t\t\t\t struct vpbe_enc_mode_info *mode_info)\n" " {\n" - "-\tif (NULL = mode_info)\n" + "-\tif (NULL == mode_info)\n" "+\tif (!mode_info)\n" " \t\treturn -EINVAL;\n" " \n" @@ -94,7 +94,7 @@ " \tint ret = 0;\n" " \tint i;\n" " \n" - "-\tif ((NULL = mode_info) || (NULL = mode_info->name))\n" + "-\tif ((NULL == mode_info) || (NULL == mode_info->name))\n" "+\tif (!mode_info || !mode_info->name)\n" " \t\treturn -EINVAL;\n" " \n" @@ -103,7 +103,7 @@ " \t}\n" " \n" " \t/* Only custom timing should reach here */\n" - "-\tif (preset_mode = NULL)\n" + "-\tif (preset_mode == NULL)\n" "+\tif (!preset_mode)\n" " \t\treturn -EINVAL;\n" " \n" @@ -124,7 +124,7 @@ " \t * from the platform device by iteration of platform drivers and\n" " \t * matching with device name\n" " \t */\n" - "-\tif (NULL = vpbe_dev || NULL = dev) {\n" + "-\tif (NULL == vpbe_dev || NULL == dev) {\n" "+\tif (!vpbe_dev || !dev) {\n" " \t\tprintk(KERN_ERR \"Null device pointers.\\n\");\n" " \t\treturn -ENODEV;\n" @@ -133,7 +133,7 @@ " \tvpbe_dev->venc = venc_sub_dev_init(&vpbe_dev->v4l2_dev,\n" " \t\t\t\t\t vpbe_dev->cfg->venc.module_name);\n" " \t/* register venc sub device */\n" - "-\tif (vpbe_dev->venc = NULL) {\n" + "-\tif (vpbe_dev->venc == NULL) {\n" "+\tif (!vpbe_dev->venc) {\n" " \t\tv4l2_err(&vpbe_dev->v4l2_dev,\n" " \t\t\t\"vpbe unable to init venc sub device\\n\");\n" @@ -152,7 +152,7 @@ " \tvpbe_dev->encoders = kmalloc_array(num_encoders,\n" " \t\t\t\t\t sizeof(*vpbe_dev->encoders),\n" " \t\t\t\t\t GFP_KERNEL);\n" - "-\tif (NULL = vpbe_dev->encoders) {\n" + "-\tif (NULL == vpbe_dev->encoders) {\n" "+\tif (!vpbe_dev->encoders) {\n" " \t\tret = -ENOMEM;\n" " \t\tgoto fail_dev_unregister;\n" @@ -160,7 +160,7 @@ "@@ -715,7 +714,7 @@ static int vpbe_initialize(struct device *dev, struct vpbe_device *vpbe_dev)\n" " \t}\n" " \t/* Add amplifier subdevice for dm365 */\n" - " \tif ((strcmp(vpbe_dev->cfg->module_name, \"dm365-vpbe-display\") = 0) &&\n" + " \tif ((strcmp(vpbe_dev->cfg->module_name, \"dm365-vpbe-display\") == 0) &&\n" "-\t\t\tvpbe_dev->cfg->amp != NULL) {\n" "+\t vpbe_dev->cfg->amp) {\n" " \t\tamp_info = vpbe_dev->cfg->amp;\n" @@ -170,7 +170,7 @@ " \tstruct vpbe_config *cfg;\n" " \tint ret = -EINVAL;\n" " \n" - "-\tif (pdev->dev.platform_data = NULL) {\n" + "-\tif (pdev->dev.platform_data == NULL) {\n" "+\tif (!pdev->dev.platform_data) {\n" " \t\tv4l2_err(pdev->dev.driver, \"No platform data\\n\");\n" " \t\treturn -ENODEV;\n" @@ -178,4 +178,4 @@ "-- \n" 2.10.1 -819d977691b54333ab96f4e30f9328d2f1fa2e4e88d717b5c2dfaa003e057720 +e6d92df9ab39d6b539214db5dfbc84e36fc537808e8917e236691f259e50905c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.