From: "Jürg Billeter" <j@bitron.ch>
To: Miklos Szeredi <miklos@szeredi.hu>, Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [REGRESSION] fuse: copy_file_range() fails with EIO
Date: Thu, 22 Aug 2024 15:12:17 +0200 [thread overview]
Message-ID: <ea297a16508dbf8ecfa4417cc88eef95b5d697e8.camel@bitron.ch> (raw)
In-Reply-To: <CAJfpegvVc_bZbL1bjcEbEh4+WU=XVS94NMyBPKbcHzAzyxM6_Q@mail.gmail.com>
On Thu, 2024-08-22 at 15:04 +0200, Miklos Szeredi wrote:
> On Sat, 10 Aug 2024 at 17:12, Matthew Wilcox <willy@infradead.org> wrote:
> > That's what I suspected was going wrong -- we're trying to end a read on
> > a folio that is already uptodate. Miklos, what the hell is FUSE doing
> > here?
>
> Ah, this is the fancy page cache replacement done in
> fuse_try_move_page().
>
> I understand how this triggers VM_BUG_ON_FOLIO() in folio_end_read().
>
> What I don't understand is how this results in the -EIO that Jürg
> reported.
I'm not really familiar with this code but it seems `folio_end_read()`
uses xor to update the `PG_uptodate` flag. So if it was already set, it
will incorrectly clear the `PG_uptodate` set, which I guess triggers
the issue.
Jürg
next prev parent reply other threads:[~2024-08-22 13:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 15:53 [REGRESSION] fuse: copy_file_range() fails with EIO Jürg Billeter
2024-08-09 16:03 ` Matthew Wilcox
2024-08-09 16:22 ` [PATCH 1/3] fuse: remove call to SetPageError Matthew Wilcox (Oracle)
2024-08-09 16:22 ` [PATCH 2/3] fuse: Use a folio instead of a page Matthew Wilcox (Oracle)
2024-08-09 16:22 ` [PATCH 3/3] fuse: use folio_end_read Matthew Wilcox (Oracle)
2024-08-10 12:24 ` Jürg Billeter
2024-08-20 12:57 ` Jürg Billeter
2024-08-20 13:50 ` Matthew Wilcox
2024-08-22 11:58 ` Miklos Szeredi
2024-08-22 12:25 ` Matthew Wilcox
2024-08-10 5:56 ` [REGRESSION] fuse: copy_file_range() fails with EIO Jürg Billeter
2024-08-10 15:12 ` Matthew Wilcox
2024-08-22 13:04 ` Miklos Szeredi
2024-08-22 13:12 ` Jürg Billeter [this message]
2024-08-22 13:14 ` Miklos Szeredi
2024-08-22 13:32 ` Miklos Szeredi
2024-08-22 14:14 ` Jürg Billeter
2024-08-29 9:27 ` Marcel Ziswiler
2024-08-29 9:30 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea297a16508dbf8ecfa4417cc88eef95b5d697e8.camel@bitron.ch \
--to=j@bitron.ch \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=regressions@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.