Re: [PATCH v4 net-next 1/1] sched: Add dualpi2 qdisc

[Paolo Abeni <pabeni@redhat.com>]

On 10/22/24 00:12, chia-yu.chang@nokia-bell-labs.com wrote:
> +/* Default alpha/beta values give a 10dB stability margin with max_rtt=100ms. */
> +static void dualpi2_reset_default(struct dualpi2_sched_data *q)
> +{
> +	q->sch->limit = 10000;				/* Max 125ms at 1Gbps */
> +
> +	q->pi2.target = 15 * NSEC_PER_MSEC;
> +	q->pi2.tupdate = 16 * NSEC_PER_MSEC;
> +	q->pi2.alpha = dualpi2_scale_alpha_beta(41);	/* ~0.16 Hz * 256 */
> +	q->pi2.beta = dualpi2_scale_alpha_beta(819);	/* ~3.20 Hz * 256 */
> +
> +	q->step.thresh = 1 * NSEC_PER_MSEC;
> +	q->step.in_packets = false;
> +
> +	dualpi2_calculate_c_protection(q->sch, q, 10);	/* wc=10%, wl=90% */
> +
> +	q->ecn_mask = INET_ECN_ECT_1;
> +	q->coupling_factor = 2;		/* window fairness for equal RTTs */
> +	q->drop_overload = true;	/* Preserve latency by dropping */
> +	q->drop_early = false;		/* PI2 drops on dequeue */
> +	q->split_gso = true;

This is a very unexpected default. Splitting GSO packets earlier WRT the
H/W constaints definitely impact performances in a bad way.

Under which condition this is expected to give better results?
It should be at least documented clearly.

Thanks,

Paolo