From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794744973; b=FT9zXTL9Q8h0RISd9Wf28Z9nuBMO7lSFKKBGkh431KswKXKPrczz7K8NCCkdjbDE/mP1 9MMnV59pSB5hMlDbZrhht5W3A56fchVx9qamxTyY4S3+SHLaihAvfS6cPiY0iK4kgaff+ y7t/AkruEVBvyzTLm/Z4rRCu/8WAxV6XHDl1gwl0LRz+5MaB7XehfY5iDr4dsEWPZSNfX LXK3uKukOQU5samLlQloeNMJzRZFJqj9NiqzlTk2C+LgfyToM9Tsd/FyWeCzQJVLJNBGg hW6jhRvHd5cAyZFO5yfzzjWjBK5XNOimGJDC6yl+IVIabfyi7fOvEJcCZF5Y9PZNknw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794744973; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From: Content-Language:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=Cze6EXMazudJouVIRWBezoVb+gMXv48f+e410Dy7G9s=; b=uzleUudSV3c4TqAbxidswQUrCKCOXR7kbi7WBjyNfsAGluM0ANCJWIobDZI+r+QT+1e1 BX6PeBzSuQb0zytga1cFn/OSO+kAEznhRqBVVRh99tsGRnQ5O1QZ254MbgHHfbIBzYZZP LdM97i7wJoSshPUkCYH5BQ3WSyBbRfmvfvfOGVGDX3RdIkFVv2CHK1/bNaf7Wqt6lpRB1 81k0TiQcMin8RQJ/0SMyBEqGGD7Gx8PqTfTky7QH6bMybybEfgpquP3ZDnv8GV0u5tSqp LnHT9ehfGxqRdAZu+EbLYG/BG/pQQtsQUzBt3Yhxst1f9DasrJg4SNEz6tw4CIdI8FA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UMWGuZNB; arc=none smtp.remote-ip=209.85.221.53 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24758606A323 for ; Sun, 15 Nov 2026 12:16:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 24758606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=UMWGuZNB Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-48e20ed3b9dso2823536f8f.2 for ; Sun, 15 Nov 2026 04:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794744971; x=1795349771; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Cze6EXMazudJouVIRWBezoVb+gMXv48f+e410Dy7G9s=; b=UMWGuZNBsMnss2pwsw8rRFNOryhk6F4P5MsSQtbTOUSYf7p8ABU3vk4PaN1KFgXJ4m sLw57i7wKveAJsqJXa81ii4bayts99u5hg3J+aNyMOI795yl24cB+IpfYz5/HXSDqzz5 8J81IXNBLkrq8pNuLrlDSWMlsmGEW+JxD6BDFcXHLBQjB+J9eOnH/escoFzz40YDBxpa l4K4aqxKU+xhxj/c2gSNDaf+IV7G2FNCNjefQ2qzQHvzhnP9uPM67bTReYKQRNnzW10P /U8EwovAUK3sCoJtrorcb/qNryT5hTEQM7Pctt8EMwGpw2KT7wD4z3gD8bIyUjh/OWZF nvvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794744971; x=1795349771; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Cze6EXMazudJouVIRWBezoVb+gMXv48f+e410Dy7G9s=; b=Si6pgzyY6Fjyu886Vs+q/TfQ48FOZThTEjE04Jhsn2RYL4sCQ8ORdoI5T78dHCxZB4 XnBJ9HPqcNYCZ18SLE4L7ue52BIsJSA7Jmqh75PH2YRbJkPH4u40/i3X+zdTzQAmVLy8 4rnrInj9bHkkOH07HzWY7WLKGVzLIdYrdyD94pL9hqGHwWH3+3xp1IBvcpOHD1SMUizx GDk9H8CdBSgTFVaF3lLkZYFc8BAUKFVXUByBAtAsWv4+IuYVxrAasPy7+PODaMyEK7eG /HWkBx9KKeDD4OrBq/7TcUv4dVqcmbHcmthvDsCZOKO1Mt6AdJxAXYNk/KRajVGO6Kzh lK9w== X-Forwarded-Encrypted: i=1; AL+hErE3FkU0fEsMMkDOrky1ecFdONZ6XIeQP9RAmTTk7hFCTN9iYrC99HWNZc3hgwnK8ok6QNIk4kKFjNR9@vger.kernel.org X-Gm-Message-State: APuU4Z/o3ZJe3RJqnyM76FSQ3av3KbLP+YVI89klly+no1124tlUe25N WsJbjGbHCtjRk9aFIiMIKnJOFonoT0KnFyyU23ITAi9pCqgQlLtBck8g8HA1hMo40XA= X-Gm-Gg: AYBFou2zTpLLGZ+bNiaeCJzxZEByt7eXMWBV7lW4UafZLPcHokbxJGFwrxrvPSLwrm/ 1nUF62qZ+TQHFpd+qF0KTvrfV7IwUgobf3GtR9b3fjVvuWV/OB6C+yHABjq47cGDpi66eaGPb7/ TApu0V25L/GkES3Fm8oRYsFIBLEJWZj0DTt7hHfH50iPgWGkZS+2GWSmZNHFdAGrXrwcJ2CF2ro ne3GfdgfgySu2Rv5DX2J4CR2PfXedzXrhrCt5+gxsVyzXPyTVz086FoIXSSp98iJq/g7Z9E+570 dWqsxzKMBIAMtK4uylFZ1lZ741BaGn2OpfinsUxHxRTRMx+WBMYcIbvtPO3s/7DVZYQ3qaV7EPe FaK8AOPChiSLYUMPpBN1psgjXU63A2XqpaxeM3NpUd2uWSY+SPsGY49gBVPn8UgVeuVLzsJ++Ip NaA0PVjrmVNH3kbXaH9GGwAZa55OBXTVcmOwxulTvlUASMz4eNAjJDU/IFFcLfXkgPw1RHxLTzI xLXFOz5dlgXTT/McH/zfdh8FmpyITwbDBfHQFCxEm+zQ/B47xjEPKFAkngx0HTZv7LSeaIX9lsR pvT4Hp9qydzzmPM1UKEWWQvyuALq481dfA53NcXI9i8= X-Received: by 2002:a05:600c:8b0a:b0:4a1:da58:1ee with SMTP id 5b1f17b1804b1-4bb55a95dbamr161321305e9.31.1794744970969; Sun, 15 Nov 2026 04:16:10 -0800 (PST) Received: from [192.168.0.167] ([78.152.238.245]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb65ce005bsm126726035e9.14.2026.11.15.04.16.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Nov 2026 04:16:10 -0800 (PST) Message-ID: Date: Sun, 15 Nov 2026 12:16:06 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 10/23] media: qcom: camss: csid: Add support for CSID 980 To: Wenmeng Liu , Bryan O'Donoghue , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Hangxiang Ma , Robert Foss , Andi Shyti , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Frank Li Cc: linux-phy@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Atiya Kailany References: <20261114-add-support-for-camss-on-sm8750-v7-0-8ff2a11835f6@oss.qualcomm.com> <20261114-add-support-for-camss-on-sm8750-v7-10-8ff2a11835f6@oss.qualcomm.com> <130fecb6-5372-44d9-8261-c3ac88248631@linaro.org> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <130fecb6-5372-44d9-8261-c3ac88248631@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/11/2026 12:14, Bryan O'Donoghue wrote: > On 14/11/2026 11:29, Wenmeng Liu wrote: >> +            for (k = 0; k < CAMSS_INIT_BUF_COUNT; k++) { >> +                __csid_addr_update(csid, i); >> +                __csid_reg_update(csid, i); >> +            } > > Why does this run twice for the same index ? > > --- > bod "run CAMSS_INIT_BUF_COUNT" for the same index ? You don't increment a buffer index. How can this be logical ? --- bod From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0265606A31A for ; Sun, 15 Nov 2026 12:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=D8YO+Slj; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=LmJV4DVp DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=i0mPtiMQUv1vnhlAF63rXtbmujDLs1ukRJpnOl7v0JU=; b=D8YO+SljH2s1Lnwed1/AblRxz5 QGcAjWtdP1Vm0qbO5Rj/Tdv84mb2YXH8yPDAA4HmnY/XRYOMo4/r7G0cxSG3DGIObZctJSGMhv3+R Ztre/uBN9/rzDZGge28bgkouy3P9tXX3AQJ5QuNBxQ9l94Bdms7uw5Ile7TcX1UHz54yMHEoITdTt kvQLs0fRUZpex/YTu9unNWBFHITLbATFaKBHOOCQf4KPXlu6ID+okWktUvfFBB9cBx/DM02FVngJx 4sHWFWTG7PqbV3we6yuPiI5IoZUT02HNPmHALsAHO1LcQ91dZ6WH6YXNDIFgiZlHjvG1h6hPMDco+ C5bVg2Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSZ9d-0000000HVE6-1nUT; Sun, 15 Nov 2026 12:16:17 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xSZ9Z-0000000HVDg-0sEP for linux-phy@lists.infradead.org; Sun, 15 Nov 2026 12:16:16 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4a1fbd52ab6so20764595e9.0 for ; Sun, 15 Nov 2026 04:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1794744971; x=1795349771; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Cze6EXMazudJouVIRWBezoVb+gMXv48f+e410Dy7G9s=; b=LmJV4DVpqv6udjEtwrVs9LWPNFwcseRhq1fL1wFFvJzppSI1WRbZ9CdyRh4TxhjzF8 iGNZG/SWtCfix2AP34DpgVdG6p7KuobdP8c1s11V6idLrJHnu1xEm5jjQlOMxOF0Jj9Z T7/qH2X2nx9Zy4axF0kLrB2kox++PX0ocenJ9lELGY3riIs7uWb4h3A6xK3EINcPS22O r27OhAdNdMzolb+ZRcEUQIiBzfV/EqeFLrfikt1uXiFWnoioTXmpBFbNKtzFNekJ7HF1 hE53X1X7gitbRFe0JoGB28mUDPHzZOG6BdYLmYtZTh7fIZ+GYyt0EJ7SS1/JF6F/IS8Q yvmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794744971; x=1795349771; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Cze6EXMazudJouVIRWBezoVb+gMXv48f+e410Dy7G9s=; b=x1KDMWGqKxnQqEiNgLzJz3ujVoYbG/jjkOzR2nD68CGljJ3uJFoJCrGgQI2gp9NjkI 6Nn2fwc0gqIjr2Q7yL25cUfGS5GXmWdnXt3cOsw+8T16BWPzgUQ7ahWMRC2c5eZs87dt MKvFxaDyPGB65o7muHairJ3AhRvTbkOjHEFeeJADhGXOp9vV4FZfQq3E1IKSH5FSGEOk XUdmW/8kE6GFSpgXb6l68q/CsD+alSb6E1W2ogz6hAiMSVQ+8BfyHnBgGen8PS2m0yTH t5iqcpf3Plt06bvImZi4iVpEHDIaDNdeT7Hho6MPGGkQF/I60sGNlrSZPs7hqeapogDL IIKg== X-Gm-Message-State: APuU4Z/fgGxnRnT931NYbEzFrT35p744nwBnOEEhzM4Op2/5uO/5YqAW idOSPI/KTj+MBl08MsMlV52RuANM0slFQx+6U64ZeDDQ9tuvmNoLWjeJnjLfbflr7jY= X-Gm-Gg: AYBFou140kjHsvorUQaMIHdfpKvASuzZFFqtWdphgszAhU/Jh7XY9tkBmjojYxJ3JBL V+11x5z1nK0NOJhcOlaMLXhuoT6zGtKu+2HaI4vheVpNKAJ3R45itl64sUPVOWPqTVW0hG5veJC r+vH3d74KoPskxpcorWD8GoHy97VhLTpbRC3ZHYLwImm2994yzEeGQBvh2c+JhVeL0MDJWl7Uso MWd23rbp70jGz31mRmdPlC59NQK8xkoTadmPw6IiUlq4T+BGfJOepZCIlJEmXYzq7Ds3tsCG927 iMQzoyriZsYdzT564pwYPQ/fSNw1dqXRUmyDYyDEXccF7eombiHSO+mBDs0J+M/uInEOP0Tv05J fID5MDoexRxKDdv0Zw46W6hVl1vZLZlgS60YEV536cfiR5MGEvfuVCmMerwuLgxRKeOSygfZoi1 YGSpbNwyLilnr6rF3aoGU7XCrJpTWf81WS29fGHxgHzxj8O9CMwUNT9sLs3hUBSb/JlnjSHwNPB mLBD5W94QEctQAWpj+v5g3sDIiknj6shlYWCvJQ8eXl1FBGen5eG6wpIa9NFi/NOl8+pTzrbM3b py+n96LAU7DIvJZUQ9QJUKqHRCaQLOs0SJw34I2zatI= X-Received: by 2002:a05:600c:8b0a:b0:4a1:da58:1ee with SMTP id 5b1f17b1804b1-4bb55a95dbamr161321305e9.31.1794744970969; Sun, 15 Nov 2026 04:16:10 -0800 (PST) Received: from [192.168.0.167] ([78.152.238.245]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb65ce005bsm126726035e9.14.2026.11.15.04.16.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Nov 2026 04:16:10 -0800 (PST) Message-ID: Date: Sun, 15 Nov 2026 12:16:06 +0000 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 10/23] media: qcom: camss: csid: Add support for CSID 980 To: Wenmeng Liu , Bryan O'Donoghue , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vladimir Zapolskiy , Loic Poulain , Mauro Carvalho Chehab , Hangxiang Ma , Robert Foss , Andi Shyti , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Frank Li Cc: linux-phy@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, Atiya Kailany References: <20261114-add-support-for-camss-on-sm8750-v7-0-8ff2a11835f6@oss.qualcomm.com> <20261114-add-support-for-camss-on-sm8750-v7-10-8ff2a11835f6@oss.qualcomm.com> <130fecb6-5372-44d9-8261-c3ac88248631@linaro.org> From: Bryan O'Donoghue Content-Language: en-GB In-Reply-To: <130fecb6-5372-44d9-8261-c3ac88248631@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261115_041614_907773_865C75CA X-CRM114-Status: UNSURE ( 7.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-phy" X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 T24gMTUvMTEvMjAyNiAxMjoxNCwgQnJ5YW4gTydEb25vZ2h1ZSB3cm90ZToKPiBPbiAxNC8xMS8y MDI2IDExOjI5LCBXZW5tZW5nIExpdSB3cm90ZToKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAg Zm9yIChrID0gMDsgayA8IENBTVNTX0lOSVRfQlVGX0NPVU5UOyBrKyspIHsKPj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBfX2NzaWRfYWRkcl91cGRhdGUoY3NpZCwgaSk7Cj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgX19jc2lkX3JlZ191cGRhdGUoY3NpZCwgaSk7 Cj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH0KPiAKPiBXaHkgZG9lcyB0aGlzIHJ1biB0d2lj ZSBmb3IgdGhlIHNhbWUgaW5kZXggPwo+IAo+IC0tLQo+IGJvZAoKInJ1biBDQU1TU19JTklUX0JV Rl9DT1VOVCIgZm9yIHRoZSBzYW1lIGluZGV4ID8KCllvdSBkb24ndCBpbmNyZW1lbnQgYSBidWZm ZXIgaW5kZXguIEhvdyBjYW4gdGhpcyBiZSBsb2dpY2FsID8KCi0tLQpib2QKCi0tIApsaW51eC1w aHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=