All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Ninad Palsule <ninad@linux.ibm.com>,
	linux-fsi@lists.ozlabs.org, Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/13] spi: fsi: Drop assigning fsi bus
Date: Tue, 27 Jan 2026 09:26:27 -0600	[thread overview]
Message-ID: <ea339dbc-e75a-4792-8d39-c28b3cb6d0c9@linux.ibm.com> (raw)
In-Reply-To: <279e26a6740f10d119be7ea01d4af596309b3bb4.1765279318.git.u.kleine-koenig@baylibre.com>


On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> Since commit FIXME ("fsi: Assign driver's bus in fsi_driver_register()")
> module_fsi_driver() cares about assigning the driver's bus member. Drop
> the explicit driver specific assignment.


Acked-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Acked-by: Mark Brown <broonie@kernel.org>
> ---
>   drivers/spi/spi-fsi.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c
> index e01c63d23b64..f9c15b99dba5 100644
> --- a/drivers/spi/spi-fsi.c
> +++ b/drivers/spi/spi-fsi.c
> @@ -595,7 +595,6 @@ static struct fsi_driver fsi_spi_driver = {
>   	.id_table = fsi_spi_ids,
>   	.drv = {
>   		.name = "spi-fsi",
> -		.bus = &fsi_bus_type,
>   		.probe = fsi_spi_probe,
>   	},
>   };

  reply	other threads:[~2026-01-27 15:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 11:39 [PATCH v2 00/13] fsi: Convert to bus probe mechanism Uwe Kleine-König
2025-12-09 11:40 ` [PATCH v2 01/13] fsi: Make use of module_fsi_driver() Uwe Kleine-König
2026-01-27 15:25   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 02/13] fsi: Assign driver's bus in fsi_driver_register() Uwe Kleine-König
2026-01-27 15:25   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 03/13] fsi: Provide thin wrappers around dev_[gs]et_data() for fsi devices Uwe Kleine-König
2026-01-27 15:25   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 04/13] i2c: fsi: Drop assigning fsi bus Uwe Kleine-König
2026-01-27 15:26   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 05/13] spi: " Uwe Kleine-König
2026-01-27 15:26   ` Eddie James [this message]
2025-12-09 11:40 ` [PATCH v2 06/13] fsi: Make fsi_bus_type a private variable to the core Uwe Kleine-König
2026-01-27 15:26   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 07/13] fsi: Create bus specific probe and remove functions Uwe Kleine-König
2026-01-27 15:27   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 08/13] fsi: i2cr-scom: Convert to fsi bus probe mechanism Uwe Kleine-König
2026-01-27 15:27   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 09/13] fsi: master: " Uwe Kleine-König
2026-01-27 15:27   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 10/13] fsi: sbefifo: " Uwe Kleine-König
2026-01-27 15:28   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 11/13] fsi: scom: " Uwe Kleine-König
2026-01-27 15:28   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 12/13] i2c: fsi: " Uwe Kleine-König
2026-01-27 15:29   ` Eddie James
2025-12-09 11:40 ` [PATCH v2 13/13] spi: " Uwe Kleine-König
2026-01-27 15:29   ` Eddie James
2026-01-12  9:47 ` [PATCH v2 00/13] fsi: Convert to " Uwe Kleine-König
2026-01-27 15:31   ` Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea339dbc-e75a-4792-8d39-c28b3cb6d0c9@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=broonie@kernel.org \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=ninad@linux.ibm.com \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.