From: David Ahern <dsahern@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, corbet@lwn.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, roopa@nvidia.com,
daniel@iogearbox.net, vladimir.oltean@nxp.com, idosch@nvidia.com,
nikolay@nvidia.com, yajun.deng@linux.dev, zhutong@amazon.com,
johannes@sipsolutions.net, jouni@codeaurora.org
Subject: Re: [RESEND PATCH v7 3/3] selftests: net: add arp_ndisc_evict_nocarrier
Date: Tue, 26 Oct 2021 08:57:11 -0600 [thread overview]
Message-ID: <ea4d34ea-6393-97c9-5484-f703a4f5cea6@gmail.com> (raw)
In-Reply-To: <20211025164547.1097091-4-prestwoj@gmail.com>
On 10/25/21 10:45 AM, James Prestwood wrote:
> This tests the sysctl options for ARP/ND:
>
> /net/ipv4/conf/<iface>/arp_evict_nocarrier
> /net/ipv6/conf/<iface>/ndisc_evict_nocarrier
>
> Signed-off-by: James Prestwood <prestwoj@gmail.com>
> ---
> .../net/arp_ndisc_evict_nocarrier.sh | 181 ++++++++++++++++++
> 1 file changed, 181 insertions(+)
> create mode 100755 tools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh
>
Thanks for adding the selftests.
The tests should include a set with the 'all' setting as well -- off and
on works as expected. If you have to do another version, you can add it
then. If this version gets committed, please send a followup patch with
those tests.
Reviewed-by: David Ahern <dsahern@kernel.org>
prev parent reply other threads:[~2021-10-26 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 16:45 [RESEND PATCH v7 0/3] Make neighbor eviction controllable by userspace James Prestwood
2021-10-25 16:45 ` [RESEND PATCH v7 1/3] net: arp: introduce arp_evict_nocarrier sysctl parameter James Prestwood
2021-10-26 14:50 ` David Ahern
2021-10-25 16:45 ` [RESEND PATCH v7 2/3] net: ndisc: introduce ndisc_evict_nocarrier " James Prestwood
2021-10-26 14:52 ` David Ahern
2021-10-25 16:45 ` [RESEND PATCH v7 3/3] selftests: net: add arp_ndisc_evict_nocarrier James Prestwood
2021-10-26 14:57 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea4d34ea-6393-97c9-5484-f703a4f5cea6@gmail.com \
--to=dsahern@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=johannes@sipsolutions.net \
--cc=jouni@codeaurora.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=prestwoj@gmail.com \
--cc=roopa@nvidia.com \
--cc=vladimir.oltean@nxp.com \
--cc=yajun.deng@linux.dev \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhutong@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.