From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/2] drm/i915: Remove variable length arrays from sseu debugfs printers Date: Tue, 13 Mar 2018 09:35:03 +0000 Message-ID: References: <20180313004055.25411-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB89D6E3EA for ; Tue, 13 Mar 2018 09:35:05 +0000 (UTC) In-Reply-To: <20180313004055.25411-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Matthew Auld List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEzLzAzLzIwMTggMDA6NDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiBvcmRlciB0byBl bmFibGUgLVd2bGEgdG8gcHJldmVudCBuZXcgdmFyaWFibGUgbGVuZ3RoIGFycmF5cyBiZWluZwo+ IHVzZWQgaW4gaTkxNS5rbywgd2UgZmlyc3QgbXVzdCByZW1vdmUgdGhlIGV4aXN0aW5nIFZMQS4g SW5zaWRlCj4gaTkxNV9wcmludF9zc2V1X2luZm8oKSwgVkxBIGFyZSB1c2VkIGFzIHRoZSBhY3R1 YWwgc2l6ZSBvZiB0aGUgc3NldQo+IGRlcGVuZHMgb24gcGxhdGZvcm0uIFJlcGxhY2UgdGhlIFZM QSB3aXRoIHRoZSBtYXhpbXVtIHJlcXVpcmVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBMaW9uZWwgTGFuZHdlcmxpbiA8 bGlvbmVsLmcubGFuZHdlcmxpbkBpbnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gQ2M6IE1hdHRoZXcgQXVsZCA8bWF0dGhldy5hdWxkQGlu dGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIHwg MTIgKysrKysrLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggYzRj YzhmZWYxMWEwLi4wZWFjN2RjZGRkYmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVn ZnMuYwo+IEBAIC00MzEyLDkgKzQzMTIsMTAgQEAgREVGSU5FX1NJTVBMRV9BVFRSSUJVVEUoaTkx NV9jYWNoZV9zaGFyaW5nX2ZvcHMsCj4gICBzdGF0aWMgdm9pZCBjaGVycnl2aWV3X3NzZXVfZGV2 aWNlX3N0YXR1cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJCQkJCSAg c3RydWN0IHNzZXVfZGV2X2luZm8gKnNzZXUpCj4gICB7Cj4gLQlpbnQgc3NfbWF4ID0gMjsKPiAr I2RlZmluZSBTU19NQVggMgo+ICsJY29uc3QgaW50IHNzX21heCA9IFNTX01BWDsKPiArCXUzMiBz aWcxW1NTX01BWF0sIHNpZzJbU1NfTUFYXTsKPiAgIAlpbnQgc3M7Cj4gLQl1MzIgc2lnMVtzc19t YXhdLCBzaWcyW3NzX21heF07CgpFdmVuIGNvbnN0LCBzaWdoLgoKPiAgIAo+ICAgCXNpZzFbMF0g PSBJOTE1X1JFQUQoQ0hWX1BPV0VSX1NTMF9TSUcxKTsKPiAgIAlzaWcxWzFdID0gSTkxNV9SRUFE KENIVl9QT1dFUl9TUzFfU0lHMSk7Cj4gQEAgLTQzMzgsMTUgKzQzMzksMTUgQEAgc3RhdGljIHZv aWQgY2hlcnJ5dmlld19zc2V1X2RldmljZV9zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ICAgCQlzc2V1LT5ldV9wZXJfc3Vic2xpY2UgPSBtYXhfdCh1bnNpZ25lZCBp bnQsCj4gICAJCQkJCSAgICAgIHNzZXUtPmV1X3Blcl9zdWJzbGljZSwgZXVfY250KTsKPiAgIAl9 Cj4gKyN1bmRlZiBTU19NQVgKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQgZ2VuMTBfc3NldV9k ZXZpY2Vfc3RhdHVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAkJCQkg ICAgIHN0cnVjdCBzc2V1X2Rldl9pbmZvICpzc2V1KQo+ICAgewo+ICAgCWNvbnN0IHN0cnVjdCBp bnRlbF9kZXZpY2VfaW5mbyAqaW5mbyA9IElOVEVMX0lORk8oZGV2X3ByaXYpOwo+ICsJdTMyIHNf cmVnWzZdLCBldV9yZWdbMiAqIDRdLCBldV9tYXNrWzJdOwoKRm9yIGZ1dHVyZSBpbXByb3ZlbWVu dCBJIHRoaW5rIHB1bGxpbmcgb3V0IDYgYW5kIDQgdG8gc29tZXRoaW5nIGxpa2UgCkdFTjEwX01B WF9TTElDRVMgYW5kIEdFTjEwX01BWF9TVUJTTElDRVMgd291bGQgYmUgZ29vZC4gSnVzdCBzbyBu dW1iZXJzIAphcmUgY2VudHJhbGl6ZWQgYW5kIHdlIHJlbW92ZSBhbnkgcG9zc2liaWxpdHkgb2Yg d2Fsa2luZyBvdXQgb2YgYm91bmRzLiAKQWN0dWFsbHkgZm9yIGFsbCBvZiB0aGUgaW1wYWN0ZWQg cGxhdGZvcm1zLgoKPiAgIAlpbnQgcywgc3M7Cj4gLQl1MzIgc19yZWdbaW5mby0+c3NldS5tYXhf c2xpY2VzXTsKPiAtCXUzMiBldV9yZWdbMiAqIGluZm8tPnNzZXUubWF4X3N1YnNsaWNlc10sIGV1 X21hc2tbMl07Cj4gICAKPiAgIAlmb3IgKHMgPSAwOyBzIDwgaW5mby0+c3NldS5tYXhfc2xpY2Vz OyBzKyspIHsKPiAgIAkJLyoKPiBAQCAtNDM5OSw5ICs0NDAwLDggQEAgc3RhdGljIHZvaWQgZ2Vu OV9zc2V1X2RldmljZV9zdGF0dXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICAgCQkJCSAgICBzdHJ1Y3Qgc3NldV9kZXZfaW5mbyAqc3NldSkKPiAgIHsKPiAgIAljb25zdCBz dHJ1Y3QgaW50ZWxfZGV2aWNlX2luZm8gKmluZm8gPSBJTlRFTF9JTkZPKGRldl9wcml2KTsKPiAr CXUzMiBzX3JlZ1szXSwgZXVfcmVnWzIgKiA0XSwgZXVfbWFza1syXTsKPiAgIAlpbnQgcywgc3M7 Cj4gLQl1MzIgc19yZWdbaW5mby0+c3NldS5tYXhfc2xpY2VzXTsKPiAtCXUzMiBldV9yZWdbMiAq IGluZm8tPnNzZXUubWF4X3N1YnNsaWNlc10sIGV1X21hc2tbMl07Cj4gICAKPiAgIAlmb3IgKHMg PSAwOyBzIDwgaW5mby0+c3NldS5tYXhfc2xpY2VzOyBzKyspIHsKPiAgIAkJc19yZWdbc10gPSBJ OTE1X1JFQUQoR0VOOV9TTElDRV9QR0NUTF9BQ0socykpOwo+IAoKTWF4aW11bXMgYXJlIGNvcnJl Y3Qgc28gZm9yIG5vdyBpdCBpcyB3b3JrYWJsZToKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxp biA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK