From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E42852772A for ; Wed, 12 Jun 2024 08:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718179952; cv=none; b=B/lwLnw+SLU3iDvuaAL5KYgmi4kL2UQqYv7S46r5KBfArvqbj8hcoLK8pyktn6fA831hLqVx1pq0P1YcEQFylRXuLeT/Igdvq9Isqi7l4SQnk6xjBGDBjjGH/fQEr5uGpBrtDpG3vC3ploWBSCaY4w0J9/96bTFWJNE3AYoFiRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718179952; c=relaxed/simple; bh=rLJunDbeQeAUOd1JejIPRVqX35zvCbzWB9CqhTOod/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vDECe7T+TdOtYL0WcoQthltxcFNkt6TfV+SeSsX65z9t/ELftMk9+3td6bZU/mFyf5uVAKLPNE4M1KB7X+gOsXoSZBXOsrhHewOEfEs6YQRgX8zmlCH3qAiZ2EBJsugfcwlVHKLoplJ9BTLlEvAp5x0PbqwLH3hTrHCOM5VNJNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=q0RWbMR9; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="q0RWbMR9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1718179949; bh=rLJunDbeQeAUOd1JejIPRVqX35zvCbzWB9CqhTOod/w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=q0RWbMR9uA0R0gEmNo/Y42AKdEY0c8S2LtxkiNObYUUoOkwdu26EjDos8f9ExotJ1 pv7VbPZZDqiBgjCuO3kHA3+PdUXqj1G1N0dIGS2D5UyRZgvm0AyOsUIwLLbX6s7xjx 7vusY0GZrdJdkzFMks1JOJ83fMKjFYUwCiZ4VWPOiWs1r2S3tu/gyN6itwc7U9ksDK Pm+02wXMtSckWKMOUuD/K1ZquWNrilL7dr7UzW2Nbl3ldSAshzuzyJknCp4TiNfZVW clvAMte8TGX23djR8BpQ9hpyiAALcGMkdHtywsbf6SpRT4To25jen3L0Gvepm5aKXo 8zRzswiHzBYgQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id EC54D37820A9; Wed, 12 Jun 2024 08:12:27 +0000 (UTC) Message-ID: Date: Wed, 12 Jun 2024 10:12:27 +0200 Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: add missing MODULE_DESCRIPTION() macros To: neil.armstrong@linaro.org, Jeff Johnson , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Imre Kaloz , Matthias Brugger , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org References: <20240611-md-drivers-soc-v1-1-8f0fc9fff234@quicinc.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 12/06/24 09:58, Neil Armstrong ha scritto: > On 12/06/2024 07:50, Jeff Johnson wrote: >> With ARCH=x86, make allmodconfig && make W=1 C=1 reports: >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/imx/soc-imx8m.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-qmgr.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/soc/ixp4xx/ixp4xx-npe.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in >> drivers/soc/mediatek/mtk-cmdq-helper.o >> WARNING: modpost: missing MODULE_DESCRIPTION() in >> drivers/soc/amlogic/meson-clk-measure.o >> >> Add the missing invocations of the MODULE_DESCRIPTION() macro. >> >> Signed-off-by: Jeff Johnson >> --- >> This is the last of the issues that I see in the soc directory >> --- >>   drivers/soc/amlogic/meson-clk-measure.c | 1 + > > Reviewed-by: Neil Armstrong # for > amlogic/meson-clk-measure.c > >>   drivers/soc/imx/soc-imx8m.c             | 1 + >>   drivers/soc/ixp4xx/ixp4xx-npe.c         | 1 + >>   drivers/soc/ixp4xx/ixp4xx-qmgr.c        | 1 + >>   drivers/soc/mediatek/mtk-cmdq-helper.c  | 1 + >>   5 files changed, 5 insertions(+) >> MediaTek: Reviewed-by: AngeloGioacchino Del Regno ...but I'm not sure how we should apply this? :-) Either Arnd takes it directly, or you split it per-soc... and I don't have any preference anyway. (P.S.: Added Arnd to the loop) Cheers, Angelo >> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c >> b/drivers/soc/mediatek/mtk-cmdq-helper.c >> index 046522664dc1..dd70d4d2bed7 100644 >> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c >> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c >> @@ -526,4 +526,5 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt) >>   } >>   EXPORT_SYMBOL(cmdq_pkt_finalize); >> +MODULE_DESCRIPTION("MediaTek Command Queue (CMDQ) driver"); >>   MODULE_LICENSE("GPL v2"); >> >> --- >> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 >> change-id: 20240611-md-drivers-soc-1780b1939627 >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4B6EC27C75 for ; Wed, 12 Jun 2024 08:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mrVBGNfqfVtitLjDX0pGkzLpXzWscjV4NSKualLC9aM=; b=m3YdAXD9O/K96R S3UtgX8snTdxNxyDd/v0GIkqhv1C2DZwAvy7QLZEUuJGTXHMIHCM1GdmkaZ8RpWmsPm5QkKDwgEKU GDkKHcF9fnrf6w7/bXUutl54D4KWK7GpX5IIeI2QNMk5A36bEAWQJfe5yFFlkgfrf8EbashXNtIgO 8Y4W6mXVa3rGsF1CphNNGyXjO+K3HYAywyWsIZo7Q+IaBqsmyOr6O2NKIhaeqDn379dEn2bYRY4sz podv8Yet04YiQq3J5jWKf37h1E2Bo1d4/LUktsRsE3Nvq+IONB7WaA2otW4z4DFENXGwkXBnOxJzU Q3VrIqWq8DAiCY4zApgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHJ5t-0000000Bdj0-2uu1; Wed, 12 Jun 2024 08:12:33 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHJ5q-0000000Bdhn-3rEH; Wed, 12 Jun 2024 08:12:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1718179949; bh=rLJunDbeQeAUOd1JejIPRVqX35zvCbzWB9CqhTOod/w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=q0RWbMR9uA0R0gEmNo/Y42AKdEY0c8S2LtxkiNObYUUoOkwdu26EjDos8f9ExotJ1 pv7VbPZZDqiBgjCuO3kHA3+PdUXqj1G1N0dIGS2D5UyRZgvm0AyOsUIwLLbX6s7xjx 7vusY0GZrdJdkzFMks1JOJ83fMKjFYUwCiZ4VWPOiWs1r2S3tu/gyN6itwc7U9ksDK Pm+02wXMtSckWKMOUuD/K1ZquWNrilL7dr7UzW2Nbl3ldSAshzuzyJknCp4TiNfZVW clvAMte8TGX23djR8BpQ9hpyiAALcGMkdHtywsbf6SpRT4To25jen3L0Gvepm5aKXo 8zRzswiHzBYgQ== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id EC54D37820A9; Wed, 12 Jun 2024 08:12:27 +0000 (UTC) Message-ID: Date: Wed, 12 Jun 2024 10:12:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: add missing MODULE_DESCRIPTION() macros To: neil.armstrong@linaro.org, Jeff Johnson , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Linus Walleij , Imre Kaloz , Matthias Brugger , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org References: <20240611-md-drivers-soc-v1-1-8f0fc9fff234@quicinc.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240612_011231_111308_2A1A354C X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SWwgMTIvMDYvMjQgMDk6NTgsIE5laWwgQXJtc3Ryb25nIGhhIHNjcml0dG86Cj4gT24gMTIvMDYv MjAyNCAwNzo1MCwgSmVmZiBKb2huc29uIHdyb3RlOgo+PiBXaXRoIEFSQ0g9eDg2LCBtYWtlIGFs bG1vZGNvbmZpZyAmJiBtYWtlIFc9MSBDPTEgcmVwb3J0czoKPj4gV0FSTklORzogbW9kcG9zdDog bWlzc2luZyBNT0RVTEVfREVTQ1JJUFRJT04oKSBpbiBkcml2ZXJzL3NvYy9pbXgvc29jLWlteDht Lm8KPj4gV0FSTklORzogbW9kcG9zdDogbWlzc2luZyBNT0RVTEVfREVTQ1JJUFRJT04oKSBpbiBk cml2ZXJzL3NvYy9peHA0eHgvaXhwNHh4LXFtZ3Iubwo+PiBXQVJOSU5HOiBtb2Rwb3N0OiBtaXNz aW5nIE1PRFVMRV9ERVNDUklQVElPTigpIGluIGRyaXZlcnMvc29jL2l4cDR4eC9peHA0eHgtbnBl Lm8KPj4gV0FSTklORzogbW9kcG9zdDogbWlzc2luZyBNT0RVTEVfREVTQ1JJUFRJT04oKSBpbiAK Pj4gZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEtaGVscGVyLm8KPj4gV0FSTklORzogbW9k cG9zdDogbWlzc2luZyBNT0RVTEVfREVTQ1JJUFRJT04oKSBpbiAKPj4gZHJpdmVycy9zb2MvYW1s b2dpYy9tZXNvbi1jbGstbWVhc3VyZS5vCj4+Cj4+IEFkZCB0aGUgbWlzc2luZyBpbnZvY2F0aW9u cyBvZiB0aGUgTU9EVUxFX0RFU0NSSVBUSU9OKCkgbWFjcm8uCj4+Cj4+IFNpZ25lZC1vZmYtYnk6 IEplZmYgSm9obnNvbiA8cXVpY19qam9obnNvbkBxdWljaW5jLmNvbT4KPj4gLS0tCj4+IFRoaXMg aXMgdGhlIGxhc3Qgb2YgdGhlIGlzc3VlcyB0aGF0IEkgc2VlIGluIHRoZSBzb2MgZGlyZWN0b3J5 Cj4+IC0tLQo+PiDCoCBkcml2ZXJzL3NvYy9hbWxvZ2ljL21lc29uLWNsay1tZWFzdXJlLmMgfCAx ICsKPiAKPiBSZXZpZXdlZC1ieTogTmVpbCBBcm1zdHJvbmcgPG5laWwuYXJtc3Ryb25nQGxpbmFy by5vcmc+ICMgZm9yIAo+IGFtbG9naWMvbWVzb24tY2xrLW1lYXN1cmUuYwo+IAo+PiDCoCBkcml2 ZXJzL3NvYy9pbXgvc29jLWlteDhtLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCAxICsKPj4g wqAgZHJpdmVycy9zb2MvaXhwNHh4L2l4cDR4eC1ucGUuY8KgwqDCoMKgwqDCoMKgwqAgfCAxICsK Pj4gwqAgZHJpdmVycy9zb2MvaXhwNHh4L2l4cDR4eC1xbWdyLmPCoMKgwqDCoMKgwqDCoCB8IDEg Kwo+PiDCoCBkcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstY21kcS1oZWxwZXIuY8KgIHwgMSArCj4+ IMKgIDUgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspCj4+CgpNZWRpYVRlazoKUmV2aWV3 ZWQtYnk6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdlbG9naW9hY2NoaW5vLmRlbHJl Z25vQGNvbGxhYm9yYS5jb20+CgouLi5idXQgSSdtIG5vdCBzdXJlIGhvdyB3ZSBzaG91bGQgYXBw bHkgdGhpcz8gOi0pCgpFaXRoZXIgQXJuZCB0YWtlcyBpdCBkaXJlY3RseSwgb3IgeW91IHNwbGl0 IGl0IHBlci1zb2MuLi4gYW5kIEkgZG9uJ3QgaGF2ZSBhbnkKcHJlZmVyZW5jZSBhbnl3YXkuCgoo UC5TLjogQWRkZWQgQXJuZCB0byB0aGUgbG9vcCkKCkNoZWVycywKQW5nZWxvCgo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEtaGVscGVyLmMgCj4+IGIvZHJpdmVy cy9zb2MvbWVkaWF0ZWsvbXRrLWNtZHEtaGVscGVyLmMKPj4gaW5kZXggMDQ2NTIyNjY0ZGMxLi5k ZDcwZDRkMmJlZDcgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRx LWhlbHBlci5jCj4+ICsrKyBiL2RyaXZlcnMvc29jL21lZGlhdGVrL210ay1jbWRxLWhlbHBlci5j Cj4+IEBAIC01MjYsNCArNTI2LDUgQEAgaW50IGNtZHFfcGt0X2ZpbmFsaXplKHN0cnVjdCBjbWRx X3BrdCAqcGt0KQo+PiDCoCB9Cj4+IMKgIEVYUE9SVF9TWU1CT0woY21kcV9wa3RfZmluYWxpemUp Owo+PiArTU9EVUxFX0RFU0NSSVBUSU9OKCJNZWRpYVRlayBDb21tYW5kIFF1ZXVlIChDTURRKSBk cml2ZXIiKTsKPj4gwqAgTU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOwo+Pgo+PiAtLS0KPj4gYmFz ZS1jb21taXQ6IDgzYTdlZWZlZGM5YjU2ZmU3YmZlZmYxM2I2YzczNTY2ODhmZmE2NzAKPj4gY2hh bmdlLWlkOiAyMDI0MDYxMS1tZC1kcml2ZXJzLXNvYy0xNzgwYjE5Mzk2MjcKPj4KPiAKCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dp YyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=