From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:d7a2:b0:96f:a786:ac5c with SMTP id pk2csp1143308ejb; Mon, 22 May 2023 04:43:52 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6nIK1Bz1tP2h1FJqy+9xbEweRXlCiDxIZKJ16RW+gHnN3373RwOxzTu7JfL3h6KJgbRduJ X-Received: by 2002:ac8:5a44:0:b0:3f5:3cb1:4617 with SMTP id o4-20020ac85a44000000b003f53cb14617mr19279655qta.55.1684755832518; Mon, 22 May 2023 04:43:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684755832; cv=none; d=google.com; s=arc-20160816; b=Xnp4nD1dNDbe9PVE0WbB1K4iUW8lxs+gPLsS/2TneFVT/BlBZgeMQa3a5djeab+FaT pLwqx4BzI/MufhlpJp/P6o6+peoeMU5hrb1THZXKKh9rwxEo6E+lxv4mySXaWWo23gNq Mv57pGsSunFRkIBOetiYm/yrMPcNOuTtL4r7Zz2c4eOxaaz69kgW1l8fqGi96eEkEhkk CWrI/PrZBK7EYmC5oBilotdEHqO+iXPNit/5/LYM1DPlW1dflBtop8RZiq8iK62MypJs 7FRm+Fh1H0eV3mKa3wxER8K2yvpsX+J5Yg13gJGdHUVrATmMOOdxoPAmQhBxvnnXYIjd v7Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=NJ4Odc7Qpd/89K+0N1IvNLPdIG5T1t2K+H1G00xOids=; b=ojU2aqaMvlJkoBkwIGqkS1ZyjS5+ZeIstTfo5ViHAy+xS+VIqpikuVhUHbTZ0mPECP qk2hnGnMz6BJRd6bR839uxr+cAiqG3+odwIlGfIXDhrynzj0G+rLwe1T2Vr8aZ6eVhaY JDPb4ivOqPbYepEExz9/2GosOhdIKA5DpK+RVr+VCRqwbwCtmRJjMIPt0t+eyXRum/6j Dzp1WQGjMw5CfCELPLNHN2sguBZbHC4l8X2E0SnbhmgX/Zvo8Zk7uTw68+IKhuUa2NBm c8y3IoDznCjKTzGlRfB/O1B+doA9FOuli+xhLV3eo1+FufNOn5OtX+2q/GOrSx2CiZzB hAHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 7-20020ac85907000000b003f4e1ef2a71si3580830qty.311.2023.05.22.04.43.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 May 2023 04:43:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q13wJ-00020D-St; Mon, 22 May 2023 07:43:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q13wB-0001vr-M9; Mon, 22 May 2023 07:42:51 -0400 Received: from hq-ms.auriga.com ([82.97.202.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q13w7-0006IK-UO; Mon, 22 May 2023 07:42:51 -0400 Received: from HQ-MS1.office.auriga.msk (82.97.202.32) by hq-ms1.office.auriga.msk (82.97.202.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Mon, 22 May 2023 14:42:38 +0300 Received: from HQ-MS1.office.auriga.msk ([fe80::e2f8:5f63:adc1:868f]) by hq-ms1.office.auriga.msk ([fe80::e2f8:5f63:adc1:868f%8]) with mapi id 15.02.1258.012; Mon, 22 May 2023 14:42:38 +0300 From: "Kambalin, Sergey" To: Peter Maydell CC: Sergey Kambalin , "qemu-arm@nongnu.org" , "qemu-devel@nongnu.org" Subject: Re: [PATCH] [rpi4b] Make bootable rpi4b model Thread-Topic: [PATCH] [rpi4b] Make bootable rpi4b model Thread-Index: AQHZjJhM5s2DGZMhDE6fRKCxSTEX869l5goAgAA0A2T//9M1AIAAPGd6 Date: Mon, 22 May 2023 11:42:38 +0000 Message-ID: References: <20230522102910.20942-1-sergey.kambalin@auriga.com> , In-Reply-To: Accept-Language: ru-RU, en-US Content-Language: ru-RU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [134.191.220.81] x-tm-as-product-ver: SMEX-14.0.0.1158-9.0.1002-27556.003 x-tm-as-result: No-10--29.410400-8.000000 x-tmase-matchedrid: f7d9QjltLkuJVA+ukO+5MWg4D2QV/2zL6r3HCixfuKcc4ri4RJV/1W/R DAZTdSI3QnEYvg6//klFmXhQ6rgRVOyDy8V8lTWUzH6d90mb4+Ih6cl1707zKlZxVB3B2qbP6Xk ezPna397QLE3MitZAfl9/IWsrV5Ek1LFdtmiebE5itzfafzhYerzutTz14s8peZ45ULYLKJMB4t FAs1LiqKbazUqKf095QHwb4GFGMWqwHb9D99XpM9KDcT1f9CjEOhJ9m53n4aA/gf7afIrQU0KJP vbg1+THq8syqK88+Oj0SV7CRnVQRDaJvaAUj5ff/zHKAEIZbPT3Oai+medFbKlOQjQcrzOl1jOm H0YwN7FfS6EHW1V5249qGjx05GjjCitK9hvVVO6L3n8qdYJTdLJOtZXi/DJfQMz2FEg88Uw5alk sbtYDT+FEXphl+zRVqSYo2QUmF2SKfuVnTjAwoCQLXCPUFARrArRmBtM54pSBY1QWUF/Dy73mJh WCLMZXg9avwqX0+EqFClSci0DxS6QDcVsPeXcT+LfLuKfgdODId1+nCKlIfjssXelfet1UuPFrk RUFXWrnzlXMYw4XMN9pjzubZ2rHiWXjuZDn7Ih8fd+s731C3K7CTwYFtAqQNv/T5PQJMwbYlBey 042WUw== x-tm-as-user-approved-sender: No x-tm-as-user-blocked-sender: No x-tmase-result: 10--29.410400-8.000000 x-tmase-version: SMEX-14.0.0.1158-9.0.1002-27556.003 x-tm-snts-smtp: A4B8BEF68E5E64374B62D2C6791F5537E5A6E1B8ECD551028C96BB08B8671AFC2000:8 Content-Type: multipart/alternative; boundary="_000_ea63d09bb2d249b282a429ff9d373e4daurigacom_" MIME-Version: 1.0 Received-SPF: pass client-ip=82.97.202.32; envelope-from=sergey.kambalin@auriga.com; helo=hq-ms.auriga.com X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, MIME_CHARSET_FARAWAY=2.45, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: YpLNTVe9HSnl --_000_ea63d09bb2d249b282a429ff9d373e4daurigacom_ Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable Aw, I thought the entire machine should work at the first patch. Thank you for the detailed clarification! I think I've got the idea. I'll s= plit it up. Could you please tell me what size is appropriate for a single patch? ________________________________ =EF=D4: Peter Maydell =EF=D4=D0=D2=C1=D7=CC=C5=CE=CF: 22 =CD=C1=D1 2023 =C7. 13:58:42 =EB=CF=CD=D5: Kambalin, Sergey =EB=CF=D0=C9=D1: Sergey Kambalin; qemu-arm@nongnu.org; qemu-devel@nongnu.or= g =F4=C5=CD=C1: Re: [PATCH] [rpi4b] Make bootable rpi4b model On Mon, 22 May 2023 at 11:42, Kambalin, Sergey wrote: > > Hi! > > Unfortunately it can't be split without losing a functionality. It is a m= inimal amount of code to make it able to boot the kernel (and therefore con= firm that it works). No, it absolutely can. Each individual patch should be a coherent chunk of work, and needs to compile cleanly, but it doesn't have to be immediately useful on its own. The usual setup is that a patchseries adding a new board gradually adds pieces like new devices or bugfixes to existing code, and it's only in a patch fairly late in the series that the new board proper is added and enabled. In a 5 minute scan of this patch I saw at least one cleanup patch that should be separate (changing hard-coded numbers in the switch cases in the bcm2835_property.c file). Anything where you're touching the existing bcm2835/2836 code because you need to refactor it to be a better base for the bcm2838 work should be a separate patch (this is particularly important so we can review that the changes don't break the existing boards). And the usual approach with a new board is that you have a patch per new device being added (you have several here) and then a patch at the end for the board changes. New test cases can be their own patch. Documentation (which seems to be missing here) can be its own patch. I would estimate that this will end up being at least 6 patches, probably more. thanks -- PMM --_000_ea63d09bb2d249b282a429ff9d373e4daurigacom_ Content-Type: text/html; charset="koi8-r" Content-Transfer-Encoding: quoted-printable

Aw, I thought the entire machine should work at the first patch.

Thank you for the detailed clarification!= I think I've got the idea. I'll split it up.

Could you please tell me what size i= s appropriate for a single patch? 

=EF=D4: Peter Maydell <= ;peter.maydell@linaro.org>
=EF=D4=D0=D2=C1=D7=CC=C5=CE=CF: 22 =CD=C1=D1 2023 =C7. 13:58:42
=EB=CF=CD=D5: Kambalin, Sergey
=EB=CF=D0=C9=D1: Sergey Kambalin; qemu-arm@nongnu.org; qemu-devel@no= ngnu.org
=F4=C5=CD=C1: Re: [PATCH] [rpi4b] Make bootable rpi4b model
 
On Mon, 22 May 2023 at 11:42, Kambalin, Sergey
<sergey.kambalin@auriga.com> wrote:
>
> Hi!
>
> Unfortunately it can't be split without losing a functionality. It is = a minimal amount of code to make it able to boot the kernel (and therefore = confirm that it works).

No, it absolutely can. Each individual patch should be a
coherent chunk of work, and needs to compile cleanly,
but it doesn't have to be immediately useful on its own.
The usual setup is that a patchseries adding a new board
gradually adds pieces like new devices or bugfixes to
existing code, and it's only in a patch fairly late in the
series that the new board proper is added and enabled.

In a 5 minute scan of this patch I saw at least one cleanup
patch that should be separate (changing hard-coded numbers
in the switch cases in the bcm2835_property.c file). Anything
where you're touching the existing bcm2835/2836 code because
you need to refactor it to be a better base for the bcm2838
work should be a separate patch (this is particularly
important so we can review that the changes don't break the
existing boards). And the usual approach with a new board is
that you have a patch per new device being added (you have
several here) and then a patch at the end for the board changes.
New test cases can be their own patch. Documentation (which
seems to be missing here) can be its own patch.

I would estimate that this will end up being at least 6 patches,
probably more.

thanks
-- PMM
 --_000_ea63d09bb2d249b282a429ff9d373e4daurigacom_--