From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Bastián Almendras" <bastian.almendras96@gmail.com>
Cc: jlee@suse.com, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: platform/x86: acer-wmi: Enable SW_TABLET_MODE on Switch One 10 (SW1-011)
Date: Wed, 19 Nov 2025 15:05:37 +0200 (EET) [thread overview]
Message-ID: <ea6910ff-bcf9-7d38-b53f-6dc1f730c654@linux.intel.com> (raw)
In-Reply-To: <CABuR8muavDq+rkSfNU0zM+ZBgtmumxdq-haPkuyD5A=xK_pSxA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1539 bytes --]
On Wed, 19 Nov 2025, Bastián Almendras wrote:
> Hello, good morning. I'm trying to get my old tablet working properly on Debian, but
> I've had to add some fixes.
> Here's a commit I created to add the SW_tablet_mode functionality to this tablet
> using acer-wmi.c.
> Add a DMI quirk for the SW1-011 setting force_caps to ACER_CAP_KBD_DOCK
> (these devices have no other acer-wmi based functionality).
>
> Thank you very much for taking the time to read this.
>
> Here's the diff:
>
> 704a705,713
> .callback = set_force_caps,
> .ident = "Acer Switch One SW1-011",
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Switch One SW1-011"),
> },
> .driver_data = (void *)ACER_CAP_KBD_DOCK,
> },
> {
Thanks but this email is not following our submission guidelines and is
not formatted right.
Please take a look at Documentation/process/submitting-patches.rst
It might also help if you browse through a few submission from ML
archives at lore.kernel.org to get a general idea how the submissions are
formatted as that documention, while explaning some things in detail,
doesn't give a overall example.
Also, if you use git format-patch command to create the patch, it produces
the expected formatting by default.
(You don't need to be worried over not getting everything right on the
next try, we're more than happy to guide you to towards the finish line
once the formatting is roughly what is normally expected from a patch.)
--
i.
parent reply other threads:[~2025-11-19 13:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CABuR8muavDq+rkSfNU0zM+ZBgtmumxdq-haPkuyD5A=xK_pSxA@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea6910ff-bcf9-7d38-b53f-6dc1f730c654@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bastian.almendras96@gmail.com \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.