All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Child <nnac123@linux.ibm.com>
To: Dave Marquardt <davemarq@linux.ibm.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	haren@linux.ibm.com, ricklind@us.ibm.com, nick.child@ibm.com,
	jacob.e.keller@intel.com, horms@kernel.org
Subject: Re: [PATCH 1/3] hexdump: Implement macro for converting large buffers
Date: Fri, 14 Feb 2025 12:33:20 -0600	[thread overview]
Message-ID: <ea7a6153-ea25-4ee7-975f-36a87d5f8e97@linux.ibm.com> (raw)
In-Reply-To: <87tt8wflt5.fsf@linux.ibm.com>

Hi Dave,

Thanks for reviewing,

On 2/14/25 12:00 PM, Dave Marquardt wrote:
> Nick Child <nnac123@linux.ibm.com> writes:
>
>> +	     (i) += (rowsize) == 16 || (rowsize) == 32 ? (rowsize) : 16	\
> Nit: If you left out the (rowsize) == 16 check here you'd still add 16
> to (i).

I was trying to have this translate into "if invalid rowsize was used 
then default to 16" since

hex_dump_to_buffer has a very similar conditional. But I agree, 
logically it looks strange.

If I send a v3 (I also foolishly forgot the v2 tag in this patch), I 
will change this like to

+	     (i) += (rowsize) == 32 ? 32 : 16	\


  parent reply	other threads:[~2025-02-14 18:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 16:24 [PATCH v2 0/3] Use new for_each macro to create hexdumps Nick Child
2025-02-14 16:24 ` [PATCH 1/3] hexdump: Implement macro for converting large buffers Nick Child
     [not found]   ` <87tt8wflt5.fsf@linux.ibm.com>
2025-02-14 18:33     ` Nick Child [this message]
2025-02-15 16:36   ` Simon Horman
2025-02-15 17:40     ` David Laight
2025-02-15 17:46       ` David Laight
2025-02-16  9:32         ` Simon Horman
2025-02-16 11:24           ` David Laight
2025-02-17 15:09             ` Nick Child
2025-02-18 12:31               ` Paolo Abeni
2025-02-14 16:24 ` [PATCH v2 2/3] hexdump: Use for_each macro in print_hex_dump Nick Child
2025-02-14 16:24 ` [PATCH v2 3/3] ibmvnic: Print data buffers with kernel API's Nick Child
  -- strict thread matches above, loose matches on Subject: below --
2025-01-13 22:17 [PATCH 0/3] Use new for_each macro to create hexdumps Nick Child
2025-01-13 22:17 ` [PATCH 1/3] hexdump: Implement macro for converting large buffers Nick Child
2025-01-14 14:48   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea7a6153-ea25-4ee7-975f-36a87d5f8e97@linux.ibm.com \
    --to=nnac123@linux.ibm.com \
    --cc=davemarq@linux.ibm.com \
    --cc=haren@linux.ibm.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nick.child@ibm.com \
    --cc=ricklind@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.