From: "Kasireddy, Vivek" <vivek.kasireddy@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: RE: [PATCH v2 2/8] ui/egl: Add egl helpers to help with synchronization
Date: Tue, 15 Jun 2021 23:11:08 +0000 [thread overview]
Message-ID: <ea7e97778bfb4a2388b800fdb4f3ef0f@intel.com> (raw)
In-Reply-To: <20210615053151.ucxtisr5ujlsnv2g@sirius.home.kraxel.org>
Hi Gerd,
> > +void egl_dmabuf_create_fence(QemuDmaBuf *dmabuf)
> > +{
> > + if (dmabuf->sync) {
> > + dmabuf->fence_fd = eglDupNativeFenceFDANDROID(qemu_egl_display,
> > + dmabuf->sync);
> > + eglDestroySyncKHR(qemu_egl_display, dmabuf->sync);
> > + dmabuf->sync = NULL;
> > + }
> > +}
>
> > +void egl_dmabuf_wait_sync(QemuDmaBuf *dmabuf)
> > +{
>
> Hmm, still the blocking wait. Can't you do something like
[Kasireddy, Vivek] Right, it is a blocking wait; but this gets called from a new GTK thread
that does the actual drawing.
> "qemu_set_fd_handler(dmabuf->fence_fd, ...)" to avoid the
> eglClientWaitSyncKHR() completely?
[Kasireddy, Vivek] Yeah, I think this is also doable; let me look into it.
Thanks,
Vivek
>
> take care,
> Gerd
next prev parent reply other threads:[~2021-06-15 23:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 22:48 [PATCH v2 0/8] virtio-gpu: Add a default synchronization mechanism for blobs Vivek Kasireddy
2021-06-10 22:48 ` [PATCH v2 1/8] ui/gtk: Create a common release_dmabuf helper Vivek Kasireddy
2021-06-10 22:48 ` [PATCH v2 2/8] ui/egl: Add egl helpers to help with synchronization Vivek Kasireddy
2021-06-15 5:31 ` Gerd Hoffmann
2021-06-15 23:11 ` Kasireddy, Vivek [this message]
2021-06-10 22:48 ` [PATCH v2 3/8] ui: Add a helper to wait on a dmabuf sync object Vivek Kasireddy
2021-06-10 22:48 ` [PATCH v2 4/8] ui/gtk: Implement wait_dmabuf function Vivek Kasireddy
2021-06-10 22:48 ` [PATCH v2 5/8] ui: Create sync objects only for blobs Vivek Kasireddy
2021-06-10 22:48 ` [PATCH v2 6/8] ui/gtk-egl: Wait for the draw signal for dmabuf blobs Vivek Kasireddy
2021-06-10 22:48 ` [PATCH v2 7/8] virtio-gpu: Add dmabuf helpers for synchronization Vivek Kasireddy
2021-06-10 22:48 ` [PATCH v2 8/8] virtio-gpu: Add gl_flushed callback Vivek Kasireddy
2021-06-15 5:50 ` Gerd Hoffmann
2021-06-15 23:34 ` Kasireddy, Vivek
2021-06-14 22:48 ` [PATCH v2 0/8] virtio-gpu: Add a default synchronization mechanism for blobs no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea7e97778bfb4a2388b800fdb4f3ef0f@intel.com \
--to=vivek.kasireddy@intel.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.