All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: xen-devel@lists.xensource.com
Cc: keir.fraser@eu.citrix.com
Subject: [PATCH 2 of 3] To help debug stack overflows, debug backtrace now shows
Date: Thu, 03 Dec 2009 18:50:02 -0000	[thread overview]
Message-ID: <ea7fc895409dbaf507da.1259866202@phenom.dumpdata.com> (raw)
In-Reply-To: <patchbomb.1259866200@phenom.dumpdata.com>

# HG changeset patch
# User konrad@phenom.dumpdata.com
# Date 1259769725 18000
# Node ID ea7fc895409dbaf507da807b3473431e6586a907
# Parent  f9eeb0545e1c48cd9fc090c3be8d994b258dd636
To help debug stack overflows, debug backtrace now shows
stack pointer values and stack limits.

Authored-by: David Lively
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

diff -r f9eeb0545e1c -r ea7fc895409d xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c	Wed Dec 02 10:57:18 2009 -0500
+++ b/xen/arch/x86/traps.c	Wed Dec 02 11:02:05 2009 -0500
@@ -239,18 +239,25 @@
 {
     unsigned long *frame, next, addr, low, high;
 
-    printk("Xen call trace:\n   ");
-
-    printk("[<%p>]", _p(regs->eip));
-    print_symbol(" %s\n   ", regs->eip);
+    printk("Xen call trace:\n");
 
     /* Bounds for range of valid frame pointer. */
     low  = (unsigned long)(ESP_BEFORE_EXCEPTION(regs) - 2);
     high = (low & ~(STACK_SIZE - 1)) + 
         (STACK_SIZE - sizeof(struct cpu_info) - 2*sizeof(unsigned long));
 
+    {
+        unsigned long bos, los;
+        bos = (low & ~(STACK_SIZE - 1)) + STACK_SIZE;
+        los = bos - PAGE_SIZE;
+        printk("Stack base:%p limit:%p\n   ", _p(bos), _p(los));
+    }
+    
     /* The initial frame pointer. */
     next = regs->ebp;
+    
+    printk("%p[<%p>]", _p(next), _p(regs->eip));
+    print_symbol(" %s\n   ", regs->eip);
 
     for ( ; ; )
     {
@@ -278,7 +285,7 @@
             addr  = frame[1];
         }
 
-        printk("[<%p>]", _p(addr));
+        printk("%p[<%p>]", _p(next), _p(addr));
         print_symbol(" %s\n   ", addr);
 
         low = (unsigned long)&frame[2];

  parent reply	other threads:[~2009-12-03 18:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03 18:50 [PATCH 0 of 3] Patches to help fix issues in the field Konrad Rzeszutek Wilk
2009-12-03 18:50 ` [PATCH 1 of 3] Made arch_memory_op propagate (instead of ignore) errors from guest_physmap_add_page Konrad Rzeszutek Wilk
2009-12-03 18:50 ` Konrad Rzeszutek Wilk [this message]
2009-12-03 18:50 ` [PATCH 3 of 3] Provided a routine to print the active grant table entries Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea7fc895409dbaf507da.1259866202@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.