From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Roi Dayan <roid@nvidia.com>,
Miaoqian Lin <linmq006@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [net 01/11] net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init_resources
Date: Wed, 22 Dec 2021 20:28:16 -0800 [thread overview]
Message-ID: <eaa0dfacd5df9ac76469575ddb8bbbcfae21ad25.camel@kernel.org> (raw)
In-Reply-To: <20211222170932.1773d408@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, 2021-12-22 at 17:09 -0800, Jakub Kicinski wrote:
> On Wed, 22 Dec 2021 17:04:03 -0800 Jakub Kicinski wrote:
> > On Wed, 22 Dec 2021 13:11:51 -0800 Saeed Mahameed wrote:
> > > From: Miaoqian Lin <linmq006@gmail.com>
> > >
> > > The mlx5_get_uars_page() function returns error pointers.
> > > Using IS_ERR() to check the return value to fix this.
> > >
> > > Fixes: 4ec9e7b02697("net/mlx5: DR, Expose steering domain
> > > functionality")
> >
> > Do you mind fixing this missing space? I'll cherry pick the change
> > from
Sure, I will submit v2.
> > net-next in the meantime.
>
> I take that back, I thought the error was on our side but looks like
> the patch was put in the wrong PR. Why not put it in the net PR
Yes, my mistake, the bug only existed in net-next when I accepted the
patch, I mistakenly left it in my net-next tree after rc1 was out.
> yourself? We'll handle the unavoidable conflict, but I don't see any
> advantage to me cherry picking here (which I can't do directly
> anyway,
This how I remember we used to do it.
Sure i will attach it in v2. I already checked, there will be no
conflicts.
next prev parent reply other threads:[~2021-12-23 4:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 21:11 [pull request][net 00/11] mlx5 fixes 2021-12-22 Saeed Mahameed
2021-12-22 21:11 ` [net 01/11] net/mlx5: DR, Fix NULL vs IS_ERR checking in dr_domain_init_resources Saeed Mahameed
2021-12-23 1:04 ` Jakub Kicinski
2021-12-23 1:09 ` Jakub Kicinski
2021-12-23 4:28 ` Saeed Mahameed [this message]
2021-12-22 21:11 ` [net 02/11] net/mlx5: DR, Fix querying eswitch manager vport for ECPF Saeed Mahameed
2021-12-22 21:11 ` [net 03/11] net/mlx5: Use first online CPU instead of hard coded CPU Saeed Mahameed
2021-12-22 21:11 ` [net 04/11] net/mlx5: Fix error print in case of IRQ request failed Saeed Mahameed
2021-12-22 21:11 ` [net 05/11] net/mlx5: Fix SF health recovery flow Saeed Mahameed
2021-12-22 21:11 ` [net 06/11] net/mlx5: Fix tc max supported prio for nic mode Saeed Mahameed
2021-12-22 21:11 ` [net 07/11] net/mlx5e: Wrap the tx reporter dump callback to extract the sq Saeed Mahameed
2021-12-22 21:11 ` [net 08/11] net/mlx5e: Fix skb memory leak when TC classifier action offloads are disabled Saeed Mahameed
2021-12-22 21:11 ` [net 09/11] net/mlx5e: Fix interoperability between XSK and ICOSQ recovery flow Saeed Mahameed
2021-12-22 21:12 ` [net 10/11] net/mlx5e: Fix ICOSQ recovery flow for XSK Saeed Mahameed
2021-12-22 21:12 ` [net 11/11] net/mlx5e: Delete forward rule for ct or sample action Saeed Mahameed
2021-12-23 10:31 ` [pull request][net 00/11] mlx5 fixes 2021-12-22 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa0dfacd5df9ac76469575ddb8bbbcfae21ad25.camel@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linmq006@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.