From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A74C4C43334 for ; Sun, 17 Jul 2022 03:00:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D00338341C; Sun, 17 Jul 2022 05:00:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="CrNccVzH"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="dHkpNAvO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BB2968341C; Sun, 17 Jul 2022 05:00:21 +0200 (CEST) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BE848212A for ; Sun, 17 Jul 2022 05:00:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id 329F64E2006; Sun, 17 Jul 2022 03:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1658026816; bh=WeJix2ZkhNo1lV/duVXB74ShUdYpQAh15wON7Z3dSSQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=CrNccVzH4NbPuw713r9Hmv8L7ZFeKt5XgElEWML37rMKmjKJsp8qJVUDWI/elstHm SLi/l7Y9HHEdnEaHLjmySpAb25B8s0/dPrAvTl80AmB3iIL4ohzNffrFL3cdy3Ms/E RkpHNTjU0h8nm7jXKp6pBnNmxZ/yz69MV8HRgAH8= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B0k9Y0qj5dlZ; Sun, 17 Jul 2022 03:00:15 +0000 (UTC) Received: from www.akkea.ca (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id D61504E2003; Sun, 17 Jul 2022 03:00:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1658026815; bh=WeJix2ZkhNo1lV/duVXB74ShUdYpQAh15wON7Z3dSSQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=dHkpNAvO5coC4/paFB1U7slVebkkoy0RoSvIcDHKg2zBPpOgXNX3l1n2RcoqSoCEy EgXINXYtW6IPOEknJxIvF3amQU3JuYOjTqVQGkaCOZG99c1mFrQTzTT4+QExtiLMbB DnV0vMgYGs+/yfuqMUrKJSBQ/R1SxxIa0NFKJvLE= MIME-Version: 1.0 Date: Sat, 16 Jul 2022 20:00:15 -0700 From: Angus Ainslie To: Marek Vasut Cc: U Boot , Michal Simek , kernel@puri.sm Subject: Re: DWC3 host support In-Reply-To: <13226946-1652-f917-f580-e626f51c2525@denx.de> References: <13226946-1652-f917-f580-e626f51c2525@denx.de> Message-ID: X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.17 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2022-07-16 11:37, Marek Vasut wrote: > On 7/16/22 15:02, Angus Ainslie wrote: >> Hi Michal, >> >> I recently rebased my librem5 tree onto the latest u-boot-imx branch >> and the dwc3 host mode stopped working. >> >> I bisected it down to this commit: >> >> 142d50fbce7c364a74f5e8204dba491b9f066e6c usb: dwc3: Add support for >> usb3-phy PHY configuration >> >> Reverting that commit allows usb host mode to work on the librem5 >> again. >> >> Should this initialization go into an SOC specific glue_configure >> function ? >> >> Is the imx8mq.dtsi missing something that will keep usb host working >> with this patch ? >> >> Does this break usb host on other imx8mq devices ? > > Wasn't this fixed by: > 868d58f69c ("usb: dwc3: Fix non-usb3 configurations") > ? I've got that in my tree and it still fails to probe the USB2 hub and USB 2 storage. Angus