From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: "David Härdeman" <david@hardeman.nu>,
"Ping-Ke Shih" <pkshih@realtek.com>,
linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Leonard Lausen <leonard@lausen.nl>,
Alastair D'Silva <alastair@d-silva.org>,
Luka Gejak <luka.gejak@linux.dev>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>
Subject: Re: [PATCH rtw-next 5/5] wifi: rtw88: sdio: read neighbouring registers of the 88xx chips at once
Date: Wed, 18 Nov 2026 17:56:15 +0200 [thread overview]
Message-ID: <eac5da81-b823-4f9e-ac85-add330c03b0b@gmail.com> (raw)
In-Reply-To: <20261116190145.2736364-6-david@hardeman.nu>
On 16/11/2026 21:01, David Härdeman wrote:
> Every register access costs a full SDIO command, about 40 us on a NanoPi
> R76S (RTL8822CS, SDR104), no matter how many bytes it moves. The
> interrupt handler reads HISR and then RX0_REQ_LEN, which follows it, and
> a free page sync reads the three REG_SDIO_FREE_TXPG words one by one.
>
> Read HISR together with RX0_REQ_LEN, and the three free page words, with
> one transfer each, as Realtek's driver does. As in rtw_sdio_readl(),
> this is only done while the chip is powered on; before that, and if the
> small DMA-safe buffers this needs could not be allocated, the registers
> are read one by one as before.
>
> On the R76S acting as an AP, TCP throughput to a client goes from about
> 170 to about 190 Mbit/s, the other directions are unchanged.
>
> Signed-off-by: David Härdeman <david@hardeman.nu>
> ---
> drivers/net/wireless/realtek/rtw88/sdio.c | 84 ++++++++++++++++++++---
> drivers/net/wireless/realtek/rtw88/sdio.h | 4 ++
> 2 files changed, 78 insertions(+), 10 deletions(-)
>
[...]
> diff --git a/drivers/net/wireless/realtek/rtw88/sdio.h b/drivers/net/wireless/realtek/rtw88/sdio.h
> index ab366f82d92..6aa59ed3db2 100644
> --- a/drivers/net/wireless/realtek/rtw88/sdio.h
> +++ b/drivers/net/wireless/realtek/rtw88/sdio.h
> @@ -188,6 +188,10 @@ struct rtw_sdio {
> bool free_txpg_valid;
> /* TX aggregation buffer of the non-8051 chips, under tx_credit_lock */
> u8 *tx_agg_buf;
> + /* non-8051 chips: HISR + RX0_REQ_LEN, read by the interrupt handler */
> + __le32 *rx_regs;
> + /* non-8051 chips: the REG_SDIO_FREE_TXPG words, under tx_credit_lock */
> + __le32 *txpg_regs;
> /* one writer at a time between the credit check and the accounting */
> struct mutex tx_credit_lock;
> };
By the way, you can call them "3081 chips".
next prev parent reply other threads:[~2026-11-18 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:01 [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 1/5] wifi: rtw88: sdio: cache the free TX page counts of " David Härdeman
2026-11-17 7:20 ` Luka Gejak
2026-11-17 12:50 ` David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 2/5] wifi: rtw88: sdio: aggregate TX frames " David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 3/5] wifi: rtw88: sdio: limit the TX queue length " David Härdeman
2026-11-17 7:21 ` Luka Gejak
2026-11-17 12:57 ` David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 4/5] wifi: rtw88: sdio: let TX in while receiving on " David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 5/5] wifi: rtw88: sdio: read neighbouring registers of the 88xx chips at once David Härdeman
2026-11-18 15:56 ` Bitterblue Smith [this message]
2026-11-16 21:59 ` [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips Luka Gejak
2026-11-17 7:46 ` Ping-Ke Shih
2026-11-17 14:44 ` David Härdeman
2026-11-17 15:27 ` Luka Gejak
2026-11-18 10:54 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac5da81-b823-4f9e-ac85-add330c03b0b@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=alastair@d-silva.org \
--cc=david@hardeman.nu \
--cc=jernej.skrabec@gmail.com \
--cc=leonard@lausen.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.