From: Jeff Layton <jlayton@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
miklos@szeredi.hu, gregkh@linuxfoundation.org, tj@kernel.org,
jack@suse.cz, amir73il@gmail.com, paul@paul-moore.com,
eparis@redhat.com, linux-audit@redhat.com, rafael@kernel.org
Subject: Re: [PATCH 0/5] vfs: track the dentry name length in name_snapshot
Date: Fri, 26 Apr 2019 15:03:16 -0400 [thread overview]
Message-ID: <eac6b8a50c98abe2c5a3858a9d11555de2cedca3.camel@kernel.org> (raw)
In-Reply-To: <20190426185158.GB2217@ZenIV.linux.org.uk>
On Fri, 2019-04-26 at 19:51 +0100, Al Viro wrote:
> On Fri, Apr 26, 2019 at 02:28:42PM -0400, Jeff Layton wrote:
> > name_snapshot will snapshot the current contents of a dentry's name for
> > later consumption. Several of those users end up needing to do a strlen
> > on the resulting string later. We already have that info in the original
> > dentry though, so we can do this a bit more efficiently by stuffing the
> > name length into the name_snapshot as well.
> >
> > This is not well tested, but it built and booted. Do we have a testsuite
> > that exercises the fsnotify code, in particular?
>
> FWIW, my variant sits in vfs.git@work.dcache.
>
> > Jeff Layton (5):
> > dcache: track the length of the string in struct name_snapshot
> > fsnotify: have fsnotify_move take a struct qstr instead of a string
> > fsnotify: have fsnotify() take a qstr instead of a string
> > fsnotify: change ->handle_event and send_to_group to take a qstr
> > audit: fix audit_compare_dname_path to take a qstr
> >
> > fs/dcache.c | 11 +++++++----
> > fs/debugfs/inode.c | 2 +-
> > fs/kernfs/file.c | 6 ++++--
> > fs/namei.c | 4 ++--
> > fs/notify/dnotify/dnotify.c | 2 +-
> > fs/notify/fanotify/fanotify.c | 2 +-
> > fs/notify/fsnotify.c | 8 ++++----
> > fs/notify/inotify/inotify.h | 2 +-
> > fs/notify/inotify/inotify_fsnotify.c | 6 +++---
> > fs/overlayfs/export.c | 2 +-
> > include/linux/dcache.h | 2 +-
> > include/linux/fsnotify.h | 17 ++++++++---------
> > include/linux/fsnotify_backend.h | 6 +++---
> > kernel/audit.h | 3 ++-
> > kernel/audit_fsnotify.c | 5 +++--
> > kernel/audit_tree.c | 2 +-
> > kernel/audit_watch.c | 4 ++--
> > kernel/auditfilter.c | 7 ++++---
> > kernel/auditsc.c | 7 +++----
> > 19 files changed, 52 insertions(+), 46 deletions(-)
>
> fs/dcache.c | 14 ++++++--------
> fs/debugfs/inode.c | 2 +-
> fs/kernfs/file.c | 6 ++++--
> fs/namei.c | 4 ++--
> fs/notify/dnotify/dnotify.c | 2 +-
> fs/notify/fanotify/fanotify.c | 2 +-
> fs/notify/fsnotify.c | 8 ++++----
> fs/notify/inotify/inotify.h | 2 +-
> fs/notify/inotify/inotify_fsnotify.c | 6 +++---
> fs/overlayfs/export.c | 2 +-
> include/linux/dcache.h | 2 +-
> include/linux/fsnotify.h | 10 +++++-----
> include/linux/fsnotify_backend.h | 6 +++---
> kernel/audit.h | 2 +-
> kernel/audit_fsnotify.c | 2 +-
> kernel/audit_tree.c | 2 +-
> kernel/audit_watch.c | 4 ++--
> kernel/auditfilter.c | 6 +++---
> kernel/auditsc.c | 4 ++--
> 19 files changed, 43 insertions(+), 43 deletions(-)
>
> here...
Pretty similar :)
Let's just go with yours then, since it breaks out some of the strlen
changes into separate patches.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2019-04-26 19:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 18:28 [PATCH 0/5] vfs: track the dentry name length in name_snapshot Jeff Layton
2019-04-26 18:28 ` [PATCH 1/5] dcache: track the length of the string in struct name_snapshot Jeff Layton
2019-04-26 18:28 ` [PATCH 2/5] fsnotify: have fsnotify_move take a struct qstr instead of a string Jeff Layton
2019-04-26 18:28 ` [PATCH 3/5] fsnotify: have fsnotify() take a " Jeff Layton
2019-04-26 18:28 ` [PATCH 4/5] fsnotify: change ->handle_event and send_to_group to take a qstr Jeff Layton
2019-04-26 18:28 ` [PATCH 5/5] audit: fix audit_compare_dname_path " Jeff Layton
2019-04-26 19:02 ` Paul Moore
2019-04-26 18:51 ` [PATCH 0/5] vfs: track the dentry name length in name_snapshot Al Viro
2019-04-26 18:59 ` Paul Moore
2019-04-26 19:03 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac6b8a50c98abe2c5a3858a9d11555de2cedca3.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=amir73il@gmail.com \
--cc=eparis@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=paul@paul-moore.com \
--cc=rafael@kernel.org \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.