From: gadiyar@ti.com (Anand Gadiyar)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next: omap2plus_defconfig not building
Date: Mon, 8 Nov 2010 11:35:16 +0530 [thread overview]
Message-ID: <eace9c309e371630528bc9f8fa208705@mail.gmail.com> (raw)
In-Reply-To: <1287488255.18646.110.camel@e102109-lin.cambridge.arm.com>
Catalin Marinas wrote:
>
> On Tue, 2010-10-19 at 11:18 +0100, Anand Gadiyar wrote:
> > Commit ba1b9be5cd in linux-next (ARM: Add SWP/SWPB emulation for ARMv7
> > processors (v5)) introduced arch/arm/kernel/swp_emulate.c. This file
> > gets compiled when the omap2plus_defconfig is built - the
> > omap2plus_defconfig builds OMAP2420, OMAP2430, OMAP3 and OMAP4 in one
> > image, and has CPU_V6 and CPU_V7 both enabled.
>
> This patch should fix it:
>
>
> ARM: Do not enable SWP emulation if CPU_V6 && CPU_V7
>
> From: Catalin Marinas <catalin.marinas@arm.com>
>
> This option uses LDREXB/STREXB to emulate SWPB but these instructions
> are not supported on all the ARMv6 processors.
>
> Reported-by: Anand Gadiyar <gadiyar@ti.com>
> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Leif Lindholm <Leif.Lindholm@arm.com>
Hi Catalin, Leif,
I can't find this patch in linux-next. Hope we haven't missed it.
Tony acked this btw.
Strangely, the omap2plus_defconfig in v2.6.37-rc1 no longer gets
CONFIG_SWP_EMULATE enabled even without this patch - I can't figure
out why.
- Anand
> ---
> arch/arm/mm/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
> index 8493ed0..5195d61 100644
> --- a/arch/arm/mm/Kconfig
> +++ b/arch/arm/mm/Kconfig
> @@ -638,7 +638,7 @@ config ARM_THUMBEE
>
> config SWP_EMULATE
> bool "Emulate SWP/SWPB instructions"
> - depends on CPU_V7
> + depends on CPU_V7 && !CPU_V6
> select HAVE_PROC_CPU if PROC_FS
> default y if SMP
> help
>
>
>
next prev parent reply other threads:[~2010-11-08 6:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 10:18 linux-next: omap2plus_defconfig not building Anand Gadiyar
2010-10-19 11:37 ` Catalin Marinas
2010-10-19 12:14 ` Anand Gadiyar
2010-10-19 22:49 ` Tony Lindgren
2010-11-08 6:05 ` Anand Gadiyar [this message]
2010-11-08 9:38 ` Uwe Kleine-König
2010-11-08 9:48 ` Catalin Marinas
2010-11-08 10:14 ` Russell King - ARM Linux
2010-11-08 10:20 ` Catalin Marinas
2010-11-08 10:25 ` Russell King - ARM Linux
2010-11-08 10:31 ` Catalin Marinas
2010-11-25 13:54 ` Anand Gadiyar
2010-11-25 16:50 ` Russell King - ARM Linux
2010-11-26 11:35 ` Anand Gadiyar
2010-11-26 11:45 ` Russell King - ARM Linux
2010-11-26 12:22 ` Will Deacon
2010-11-26 12:28 ` Russell King - ARM Linux
2010-11-26 12:38 ` Catalin Marinas
2010-11-26 12:55 ` Dave Martin
2010-11-26 13:00 ` Russell King - ARM Linux
2010-11-26 13:31 ` Dave Martin
2010-11-26 13:53 ` Russell King - ARM Linux
2010-11-26 12:33 ` Russell King - ARM Linux
2010-12-23 19:55 ` Tony Lindgren
2010-12-23 20:15 ` Tony Lindgren
2010-12-23 20:30 ` Russell King - ARM Linux
2010-12-23 21:06 ` Tony Lindgren
2011-01-07 3:59 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eace9c309e371630528bc9f8fa208705@mail.gmail.com \
--to=gadiyar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.