From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FCB612C484; Fri, 21 Jun 2024 22:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719008245; cv=none; b=AgDb9zp7G4cpB437f31/LMPaF1JpxvzHiSpBFB4ZoaRY36Hh4HmS7Cx7VPI9R2WUihddUJDvTyRmi8ncWKmFZoZQmmcNTKHYg00dZmiTdVOHQ0yj+uL82wOtrZwUak4lVEvGB7tSJp4y2pepMnj8ro4BdMQvI7mVGo+35/2FRP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719008245; c=relaxed/simple; bh=XIgP3gnjd7LTC0cYexQhnrJXzTEPBFd9t0ht0ox/1jo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ij0PfbXv+eziAOyTjGybXI7MlDqsRtk5D7MQGL4Xbcm8TEXGubTSRsCYhKcf1NtJ8SixEu0zPNfwWypIUMuCbl4+O7AUuRz9hlulK5X2yYdSbD15C13vRN+JPjKxhL4voW7Et74IqtghIRCLnX8fY5M4Kqq9CgsiCN6iwsJJ+A0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FNLs4VxL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FNLs4VxL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0FBAC2BBFC; Fri, 21 Jun 2024 22:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719008244; bh=XIgP3gnjd7LTC0cYexQhnrJXzTEPBFd9t0ht0ox/1jo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FNLs4VxLGgEYEzsY52miCNNujSfXwPo8nvN02pkUceS4AGd/t9R0YBoGuSz0iSBC5 1P24T8SfRPpNKmYsJD3FQf44uMwvChSF0oWtp9SwcqssBupu93Dg7mQNvgDm9G60Uv U2FFjo9EmbwgtSJ5EizcIuV+n3ybPB4bOryBaXpCd92LGyHoja7v/Y+S7s8WBBfq9C XvOamhRIhWggfPWdi28OLfKdK+MZBdU6E++x8qWpRn2D5+Wu3w0XzST89l7AeJewfc Y6jKnIVav4PDjOgs66bE1oBclTu97rV0yQDXG1sDtBRGWuesPPneNSCW+t+RoGwt3N CuVYcjsbcJRYA== Message-ID: Date: Sat, 22 Jun 2024 00:16:56 +0200 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] hwrng: add Rockchip SoC hwrng driver To: Dragan Simic , Krzysztof Kozlowski Cc: Daniel Golle , Aurelien Jarno , Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Sebastian Reichel , Anand Moon , Sascha Hauer , Martin Kaiser , Ard Biesheuvel , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <57a7fb13451f066ddc8d1d9339d8f6c1e1946bf1.1718921174.git.daniel@makrotopia.org> <173ce1663186ab8282356748abcac3f4@manjaro.org> Content-Language: en-US, de-DE From: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= In-Reply-To: <173ce1663186ab8282356748abcac3f4@manjaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Dragan, On 6/21/24 20:13, Dragan Simic wrote: > On 2024-06-21 11:57, Krzysztof Kozlowski wrote: >> On 21/06/2024 03:25, Daniel Golle wrote: >>> From: Aurelien Jarno > > [snip] > >>> +    pm_runtime_set_autosuspend_delay(dev, RK_RNG_AUTOSUSPEND_DELAY); >>> +    pm_runtime_use_autosuspend(dev); >>> +    pm_runtime_enable(dev); >>> + >>> +    ret = devm_hwrng_register(dev, &rk_rng->rng); >>> +    if (ret) >>> +        return dev_err_probe(&pdev->dev, ret, "Failed to register >>> Rockchip hwrng\n"); >>> + >>> +    dev_info(&pdev->dev, "Registered Rockchip hwrng\n"); >> >> Drop, driver should be silent on success. > > I respectfully disagree.  Many drivers print a single line upon > successful probing, which I find very useful.  In this particular > case, it's even more useful, because some people may be concerned > about the use of hardware TRNGs, so we should actually make sure > to announce it. I agree to Krzysztof here. From the POV of a driver author, your own driver is very important and while you write it, it really interests *you* if the driver is successfully probed. However from a system perspective these are annoying: There are easily >50 devices[1] on a system, if all of these print a message in probe, you have little chance to see the relevant messages. Even if every driver author thinks their work is a special snow flake that is worth announcing, in practice users only care about your driver if there is a problem. Additionally each message takes time and so delays the boot process. Additionally each message takes place in the printk ring buffer and so edges out earlier messages that might be more important. So +1 for dropping the dev_info() or at least using dev_debug() for it. Best regards Uwe [1] On my laptop if have: $ find /sys/devices -name driver | wc -l 87 On a Raspberrypi it yields 66. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 874C7C27C4F for ; Fri, 21 Jun 2024 22:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8jGY36YqMcCZ1C9MJkVuvEnC+aSC+2WBvPkyKgGELQ8=; b=sWHa67AtSkmdFY 1gNSqAQDOlmMsIkfZqr84JvoRVTu+zMqeOUPrnZFKW64LJak3y3GR/brO/WnIvIdtcDfA/Z0VGF7v icUKAPdL6qqPZ6PdbShOsdcNR6t89/z+Z+HUVYOt/htloQRLimA0bwaX6+s2/AVlfJOYFvdWDh7Jc +XRg1D8AHlmRf8brD4PSIwBTNGau70pqgvwKEl8yLYL7i6xFBTT5EYHy9+M5QU5RJx86MR5qh5QI7 dhwCJmkVOtuT7XMCA/nAKOJcjRzQlGH7ssyJJhUv7THICiP9uX/2dfzBdNXG9TKIPEyKZdsg5+AUf cXC9rgnVzBpTsRPmDWdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKmZc-0000000AjUH-3TWD; Fri, 21 Jun 2024 22:17:36 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKmZX-0000000AjT4-43HV; Fri, 21 Jun 2024 22:17:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id ACA18CE3D30; Fri, 21 Jun 2024 22:17:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0FBAC2BBFC; Fri, 21 Jun 2024 22:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719008244; bh=XIgP3gnjd7LTC0cYexQhnrJXzTEPBFd9t0ht0ox/1jo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FNLs4VxLGgEYEzsY52miCNNujSfXwPo8nvN02pkUceS4AGd/t9R0YBoGuSz0iSBC5 1P24T8SfRPpNKmYsJD3FQf44uMwvChSF0oWtp9SwcqssBupu93Dg7mQNvgDm9G60Uv U2FFjo9EmbwgtSJ5EizcIuV+n3ybPB4bOryBaXpCd92LGyHoja7v/Y+S7s8WBBfq9C XvOamhRIhWggfPWdi28OLfKdK+MZBdU6E++x8qWpRn2D5+Wu3w0XzST89l7AeJewfc Y6jKnIVav4PDjOgs66bE1oBclTu97rV0yQDXG1sDtBRGWuesPPneNSCW+t+RoGwt3N CuVYcjsbcJRYA== Message-ID: Date: Sat, 22 Jun 2024 00:16:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] hwrng: add Rockchip SoC hwrng driver To: Dragan Simic , Krzysztof Kozlowski Cc: Daniel Golle , Aurelien Jarno , Olivia Mackall , Herbert Xu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Sebastian Reichel , Anand Moon , Sascha Hauer , Martin Kaiser , Ard Biesheuvel , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <57a7fb13451f066ddc8d1d9339d8f6c1e1946bf1.1718921174.git.daniel@makrotopia.org> <173ce1663186ab8282356748abcac3f4@manjaro.org> Content-Language: en-US, de-DE From: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= In-Reply-To: <173ce1663186ab8282356748abcac3f4@manjaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_151732_382435_758775FA X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8gRHJhZ2FuLAoKT24gNi8yMS8yNCAyMDoxMywgRHJhZ2FuIFNpbWljIHdyb3RlOgo+IE9u IDIwMjQtMDYtMjEgMTE6NTcsIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4+IE9uIDIxLzA2 LzIwMjQgMDM6MjUsIERhbmllbCBHb2xsZSB3cm90ZToKPj4+IEZyb206IEF1cmVsaWVuIEphcm5v IDxhdXJlbGllbkBhdXJlbDMyLm5ldD4KPiAKPiBbc25pcF0KPiAKPj4+ICvCoMKgwqAgcG1fcnVu dGltZV9zZXRfYXV0b3N1c3BlbmRfZGVsYXkoZGV2LCBSS19STkdfQVVUT1NVU1BFTkRfREVMQVkp Owo+Pj4gK8KgwqDCoCBwbV9ydW50aW1lX3VzZV9hdXRvc3VzcGVuZChkZXYpOwo+Pj4gK8KgwqDC oCBwbV9ydW50aW1lX2VuYWJsZShkZXYpOwo+Pj4gKwo+Pj4gK8KgwqDCoCByZXQgPSBkZXZtX2h3 cm5nX3JlZ2lzdGVyKGRldiwgJnJrX3JuZy0+cm5nKTsKPj4+ICvCoMKgwqAgaWYgKHJldCkKPj4+ ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gZGV2X2Vycl9wcm9iZSgmcGRldi0+ZGV2LCByZXQsICJG YWlsZWQgdG8gcmVnaXN0ZXIgCj4+PiBSb2NrY2hpcCBod3JuZ1xuIik7Cj4+PiArCj4+PiArwqDC oMKgIGRldl9pbmZvKCZwZGV2LT5kZXYsICJSZWdpc3RlcmVkIFJvY2tjaGlwIGh3cm5nXG4iKTsK Pj4KPj4gRHJvcCwgZHJpdmVyIHNob3VsZCBiZSBzaWxlbnQgb24gc3VjY2Vzcy4KPiAKPiBJIHJl c3BlY3RmdWxseSBkaXNhZ3JlZS7CoCBNYW55IGRyaXZlcnMgcHJpbnQgYSBzaW5nbGUgbGluZSB1 cG9uCj4gc3VjY2Vzc2Z1bCBwcm9iaW5nLCB3aGljaCBJIGZpbmQgdmVyeSB1c2VmdWwuwqAgSW4g dGhpcyBwYXJ0aWN1bGFyCj4gY2FzZSwgaXQncyBldmVuIG1vcmUgdXNlZnVsLCBiZWNhdXNlIHNv bWUgcGVvcGxlIG1heSBiZSBjb25jZXJuZWQKPiBhYm91dCB0aGUgdXNlIG9mIGhhcmR3YXJlIFRS TkdzLCBzbyB3ZSBzaG91bGQgYWN0dWFsbHkgbWFrZSBzdXJlCj4gdG8gYW5ub3VuY2UgaXQuCgpJ IGFncmVlIHRvIEtyenlzenRvZiBoZXJlLiBGcm9tIHRoZSBQT1Ygb2YgYSBkcml2ZXIgYXV0aG9y LCB5b3VyIG93bgpkcml2ZXIgaXMgdmVyeSBpbXBvcnRhbnQgYW5kIHdoaWxlIHlvdSB3cml0ZSBp dCwgaXQgcmVhbGx5IGludGVyZXN0cwoqeW91KiBpZiB0aGUgZHJpdmVyIGlzIHN1Y2Nlc3NmdWxs eSBwcm9iZWQuIEhvd2V2ZXIgZnJvbSBhIHN5c3RlbQpwZXJzcGVjdGl2ZSB0aGVzZSBhcmUgYW5u b3lpbmc6IFRoZXJlIGFyZSBlYXNpbHkgPjUwIGRldmljZXNbMV0gb24gYQpzeXN0ZW0sIGlmIGFs bCBvZiB0aGVzZSBwcmludCBhIG1lc3NhZ2UgaW4gcHJvYmUsIHlvdSBoYXZlIGxpdHRsZSBjaGFu Y2UKdG8gc2VlIHRoZSByZWxldmFudCBtZXNzYWdlcy4gRXZlbiBpZiBldmVyeSBkcml2ZXIgYXV0 aG9yIHRoaW5rcyB0aGVpcgp3b3JrIGlzIGEgc3BlY2lhbCBzbm93IGZsYWtlIHRoYXQgaXMgd29y dGggYW5ub3VuY2luZywgaW4gcHJhY3RpY2UgdXNlcnMKb25seSBjYXJlIGFib3V0IHlvdXIgZHJp dmVyIGlmIHRoZXJlIGlzIGEgcHJvYmxlbS4gQWRkaXRpb25hbGx5IGVhY2gKbWVzc2FnZSB0YWtl cyB0aW1lIGFuZCBzbyBkZWxheXMgdGhlIGJvb3QgcHJvY2Vzcy4gQWRkaXRpb25hbGx5IGVhY2gg Cm1lc3NhZ2UgdGFrZXMgcGxhY2UgaW4gdGhlIHByaW50ayByaW5nIGJ1ZmZlciBhbmQgc28gZWRn ZXMgb3V0IGVhcmxpZXIgCm1lc3NhZ2VzIHRoYXQgbWlnaHQgYmUgbW9yZSBpbXBvcnRhbnQuCgpT byArMSBmb3IgZHJvcHBpbmcgdGhlIGRldl9pbmZvKCkgb3IgYXQgbGVhc3QgdXNpbmcgZGV2X2Rl YnVnKCkgZm9yIGl0LgoKQmVzdCByZWdhcmRzClV3ZQoKWzFdIE9uIG15IGxhcHRvcCBpZiBoYXZl OgoKCSQgZmluZCAvc3lzL2RldmljZXMgLW5hbWUgZHJpdmVyIHwgd2MgLWwKCTg3CgogICAgIE9u IGEgUmFzcGJlcnJ5cGkgaXQgeWllbGRzIDY2LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJv Y2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo=