From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72167566A for ; Thu, 5 Jun 2025 09:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749114423; cv=none; b=bC3G1ptWGP3FOEw2FEnvrT/1imWLxRpmpMosVtNIxDPHfPVKHWYUmYJz8WMBmo/hqjb7jy7V2VFUr/JA6eL5J15e5QqUvcjadAgtw+99Rad27iGBWjLHFxx0ygNyMpuwsvjBYYiLvONo+2MBnC20h5c+oIY4gQCdupohQLJpX8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749114423; c=relaxed/simple; bh=gTftk7/nkdK9vp6F7FHEsBQZkeiPm4Dw7fvnIHl0Tno=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eH6NTpMLOM7IfqJiQpNXHohXJB/dlxcgyt9t7NBVYwQlGRyce1P207tXbscmfvT2rbp3FnLdod551XvDDPMdFQ6XKeEkr30ttCc/1IZcjq8YNqAUCpuok/h75N4uGnqbphwNAeVK7xy0gWov8s7ElKKhZfUlNHCPLaY3+sPKHNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SgIuyM5/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SgIuyM5/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749114420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LZzG29XfVtAPAG3t2hijtGsa7i91luWBgzXZdJoVOTU=; b=SgIuyM5/U65IswB1PI1RZ1Aex3E7jLCmQx6ez7MA+i6tK04oqP/hsZg01fVY/xyNf2XRxS hBo0OQ7jcud8Sh0O9/D8MpjrPTti+Jj8g3VCMYnIjDYZGVleIWlJ5l3HntMQnHrEfzFn0N h9lgFkwlO38bllVbidcTolWoMlsKT1o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-iR2hAF0CMtW6gf4BXRjhcA-1; Thu, 05 Jun 2025 05:06:59 -0400 X-MC-Unique: iR2hAF0CMtW6gf4BXRjhcA-1 X-Mimecast-MFC-AGG-ID: iR2hAF0CMtW6gf4BXRjhcA_1749114418 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450d886b9d5so2462785e9.3 for ; Thu, 05 Jun 2025 02:06:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749114418; x=1749719218; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LZzG29XfVtAPAG3t2hijtGsa7i91luWBgzXZdJoVOTU=; b=ExN+HR6+LMVFenA/enXsQlDPeLnmy6guJAl1KLuHH+e5/S8Xc/auzLFXtX2vw+EfIE bxCYeJFZX98rwAzT7DzirSgqpfFs7tZ4ZeryTxkHlNzGqrmu0tWF6it8xN8KlEsHg7a1 wB7aBxAflJcaGSOLoP8uWlPD6MKnoD75Jqd3n8XDGMKx3C5G5qQSo2LRCnvcep42MbL5 XvNnXOUwjDNZEbWSiigxzq+qDjVPhJDRNkXBDmrTWFWod5tpH4/vE6sIe+QolFl7oUj9 xCDCWyoZWDe6u9Ac8CW6x7OQ8AKuezXNle16zRTp7H08S+fgW+gsOFabbw12v4RkglZf EEUg== X-Forwarded-Encrypted: i=1; AJvYcCXxyxQaICrRzsMQheHkULxHalQXf1HMma8HO3WP61Ycsp06CZrwJ3pk+uf6FOn1azeWWnHkOLI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr8d2n7yyj5MxnBFr/OOQ8p2v08yCn2n1rCNx/6oMt87hop7OP taKbKBLRkvI5uBWBHYUOO5rzT6TTtXInQDhUYD6bffIo+2kxQjAK+6//G5914cO6rcuaau8litY Ijc2sc+9uJki0G34vg3LG1e1q4S9Xwx7QF+DEr3ymcISqSC2ttNxvYBQw8w== X-Gm-Gg: ASbGncscNIOOlJBWrdVpTw6TK6x1A4PNIzJ5i5OXSjcwE0EPZRxZXaOmyblbKGYssuE 5QHkYlQJwbL1YWLeHPuJ2Di1jI8D+nj5fFsqbWvW5wjvlYjLz7BrZyBnNSIX+xCQPsvqZHpZN2O vuw4BFqYqK6A5TX4nXUAGw78ECcK7LwOsg5X+E/B+1YHhyiGH9iJj9frDsc7wkJWhBk2Dau14Me cZTgrwkbIJNwe6LkDsyV+0U1XyC6oV0pUnuY1yePo2FSqzSRoP3HYYBeghzH9e406MUfcTKc18r mgHJWLpuibVR1YeS/UM= X-Received: by 2002:a05:600c:8b5c:b0:450:cc80:e594 with SMTP id 5b1f17b1804b1-451f0f9ec8cmr47390975e9.26.1749114417779; Thu, 05 Jun 2025 02:06:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlrfN/L0KGA9nkVyJ1PtjS5kYtl/CnjHZ8ZUdlVpdeHiEfUCdFyXT/5Q9D9x2ORf/SUTY2kg== X-Received: by 2002:a05:600c:8b5c:b0:450:cc80:e594 with SMTP id 5b1f17b1804b1-451f0f9ec8cmr47390645e9.26.1749114417350; Thu, 05 Jun 2025 02:06:57 -0700 (PDT) Received: from ?IPV6:2a0d:3341:cced:ed10::f39? ([2a0d:3341:cced:ed10::f39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451fb208240sm11589085e9.26.2025.06.05.02.06.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 02:06:56 -0700 (PDT) Message-ID: Date: Thu, 5 Jun 2025 11:06:55 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 5/5] net: dsa: b53: do not touch DLL_IQQD on bcm53115 To: Jonas Gorski , Florian Fainelli Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Vivien Didelot , =?UTF-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250602193953.1010487-1-jonas.gorski@gmail.com> <20250602193953.1010487-6-jonas.gorski@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 6/3/25 8:15 AM, Jonas Gorski wrote: > On Mon, Jun 2, 2025 at 11:40 PM Florian Fainelli > wrote: >> On 6/2/25 12:39, Jonas Gorski wrote: >>> According to OpenMDK, bit 2 of the RGMII register has a different >>> meaning for BCM53115 [1]: >>> >>> "DLL_IQQD 1: In the IDDQ mode, power is down0: Normal function >>> mode" >>> >>> Configuring RGMII delay works without setting this bit, so let's keep it >>> at the default. For other chips, we always set it, so not clearing it >>> is not an issue. >>> >>> One would assume BCM53118 works the same, but OpenMDK is not quite sure >>> what this bit actually means [2]: >>> >>> "BYPASS_IMP_2NS_DEL #1: In the IDDQ mode, power is down#0: Normal >>> function mode1: Bypass dll65_2ns_del IP0: Use >>> dll65_2ns_del IP" >>> >>> So lets keep setting it for now. >>> >>> [1] https://github.com/Broadcom-Network-Switching-Software/OpenMDK/blob/master/cdk/PKG/chip/bcm53115/bcm53115_a0_defs.h#L19871 >>> [2] https://github.com/Broadcom-Network-Switching-Software/OpenMDK/blob/master/cdk/PKG/chip/bcm53118/bcm53118_a0_defs.h#L14392 >>> >>> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch") >>> Signed-off-by: Jonas Gorski >>> --- >>> v1 -> v2: >>> * new patch >>> >>> drivers/net/dsa/b53/b53_common.c | 8 +++++--- >>> 1 file changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c >>> index be4493b769f4..862bdccb7439 100644 >>> --- a/drivers/net/dsa/b53/b53_common.c >>> +++ b/drivers/net/dsa/b53/b53_common.c >>> @@ -1354,8 +1354,7 @@ static void b53_adjust_531x5_rgmii(struct dsa_switch *ds, int port, >>> * tx_clk aligned timing (restoring to reset defaults) >>> */ >>> b53_read8(dev, B53_CTRL_PAGE, off, &rgmii_ctrl); >>> - rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC | >>> - RGMII_CTRL_TIMING_SEL); >>> + rgmii_ctrl &= ~(RGMII_CTRL_DLL_RXC | RGMII_CTRL_DLL_TXC); >> >> Are not we missing a: >> >> if (dev->chip_id != BCM53115_DEVICE_ID) >> rgmii_ctrl &= ~RGMII_CTRL_TIMING_SEL; >> >> here to be strictly identical before/after? > > We could add it for symmetry, but it would be purely decorational. We > unconditionally set this bit again later, so clearing it before has no > actual effect, which is why I didn't add it. Makes sense, and the code in this patch is IMHO more readable. /P