From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A543C433F5 for ; Fri, 1 Apr 2022 09:26:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243593AbiDAJ1u (ORCPT ); Fri, 1 Apr 2022 05:27:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344544AbiDAJ1t (ORCPT ); Fri, 1 Apr 2022 05:27:49 -0400 Received: from mx1.cqplus1.com (unknown [113.204.237.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E85F4101F14 for ; Fri, 1 Apr 2022 02:25:51 -0700 (PDT) X-MailGates: (flag:1,DYNAMIC,RELAY,NOHOST,LAN:PASS)(compute_score:DELIVE R,40,3) Received: from 172.27.96.203 by mx1.cqplus1.com with MailGates ESMTP Server V5.0(1193:1:AUTH_RELAY) (envelope-from ); Fri, 01 Apr 2022 17:18:32 +0800 (CST) Received: from CQEXMAIL01.cqplus1.com (172.27.96.203) by CQEXMAIL01.cqplus1.com (172.27.96.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 1 Apr 2022 17:19:31 +0800 Received: from CQEXMAIL01.cqplus1.com ([::1]) by CQEXMAIL01.cqplus1.com ([::1]) with mapi id 15.01.2375.018; Fri, 1 Apr 2022 17:19:31 +0800 From: =?utf-8?B?cWluamlhblvopoPlgaVd?= To: Krzysztof Kozlowski CC: "robh+dt@kernel.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: RE: [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Thread-Topic: [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Thread-Index: AQHYRNqEmfEToMF3qkaI4FVvqF6nN6zZafcAgAFYO/A= Date: Fri, 1 Apr 2022 09:19:31 +0000 Message-ID: References: <84d1e5b6-caa5-cf98-a4b2-2f1ca738b795@linaro.org> In-Reply-To: <84d1e5b6-caa5-cf98-a4b2-2f1ca738b795@linaro.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.110.18] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org PiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2R0LWJpbmRpbmdzL2Nsb2NrL3NwLXNwNzAyMS5oIGIv aW5jbHVkZS9kdC1iaW5kaW5ncy9jbG9jay9zcC1zcDcwMjEuaA0KPiA+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0DQo+ID4gaW5kZXggMDAwMDAwMDAwLi40NWRhYzZkZTgNCj4gPiAtLS0gL2Rldi9udWxs DQo+ID4gKysrIGIvaW5jbHVkZS9kdC1iaW5kaW5ncy9jbG9jay9zcC1zcDcwMjEuaA0KPiA+IEBA IC0wLDAgKzEsMTEyIEBADQo+ID4gKy8qIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIu MC1vbmx5IE9SIEJTRC0yLUNsYXVzZSkgKi8NCj4gPiArLyoNCj4gPiArICogQ29weXJpZ2h0IChD KSBTdW5wbHVzIFRlY2hub2xvZ3kgQ28uLCBMdGQuDQo+ID4gKyAqICAgICAgIEFsbCByaWdodHMg cmVzZXJ2ZWQuDQo+ID4gKyAqLw0KPiA+ICsjaWZuZGVmIF9EVF9CSU5ESU5HU19DTE9DS19TVU5Q TFVTX1NQNzAyMV9IDQo+ID4gKyNkZWZpbmUgX0RUX0JJTkRJTkdTX0NMT0NLX1NVTlBMVVNfU1A3 MDIxX0gNCj4gPiArDQo+ID4gKyNkZWZpbmUgWFRBTAkJCTI3MDAwMDAwDQo+ID4gKw0KPiA+ICsv KiBwbGxzICovDQo+ID4gKyNkZWZpbmUgUExMX0EJCQkwDQo+ID4gKyNkZWZpbmUgUExMX0UJCQkx DQo+ID4gKyNkZWZpbmUgUExMX0VfMlA1CQkyDQo+ID4gKyNkZWZpbmUgUExMX0VfMjUJCTMNCj4g PiArI2RlZmluZSBQTExfRV8xMTJQNQkJNA0KPiA+ICsjZGVmaW5lIFBMTF9GCQkJNQ0KPiA+ICsj ZGVmaW5lIFBMTF9UVgkJCTYNCj4gPiArI2RlZmluZSBQTExfVFZfQQkJNw0KPiA+ICsjZGVmaW5l IFBMTF9TWVMJCQk4DQo+ID4gKw0KPiA+ICsvKiBnYXRlczogbW9fY2xrZW4wIH4gbW9fY2xrZW45 ICovDQo+ID4gKyNkZWZpbmUgQ0xLX1NZU1RFTQkJMHgxMA0KPiA+ICsjZGVmaW5lIENMS19SVEMJ CQkweDEyDQo+IA0KPiBZQU1MIGxvb2tzIG9rLCBidXQgaGVyZSBjb21tZW50IGZyb20gQXJuZCBh bHNvIGFwcGxpZXMuIFRoZXNlIHNob3VsZCBiZQ0KPiByZWd1bGFyIGRlY2ltYWwgbnVtYmVycyBp bmNyZW1lbnRlZCBieSBvbmUuDQo+IA0KPiBCZXN0IHJlZ2FyZHMsDQo+IEtyenlzenRvZg0KDQpZ ZXMsIHNhbWUgYXMgcmVzZXQgZHJpdmVyLCB0aGVzZSBkZWZpbmVzIGFsc28gbWFwcGluZyB0aGUg aGFyZHdhcmUuDQpCdXQgZGlmZmVyZW50IGZyb20gcmVzZXQgZHJpdmVyLCBjbGsgZHJpdmVyIGFs c28gdXNlZCB0aGVzZSBkZWZpbmVzLg0KSWYgSSByZW1vdmVkIHRoaXMgZGVmaW5lcywgSSAgbXVz dCB3cml0ZSB0aGUgcHJvcGVyIGhhcmR3YXJlIG51bWJlciB0d2ljZSBpbiBkdCAmIGRyaXZlci4N Ckl0J3MgbWVhbmluZ2xlc3MgJiBoYXJkIHRvIGNoZWNrLg0KDQoNCg0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61AEFC433EF for ; Fri, 1 Apr 2022 09:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZXMEj9C3PnD8YYx7mWs76Rnkad4ewq0KNEWnVVCfSbY=; b=JdzmtZs58eL4+k ZE0Kll0iBzMg6kXLHuddqO9AlvfRaIZOEQ4QGLE/VHTEloMzkC0Xxc65y9bRMDo9nDQ6rHAY/nSnf 2/FE63ZKa97AjvUVRw/H0paTr2ZOu33PCrNvLa22lLlRQBWVrXbpnaSuXf/G9ZafXI2GMdSG1s6Ty fE83yZMV7+eh3l2h1vCasPK/eHaI7zy1WCktvrPiM9W+EsTMe/34Koi4Kgr0E30JJy3YiwawZ3sSS 1GH3cUBjGb4QYUtkPbl04eqtJbaiGO3nNJcIPpyDkfcGUvcIUpCSlrb4xWBxFE+vskJxbpuXUZfV+ 1o+JreR5iR7O9wLfZayQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naDWg-0051IM-7F; Fri, 01 Apr 2022 09:25:02 +0000 Received: from mx1.cqplus1.com ([113.204.237.245]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naDWb-0051FQ-MH for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 09:24:59 +0000 X-MailGates: (flag:1,DYNAMIC,RELAY,NOHOST,LAN:PASS)(compute_score:DELIVE R,40,3) Received: from 172.27.96.203 by mx1.cqplus1.com with MailGates ESMTP Server V5.0(1193:1:AUTH_RELAY) (envelope-from ); Fri, 01 Apr 2022 17:18:32 +0800 (CST) Received: from CQEXMAIL01.cqplus1.com (172.27.96.203) by CQEXMAIL01.cqplus1.com (172.27.96.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Fri, 1 Apr 2022 17:19:31 +0800 Received: from CQEXMAIL01.cqplus1.com ([::1]) by CQEXMAIL01.cqplus1.com ([::1]) with mapi id 15.01.2375.018; Fri, 1 Apr 2022 17:19:31 +0800 From: =?utf-8?B?cWluamlhblvopoPlgaVd?= To: Krzysztof Kozlowski CC: "robh+dt@kernel.org" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "tglx@linutronix.de" , "maz@kernel.org" , "p.zabel@pengutronix.de" , "linux@armlinux.org.uk" , "arnd@arndb.de" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" Subject: RE: [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Thread-Topic: [PATCH v12 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Thread-Index: AQHYRNqEmfEToMF3qkaI4FVvqF6nN6zZafcAgAFYO/A= Date: Fri, 1 Apr 2022 09:19:31 +0000 Message-ID: References: <84d1e5b6-caa5-cf98-a4b2-2f1ca738b795@linaro.org> In-Reply-To: <84d1e5b6-caa5-cf98-a4b2-2f1ca738b795@linaro.org> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.110.18] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_022458_112902_EEDCEC17 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > diff --git a/include/dt-bindings/clock/sp-sp7021.h b/include/dt-bindings/clock/sp-sp7021.h > > new file mode 100644 > > index 000000000..45dac6de8 > > --- /dev/null > > +++ b/include/dt-bindings/clock/sp-sp7021.h > > @@ -0,0 +1,112 @@ > > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > > +/* > > + * Copyright (C) Sunplus Technology Co., Ltd. > > + * All rights reserved. > > + */ > > +#ifndef _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > +#define _DT_BINDINGS_CLOCK_SUNPLUS_SP7021_H > > + > > +#define XTAL 27000000 > > + > > +/* plls */ > > +#define PLL_A 0 > > +#define PLL_E 1 > > +#define PLL_E_2P5 2 > > +#define PLL_E_25 3 > > +#define PLL_E_112P5 4 > > +#define PLL_F 5 > > +#define PLL_TV 6 > > +#define PLL_TV_A 7 > > +#define PLL_SYS 8 > > + > > +/* gates: mo_clken0 ~ mo_clken9 */ > > +#define CLK_SYSTEM 0x10 > > +#define CLK_RTC 0x12 > > YAML looks ok, but here comment from Arnd also applies. These should be > regular decimal numbers incremented by one. > > Best regards, > Krzysztof Yes, same as reset driver, these defines also mapping the hardware. But different from reset driver, clk driver also used these defines. If I removed this defines, I must write the proper hardware number twice in dt & driver. It's meaningless & hard to check. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel