From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] gitweb.cgi: Customization
Date: Wed, 02 Aug 2006 19:34:29 +0200 [thread overview]
Message-ID: <eaqnm8$gni$1@sea.gmane.org> (raw)
In-Reply-To: 20060802165333.GA22726@coredump.intra.peff.net
Jeff King wrote:
> On Wed, Aug 02, 2006 at 11:23:22AM -0500, Jon Loeliger wrote:
>
>> With this "params in config.mk" approach, I have to
>> run it multiple times, once for each web server I run.
>>
>> I _really_ would prefer an "include from ." feature
>> where I can place the specific gitweb_config.pm parts
>> in the same directory where gitweb.{pl,cgi} is installed.
>
> Why don't we have sensible compile-time defaults that can be overridden
> by a run-time config file like every other sane program? For those who
> are opposed to the run-time config, they can simply not have a config
> file.
>
> See the (completely untested) patch below. Obviously the config file
> name has to be set at build time. However, since it is interpolated by
> perl, you can do clever things like:
> /etc/gitweb/$ENV{MY_VIRTUAL_HOST}.pl
Besides, we can use _relative_ paths.
I like this proposal the best.
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-08-02 17:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 21:19 [PATCH] gitweb.cgi: Customization Luben Tuikov
2006-08-01 22:15 ` Junio C Hamano
2006-08-01 22:53 ` Luben Tuikov
2006-08-01 23:54 ` Junio C Hamano
2006-08-02 2:01 ` Luben Tuikov
2006-08-02 2:13 ` Martin Langhoff
2006-08-02 7:45 ` Junio C Hamano
2006-08-02 7:59 ` Martin Langhoff
2006-08-02 15:53 ` Matthias Lederhofer
2006-08-03 6:58 ` Martin Waitz
2006-08-03 16:24 ` Jeff King
2006-08-02 7:09 ` Matthias Lederhofer
2006-08-02 8:54 ` Matthias Lederhofer
2006-08-02 9:31 ` Martin Langhoff
2006-08-02 12:55 ` Matthias Lederhofer
2006-08-02 16:23 ` Jon Loeliger
2006-08-02 16:53 ` Jeff King
2006-08-02 17:13 ` Matthias Lederhofer
2006-08-02 17:34 ` Jakub Narebski [this message]
2006-08-02 17:43 ` Junio C Hamano
2006-08-02 20:30 ` Luben Tuikov
2006-08-02 19:40 ` Matthias Lederhofer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='eaqnm8$gni$1@sea.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.