Re: How to deal with incorrect firmware image in phosphor-bmc-code-mgmt?

[Adriana Kobylak <anoo@linux.ibm.com>]

On 2019-05-08 03:56, Lei YU wrote:
> On Wed, May 8, 2019 at 4:37 PM Troy Lee <leetroy@gmail.com> wrote:
>> 
>> Greeting,
>> 
>> With the method xyz.openbmc_project.Common.TFTP.DownloadViaTFTP,
>> does OpenBMC have a way to know that TFTP download status(completed)
>> and the downloaded image is incorrect?

The challenge is the time that takes to perform the TFTP transfer. A
transfer from a remote server can take minutes to complete, which would
cause timeouts on the REST server. If we can solve this, then we could
return a download status.
See issue for reference : https://github.com/openbmc/openbmc/issues/1691

>> 
>> It would not be a problem if the image is correct, since we'll have an
>> InterfacesAdded signal.
>> But if the image is incorrect (untar failure/signature mismatch),
>> we'll only have an error log entry generated.
> 
> What is the expected behavior if the image is incorrect?
> 
>> Or if the image has the same version id with currently running image,
>> the behavior will become unexpected.
> 
> I met this problem before, and I think we may discuss the expected 
> behavior,
> and fix this case.
> 

The current behavior is that a new Version D-Bus object is not created
because one already exists. If this is unexpected, what should the 
expected
behavior be?

>> 
>> Because we have another service wants to integrate with firmware
>> update service, having a way to confirm the image file is nice to
>> have.
>> 
>> Thanks,
>> Troy Lee
>> --
>> Yu-Ting Lee (Troy Lee) <LeeTroy@gmail.com>