From: Marek Vasut <marex@nabladev.com>
To: "Börge Strümpfel" <bstruempfel@data-modul.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/bridge: lt9211: Add drive-strength-microamp DT property
Date: Wed, 13 May 2026 13:33:01 +0200 [thread overview]
Message-ID: <eb0b8aa2-a728-4e66-80b1-4c7ef37d24dc@nabladev.com> (raw)
In-Reply-To: <agQ4pVGFEMGaMqgc@DATAMODULBOERGELINUX>
On 5/13/26 11:02 AM, Börge Strümpfel wrote:
[...]
>>> + ctx->lvds_hsdrv_isel = 8; /* default: 25 uA */
>>> + ret = of_property_read_u32(dev->of_node, "drive-strength-microamp",
>>> + µamp);
>>
>> if ret != 0 , then what happens here ?
>>
>
> if ret != 0, we will keep the default value of 8 (corresponding to 25 uA
> as written above), which is the behavior that the driver had previously.
>
> According to the documentation, of_property_read_u32() will return 0 on
> success, -EINVAL if the property does not exist, -ENODATA if property
> does not have a value, and -EOVERFLOW if the property data isn't large
> enough. I think we only would need to give a warning or similar if the
> -ENODATA or -EOVERFLOW cases. However, I personally do not think that is
> necessary, as the usage is specified unambiguously in the devicetree
> bindings.
Users can pass in malformed DT, so a warning is a good idea. Thanks.
prev parent reply other threads:[~2026-05-13 11:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 16:46 [PATCH 0/2] drm/bridge: lt9211: Add drive-strength-microamp DT property Boerge Struempfel
2026-05-12 16:46 ` [PATCH 1/2] dt-bindings: display/bridge: lt9211: Add drive-strength-microamp property Boerge Struempfel
2026-05-12 17:05 ` Conor Dooley
2026-05-13 23:26 ` sashiko-bot
2026-05-12 16:46 ` [PATCH 2/2] drm/bridge: lt9211: Add drive-strength-microamp DT property Boerge Struempfel
2026-05-12 18:29 ` Marek Vasut
2026-05-13 9:02 ` Börge Strümpfel
2026-05-13 11:33 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0b8aa2-a728-4e66-80b1-4c7ef37d24dc@nabladev.com \
--to=marex@nabladev.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=bstruempfel@data-modul.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.