From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Narebski Subject: [PATCH 7/9] gitweb: No error messages with unescaped/unprotected user input Date: Sat, 05 Aug 2006 13:15:24 +0200 Organization: At home Message-ID: References: <200608050036.06490.jnareb@gmail.com> <200608050038.20534.jnareb@gmail.com> <7vu04sghr0.fsf@assigned-by-dhcp.cox.net> <44d47813.36251c31.2553.3cf7@mx.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit X-From: git-owner@vger.kernel.org Sat Aug 05 13:25:16 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G9KHK-0003vD-0D for gcvg-git@gmane.org; Sat, 05 Aug 2006 13:25:14 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932274AbWHELZK (ORCPT ); Sat, 5 Aug 2006 07:25:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932359AbWHELZK (ORCPT ); Sat, 5 Aug 2006 07:25:10 -0400 Received: from main.gmane.org ([80.91.229.2]:43484 "EHLO ciao.gmane.org") by vger.kernel.org with ESMTP id S932274AbWHELZI (ORCPT ); Sat, 5 Aug 2006 07:25:08 -0400 Received: from root by ciao.gmane.org with local (Exim 4.43) id 1G9KH8-0003tg-1c for git@vger.kernel.org; Sat, 05 Aug 2006 13:25:02 +0200 Received: from host-81-190-31-92.torun.mm.pl ([81.190.31.92]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Aug 2006 13:25:02 +0200 Received: from jnareb by host-81-190-31-92.torun.mm.pl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 05 Aug 2006 13:25:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: git@vger.kernel.org X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: host-81-190-31-92.torun.mm.pl Mail-Copies-To: jnareb@gmail.com User-Agent: KNode/0.10.2 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Signed-off-by: Jakub Narebski --- Probably some error messages with unescaped user input are left... gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index d8ba016..013bfe7 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1265,7 +1265,7 @@ ## actions sub git_project_list { my $order = $cgi->param('o'); if (defined $order && $order !~ m/project|descr|owner|age/) { - die_error(undef, "Invalid order parameter '$order'"); + die_error(undef, "Unknown order parameter"); } my @list = git_read_projects(); -- 1.4.1.1