From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chia-I Wu <olvaffe@gmail.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: gpu: mali-valhall-csf: add asn-hash
Date: Fri, 29 Aug 2025 15:42:51 +0200 [thread overview]
Message-ID: <eb436a88-4ef2-4634-83a2-690eae1fced9@kernel.org> (raw)
In-Reply-To: <20250828201806.3541261-2-olvaffe@gmail.com>
On 28/08/2025 22:18, Chia-I Wu wrote:
> The values are written to ASN_HASH[0..2] registers. The property is
> called "l2-hash-values" in the downstream driver.
We don't add properties based on downstream drivers. Please provide some
sort of rationale, including explanation why this is not SoC/compatible
specific.
>
> Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
> ---
> .../devicetree/bindings/gpu/arm,mali-valhall-csf.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> index a5b4e00217587..258bcba66d1d1 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml
> @@ -85,6 +85,14 @@ properties:
>
> dma-coherent: true
>
> + asn-hash:
Missing vendor prefix or please explain which common schema has it
already defined.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-29 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 20:18 [PATCH 0/2] drm/panthor: add custom ASN hash support Chia-I Wu
2025-08-28 20:18 ` [PATCH 1/2] dt-bindings: gpu: mali-valhall-csf: add asn-hash Chia-I Wu
2025-08-29 8:32 ` Boris Brezillon
2025-08-29 13:42 ` Krzysztof Kozlowski [this message]
2025-08-28 20:18 ` [PATCH 2/2] drm/panthor: add asn-hash support Chia-I Wu
2025-08-29 13:41 ` Steven Price
2025-08-29 13:40 ` [PATCH 0/2] drm/panthor: add custom ASN hash support Steven Price
2025-08-29 21:50 ` Chia-I Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb436a88-4ef2-4634-83a2-690eae1fced9@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=olvaffe@gmail.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.