From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D92C3F2CE for ; Wed, 4 Mar 2020 23:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09BB22084E for ; Wed, 4 Mar 2020 23:44:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="aBTcmqHs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388528AbgCDXoB (ORCPT ); Wed, 4 Mar 2020 18:44:01 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:27563 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388389AbgCDXoA (ORCPT ); Wed, 4 Mar 2020 18:44:00 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1583365440; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=7eUUFwVHuI/U/XukJuffOaTXNP+eD9Qwzgt9BBFqIqI=; b=aBTcmqHs0rt13eQFLioz7CHCIcectXATc0/7L7VGEu1LxL5ufp3J9iwByM30tlb9wh1j9MNt HCApQwxxxvqj6utKGt2VQZFvixvSUnt7xJ1RBI0WyCUWCc0KBQ5YkFcX1ywV3GxJBnbHx8E7 CAE3a2gBx9yyCMw1RD5hqRLI0bY= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e603d3f.7fcd36a07570-smtp-out-n04; Wed, 04 Mar 2020 23:43:59 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id C786BC4479F; Wed, 4 Mar 2020 23:43:58 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: subashab) by smtp.codeaurora.org (Postfix) with ESMTPSA id 49212C43383; Wed, 4 Mar 2020 23:43:58 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 04 Mar 2020 16:43:58 -0700 From: subashab@codeaurora.org To: Taehee Yoo Cc: davem@davemloft.net, kuba@kernel.org, stranche@codeaurora.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 0/3] net: rmnet: several code cleanup for rmnet module In-Reply-To: <20200304232415.12205-1-ap420073@gmail.com> References: <20200304232415.12205-1-ap420073@gmail.com> Message-ID: X-Sender: subashab@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020-03-04 16:24, Taehee Yoo wrote: > This patchset is to cleanup rmnet module code. > > 1. The first patch is to add module alias > rmnet module can not be loaded automatically because there is no > alias name. > > 2. The second patch is to add extack error message code. > When rmnet netlink command fails, it doesn't print any error message. > So, users couldn't know the exact reason. > In order to tell the exact reason to the user, the extack error message > is used in this patch. > > 3. The third patch is to use GFP_KERNEL instead of GFP_ATOMIC. > In the sleepable context, GFP_KERNEL can be used. > So, in this patch, GFP_KERNEL is used instead of GFP_ATOMIC. > > Change log: > - v1->v2: change error message in the second patch. > > Taehee Yoo (3): > net: rmnet: add missing module alias > net: rmnet: print error message when command fails > net: rmnet: use GFP_KERNEL instead of GFP_ATOMIC > > .../ethernet/qualcomm/rmnet/rmnet_config.c | 36 ++++++++++++------- > .../net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 11 +++--- > .../net/ethernet/qualcomm/rmnet/rmnet_vnd.h | 3 +- > 3 files changed, 32 insertions(+), 18 deletions(-) For the series: Acked-by: Subash Abhinov Kasiviswanathan