From: Shuah Khan <skhan@linuxfoundation.org>
To: Steven Rostedt <rostedt@goodmis.org>, Cao Ruichuang <create0818@163.com>
Cc: mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
shuah@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: Quote check_requires comparisons
Date: Wed, 8 Apr 2026 15:22:37 -0600 [thread overview]
Message-ID: <eb5022d6-a09b-4521-b847-a9a5d66c144a@linuxfoundation.org> (raw)
In-Reply-To: <20260408171831.69520c50@gandalf.local.home>
On 4/8/26 15:18, Steven Rostedt wrote:
> On Wed, 8 Apr 2026 12:32:12 +0800
> Cao Ruichuang <create0818@163.com> wrote:
>
>> check_requires() compares requirement strings that can contain shell
>> pattern characters such as '[' and ']'. Under /bin/sh, the unquoted
>> test expressions can emit 'unexpected operator' warnings while parsing
>> README-backed requirements.
>>
>> Quote the relevant comparisons and path checks so the helper handles
>> those patterns without spurious shell warnings.
>>
>> Validated by rerunning fprobe_syntax_errors.tc and confirming the
>> previous '/bin/sh: unexpected operator' lines disappear from the
>> detailed ftracetest log.
>>
>> Signed-off-by: Cao Ruichuang <create0818@163.com>
>
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
> Shuah,
>
> Care to take this through your tree?
>
> -- Steve
Yes - I can take this for the merge window.
thanks,
-- Shuah
prev parent reply other threads:[~2026-04-08 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 4:32 [PATCH] selftests/ftrace: Quote check_requires comparisons Cao Ruichuang
2026-04-08 21:18 ` Steven Rostedt
2026-04-08 21:22 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5022d6-a09b-4521-b847-a9a5d66c144a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=create0818@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.