From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73999CD342E for ; Thu, 21 Sep 2023 07:54:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b+Es7bLTjHA/ZvU/bSmLxTmqe4q4U8Nv8+AnCMRFLDg=; b=IC5IWD4C3hLtJl ds61NxUsBVnHkxHYIwxmzId4SaRb5rfcSfASdTuu/NYnYuWo/zJ/+AgrAiXd4vYH4niIG2QjCq0eA dDMGfobyhR/QCUQT+jCW6Oo9brmA2RbeUEfX5lrSgnHVkPFrEp9q+BmOARc9rJbirnT/Ks4BIZ2AS Ix1ju8m6p9LIhCuQOjRM+RnokTgnUJ1QrhLPC6ej0706KuxFe8bcCwUqCjJIuJlQ43tXDxHkYmwEW YPoqZM1uzclVKAa1gB4O7kGGYxjpPSWIDfMRsqnbKn1dfhF5pNx9YTabkHQfTiO5sohEVdoYUM+BU qg+fMU3LSA5MlbYiwzaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjEWL-005PVG-17; Thu, 21 Sep 2023 07:54:45 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjEWG-005PUg-3B; Thu, 21 Sep 2023 07:54:42 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B2AC466072B4; Thu, 21 Sep 2023 08:54:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695282879; bh=mxa+TQ9McxKXTWkBAdGpIkOnbJ9KXBTRLFoX7g4x3U4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aOx3li4jlzpntW7uZPRu6InVLWX1CEWeAd6xYNw5Cu5ySnF3GxElIKu/WXg6KjDcF SpIv2sTg+zYMgzBZADkIltCPzyj40Z42PGN+SI6+iQ0rpbvTjH5vJ5cuRS63vGk3Xp jis6cjJteeDzGPYtOGuSNWvAn8Dc0O4ED2WlXBRcM5US63j09hwqiWLSmr13atHZI2 hWnvBochrfDGcR3KhXDJku8+GR8uaPGigvxWIVES9sMIU3F7KyQ9PJMvX0xNhd6CPy IhWVhKQd26cnucXe/AtKomFmpxc7ubr7kgVpAzJiqVCzHJkmyVSyURn6FA3LXK9rrw leS8AqnHoNEAQ== Message-ID: Date: Thu, 21 Sep 2023 09:54:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 4/4] thermal/drivers/mediatek/lvts_thermal: add mt7988 support Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org References: <20230920175001.47563-1-linux@fw-web.de> <20230920175001.47563-5-linux@fw-web.de> From: AngeloGioacchino Del Regno In-Reply-To: <20230920175001.47563-5-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230921_005441_303386_DA5A44B2 X-CRM114-Status: GOOD ( 27.73 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Daniel Lezcano , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Amit Kucheria , Conor Dooley , linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Zhang Rui , linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 20/09/23 19:50, Frank Wunderlich ha scritto: > From: Frank Wunderlich > > Add Support for Mediatek Filogic 880/MT7988 LVTS. > > Signed-off-by: Frank Wunderlich > --- > v2: > - use 105°C for hw shutdown > - move constants to binding file > - change coeff.a to temp_factor and coeff.b to temp_offset > - change to lvts to lvts-ap (Application Processor) > - drop comments about efuse offsets > - change comment of mt8195 to be similar to mt7988 > --- > drivers/thermal/mediatek/lvts_thermal.c | 46 +++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c > index c2669f405a94..8fd1dc5adb16 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -82,6 +82,8 @@ > #define LVTS_GOLDEN_TEMP_DEFAULT 50 > #define LVTS_COEFF_A_MT8195 -250460 > #define LVTS_COEFF_B_MT8195 250460 > +#define LVTS_COEFF_A_MT7988 -204650 > +#define LVTS_COEFF_B_MT7988 204650 > > #define LVTS_MSR_IMMEDIATE_MODE 0 > #define LVTS_MSR_FILTERED_MODE 1 > @@ -89,6 +91,7 @@ > #define LVTS_MSR_READ_TIMEOUT_US 400 > #define LVTS_MSR_READ_WAIT_US (LVTS_MSR_READ_TIMEOUT_US / 2) > > +#define LVTS_HW_SHUTDOWN_MT7988 105000 I would simply reuse the definition of LVTS_HW_SHUTDOWN_MT8195.... > #define LVTS_HW_SHUTDOWN_MT8195 105000 > > #define LVTS_MINIMUM_THRESHOLD 20000 > @@ -1269,6 +1272,41 @@ static int lvts_remove(struct platform_device *pdev) > return 0; > } > > +/* > + * LVTS MT7988 > + */ > + Please remove this big comment block, that's not needed. > +static const struct lvts_ctrl_data mt7988_lvts_ap_data_ctrl[] = { > + { > + .cal_offset = { 0x00, 0x04, 0x08, 0x0c }, //918,91C,920,924 This 918,91c,etc comment is not necessary > + .lvts_sensor = { > + { .dt_id = MT7988_CPU_0 }, // CPU 0,1 If you want to retain those comments, you shall use the right style. { .dt_id = MT7988_CPU_0 }, /* CPU 0,1 */ { .. } /* CPU 2,3 */ { .. } /* Internal 2.5G PHY 1 */ etc > + { .dt_id = MT7988_CPU_1 }, // CPU 2,3 > + { .dt_id = MT7988_ETH2P5G_0 }, // internal 2.5G Phy 1 > + { .dt_id = MT7988_ETH2P5G_1 } // internal 2.5G Phy 2 > + }, > + .num_lvts_sensor = 4, > + .offset = 0x0, > + .hw_tshut_temp = LVTS_HW_SHUTDOWN_MT7988, > + }, > + { > + .cal_offset = { 0x14, 0x18, 0x1c, 0x20 }, //92C,930,934,938 comment not needed > + .lvts_sensor = { > + { .dt_id = MT7988_TOPS_0}, // TOPS > + { .dt_id = MT7988_TOPS_1}, // TOPS The dt_id definition already says "TOPS", this comment is not needed. > + { .dt_id = MT7988_ETHWARP_0}, // WED 1 > + { .dt_id = MT7988_ETHWARP_1} // WED 2 Same comment about the format; /* WED 1 */ > + }, > + .num_lvts_sensor = 4, > + .offset = 0x100, > + .hw_tshut_temp = LVTS_HW_SHUTDOWN_MT7988, > + } > +}; > + > +/* > + * LVTS MT8195 > + */ Please also remove this big comment block, it's not needed. Apart from that, this patch looks good; v3 will be the golden one :-) Cheers, Angelo > + > static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = { > { > .cal_offset = { 0x04, 0x07 }, > @@ -1348,6 +1386,13 @@ static const struct lvts_ctrl_data mt8195_lvts_ap_data_ctrl[] = { > } > }; > > +static const struct lvts_data mt7988_lvts_ap_data = { > + .lvts_ctrl = mt7988_lvts_ap_data_ctrl, > + .num_lvts_ctrl = ARRAY_SIZE(mt7988_lvts_ap_data_ctrl), > + .temp_factor = LVTS_COEFF_A_MT7988, > + .temp_offset = LVTS_COEFF_B_MT7988, > +}; > + > static const struct lvts_data mt8195_lvts_mcu_data = { > .lvts_ctrl = mt8195_lvts_mcu_data_ctrl, > .num_lvts_ctrl = ARRAY_SIZE(mt8195_lvts_mcu_data_ctrl), > @@ -1363,6 +1408,7 @@ static const struct lvts_data mt8195_lvts_ap_data = { > }; > > static const struct of_device_id lvts_of_match[] = { > + { .compatible = "mediatek,mt7988-lvts-ap", .data = &mt7988_lvts_ap_data }, > { .compatible = "mediatek,mt8195-lvts-mcu", .data = &mt8195_lvts_mcu_data }, > { .compatible = "mediatek,mt8195-lvts-ap", .data = &mt8195_lvts_ap_data }, > {}, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066E2E7D0A4 for ; Thu, 21 Sep 2023 18:14:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229540AbjIUSOD (ORCPT ); Thu, 21 Sep 2023 14:14:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230150AbjIUSNg (ORCPT ); Thu, 21 Sep 2023 14:13:36 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A84B483E6; Thu, 21 Sep 2023 10:23:15 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B2AC466072B4; Thu, 21 Sep 2023 08:54:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695282879; bh=mxa+TQ9McxKXTWkBAdGpIkOnbJ9KXBTRLFoX7g4x3U4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aOx3li4jlzpntW7uZPRu6InVLWX1CEWeAd6xYNw5Cu5ySnF3GxElIKu/WXg6KjDcF SpIv2sTg+zYMgzBZADkIltCPzyj40Z42PGN+SI6+iQ0rpbvTjH5vJ5cuRS63vGk3Xp jis6cjJteeDzGPYtOGuSNWvAn8Dc0O4ED2WlXBRcM5US63j09hwqiWLSmr13atHZI2 hWnvBochrfDGcR3KhXDJku8+GR8uaPGigvxWIVES9sMIU3F7KyQ9PJMvX0xNhd6CPy IhWVhKQd26cnucXe/AtKomFmpxc7ubr7kgVpAzJiqVCzHJkmyVSyURn6FA3LXK9rrw leS8AqnHoNEAQ== Message-ID: Date: Thu, 21 Sep 2023 09:54:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 4/4] thermal/drivers/mediatek/lvts_thermal: add mt7988 support Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230920175001.47563-1-linux@fw-web.de> <20230920175001.47563-5-linux@fw-web.de> From: AngeloGioacchino Del Regno In-Reply-To: <20230920175001.47563-5-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Il 20/09/23 19:50, Frank Wunderlich ha scritto: > From: Frank Wunderlich > > Add Support for Mediatek Filogic 880/MT7988 LVTS. > > Signed-off-by: Frank Wunderlich > --- > v2: > - use 105°C for hw shutdown > - move constants to binding file > - change coeff.a to temp_factor and coeff.b to temp_offset > - change to lvts to lvts-ap (Application Processor) > - drop comments about efuse offsets > - change comment of mt8195 to be similar to mt7988 > --- > drivers/thermal/mediatek/lvts_thermal.c | 46 +++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c > index c2669f405a94..8fd1dc5adb16 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -82,6 +82,8 @@ > #define LVTS_GOLDEN_TEMP_DEFAULT 50 > #define LVTS_COEFF_A_MT8195 -250460 > #define LVTS_COEFF_B_MT8195 250460 > +#define LVTS_COEFF_A_MT7988 -204650 > +#define LVTS_COEFF_B_MT7988 204650 > > #define LVTS_MSR_IMMEDIATE_MODE 0 > #define LVTS_MSR_FILTERED_MODE 1 > @@ -89,6 +91,7 @@ > #define LVTS_MSR_READ_TIMEOUT_US 400 > #define LVTS_MSR_READ_WAIT_US (LVTS_MSR_READ_TIMEOUT_US / 2) > > +#define LVTS_HW_SHUTDOWN_MT7988 105000 I would simply reuse the definition of LVTS_HW_SHUTDOWN_MT8195.... > #define LVTS_HW_SHUTDOWN_MT8195 105000 > > #define LVTS_MINIMUM_THRESHOLD 20000 > @@ -1269,6 +1272,41 @@ static int lvts_remove(struct platform_device *pdev) > return 0; > } > > +/* > + * LVTS MT7988 > + */ > + Please remove this big comment block, that's not needed. > +static const struct lvts_ctrl_data mt7988_lvts_ap_data_ctrl[] = { > + { > + .cal_offset = { 0x00, 0x04, 0x08, 0x0c }, //918,91C,920,924 This 918,91c,etc comment is not necessary > + .lvts_sensor = { > + { .dt_id = MT7988_CPU_0 }, // CPU 0,1 If you want to retain those comments, you shall use the right style. { .dt_id = MT7988_CPU_0 }, /* CPU 0,1 */ { .. } /* CPU 2,3 */ { .. } /* Internal 2.5G PHY 1 */ etc > + { .dt_id = MT7988_CPU_1 }, // CPU 2,3 > + { .dt_id = MT7988_ETH2P5G_0 }, // internal 2.5G Phy 1 > + { .dt_id = MT7988_ETH2P5G_1 } // internal 2.5G Phy 2 > + }, > + .num_lvts_sensor = 4, > + .offset = 0x0, > + .hw_tshut_temp = LVTS_HW_SHUTDOWN_MT7988, > + }, > + { > + .cal_offset = { 0x14, 0x18, 0x1c, 0x20 }, //92C,930,934,938 comment not needed > + .lvts_sensor = { > + { .dt_id = MT7988_TOPS_0}, // TOPS > + { .dt_id = MT7988_TOPS_1}, // TOPS The dt_id definition already says "TOPS", this comment is not needed. > + { .dt_id = MT7988_ETHWARP_0}, // WED 1 > + { .dt_id = MT7988_ETHWARP_1} // WED 2 Same comment about the format; /* WED 1 */ > + }, > + .num_lvts_sensor = 4, > + .offset = 0x100, > + .hw_tshut_temp = LVTS_HW_SHUTDOWN_MT7988, > + } > +}; > + > +/* > + * LVTS MT8195 > + */ Please also remove this big comment block, it's not needed. Apart from that, this patch looks good; v3 will be the golden one :-) Cheers, Angelo > + > static const struct lvts_ctrl_data mt8195_lvts_mcu_data_ctrl[] = { > { > .cal_offset = { 0x04, 0x07 }, > @@ -1348,6 +1386,13 @@ static const struct lvts_ctrl_data mt8195_lvts_ap_data_ctrl[] = { > } > }; > > +static const struct lvts_data mt7988_lvts_ap_data = { > + .lvts_ctrl = mt7988_lvts_ap_data_ctrl, > + .num_lvts_ctrl = ARRAY_SIZE(mt7988_lvts_ap_data_ctrl), > + .temp_factor = LVTS_COEFF_A_MT7988, > + .temp_offset = LVTS_COEFF_B_MT7988, > +}; > + > static const struct lvts_data mt8195_lvts_mcu_data = { > .lvts_ctrl = mt8195_lvts_mcu_data_ctrl, > .num_lvts_ctrl = ARRAY_SIZE(mt8195_lvts_mcu_data_ctrl), > @@ -1363,6 +1408,7 @@ static const struct lvts_data mt8195_lvts_ap_data = { > }; > > static const struct of_device_id lvts_of_match[] = { > + { .compatible = "mediatek,mt7988-lvts-ap", .data = &mt7988_lvts_ap_data }, > { .compatible = "mediatek,mt8195-lvts-mcu", .data = &mt8195_lvts_mcu_data }, > { .compatible = "mediatek,mt8195-lvts-ap", .data = &mt8195_lvts_ap_data }, > {}, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A163CD5BD5 for ; Thu, 21 Sep 2023 07:55:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WOlLz434c77sCNKKtVrcpxn0D97iBJnXwxUJ1ygpynA=; b=I5zr6comlKBaoS Vhx7Ucq3EsWUs4/j4Eh4eWfwzMADi7Ahbn457i321Ouw0VrLGoOjhnvWhHt+7KLPmF/+xKQZBG7CX f5KcdSGeaGeecyPpP6GuEjQpxT9r7aP3n9LsoZJNVCYMxVZwkvR/UPVdbr0kH82JyF1drSRK4XkDo JAa3+ffjJR0pqV17OwVs+uHxEM72cCxfHBaUnGOvxUXP9VCCC3ihD4U64JBh2ocwZeUr2lkD0rNQg 27QZF/ngSOn1j7WW60Y0ZTghkERO16kFCSO+2/io0GTalElP+6xqzogHoOmEmHyXYpg12RjbgWiLa nEKmBLQ+ThsPIDL5DZIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qjEWK-005PVA-2q; Thu, 21 Sep 2023 07:54:44 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qjEWG-005PUg-3B; Thu, 21 Sep 2023 07:54:42 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id B2AC466072B4; Thu, 21 Sep 2023 08:54:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695282879; bh=mxa+TQ9McxKXTWkBAdGpIkOnbJ9KXBTRLFoX7g4x3U4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aOx3li4jlzpntW7uZPRu6InVLWX1CEWeAd6xYNw5Cu5ySnF3GxElIKu/WXg6KjDcF SpIv2sTg+zYMgzBZADkIltCPzyj40Z42PGN+SI6+iQ0rpbvTjH5vJ5cuRS63vGk3Xp jis6cjJteeDzGPYtOGuSNWvAn8Dc0O4ED2WlXBRcM5US63j09hwqiWLSmr13atHZI2 hWnvBochrfDGcR3KhXDJku8+GR8uaPGigvxWIVES9sMIU3F7KyQ9PJMvX0xNhd6CPy IhWVhKQd26cnucXe/AtKomFmpxc7ubr7kgVpAzJiqVCzHJkmyVSyURn6FA3LXK9rrw leS8AqnHoNEAQ== Message-ID: Date: Thu, 21 Sep 2023 09:54:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v2 4/4] thermal/drivers/mediatek/lvts_thermal: add mt7988 support Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230920175001.47563-1-linux@fw-web.de> <20230920175001.47563-5-linux@fw-web.de> From: AngeloGioacchino Del Regno In-Reply-To: <20230920175001.47563-5-linux@fw-web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230921_005441_303386_DA5A44B2 X-CRM114-Status: GOOD ( 27.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMjAvMDkvMjMgMTk6NTAsIEZyYW5rIFd1bmRlcmxpY2ggaGEgc2NyaXR0bzoKPiBGcm9tOiBG cmFuayBXdW5kZXJsaWNoIDxmcmFuay13QHB1YmxpYy1maWxlcy5kZT4KPiAKPiBBZGQgU3VwcG9y dCBmb3IgTWVkaWF0ZWsgRmlsb2dpYyA4ODAvTVQ3OTg4IExWVFMuCj4gCj4gU2lnbmVkLW9mZi1i eTogRnJhbmsgV3VuZGVybGljaCA8ZnJhbmstd0BwdWJsaWMtZmlsZXMuZGU+Cj4gLS0tCj4gdjI6 Cj4gLSB1c2UgMTA1wrBDIGZvciBodyBzaHV0ZG93bgo+IC0gbW92ZSBjb25zdGFudHMgdG8gYmlu ZGluZyBmaWxlCj4gLSBjaGFuZ2UgY29lZmYuYSB0byB0ZW1wX2ZhY3RvciBhbmQgY29lZmYuYiB0 byB0ZW1wX29mZnNldAo+IC0gY2hhbmdlIHRvIGx2dHMgdG8gbHZ0cy1hcCAoQXBwbGljYXRpb24g UHJvY2Vzc29yKQo+IC0gZHJvcCBjb21tZW50cyBhYm91dCBlZnVzZSBvZmZzZXRzCj4gLSBjaGFu Z2UgY29tbWVudCBvZiBtdDgxOTUgdG8gYmUgc2ltaWxhciB0byBtdDc5ODgKPiAtLS0KPiAgIGRy aXZlcnMvdGhlcm1hbC9tZWRpYXRlay9sdnRzX3RoZXJtYWwuYyB8IDQ2ICsrKysrKysrKysrKysr KysrKysrKysrKysKPiAgIDEgZmlsZSBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvdGhlcm1hbC9tZWRpYXRlay9sdnRzX3RoZXJtYWwuYyBiL2RyaXZl cnMvdGhlcm1hbC9tZWRpYXRlay9sdnRzX3RoZXJtYWwuYwo+IGluZGV4IGMyNjY5ZjQwNWE5NC4u OGZkMWRjNWFkYjE2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdGhlcm1hbC9tZWRpYXRlay9sdnRz X3RoZXJtYWwuYwo+ICsrKyBiL2RyaXZlcnMvdGhlcm1hbC9tZWRpYXRlay9sdnRzX3RoZXJtYWwu Ywo+IEBAIC04Miw2ICs4Miw4IEBACj4gICAjZGVmaW5lIExWVFNfR09MREVOX1RFTVBfREVGQVVM VAk1MAo+ICAgI2RlZmluZSBMVlRTX0NPRUZGX0FfTVQ4MTk1CQkJLTI1MDQ2MAo+ICAgI2RlZmlu ZSBMVlRTX0NPRUZGX0JfTVQ4MTk1CQkJMjUwNDYwCj4gKyNkZWZpbmUgTFZUU19DT0VGRl9BX01U Nzk4OAkJCS0yMDQ2NTAKPiArI2RlZmluZSBMVlRTX0NPRUZGX0JfTVQ3OTg4CQkJMjA0NjUwCj4g ICAKPiAgICNkZWZpbmUgTFZUU19NU1JfSU1NRURJQVRFX01PREUJCTAKPiAgICNkZWZpbmUgTFZU U19NU1JfRklMVEVSRURfTU9ERQkJMQo+IEBAIC04OSw2ICs5MSw3IEBACj4gICAjZGVmaW5lIExW VFNfTVNSX1JFQURfVElNRU9VVF9VUwk0MDAKPiAgICNkZWZpbmUgTFZUU19NU1JfUkVBRF9XQUlU X1VTCQkoTFZUU19NU1JfUkVBRF9USU1FT1VUX1VTIC8gMikKPiAgIAo+ICsjZGVmaW5lIExWVFNf SFdfU0hVVERPV05fTVQ3OTg4CQkxMDUwMDAKCkkgd291bGQgc2ltcGx5IHJldXNlIHRoZSBkZWZp bml0aW9uIG9mIExWVFNfSFdfU0hVVERPV05fTVQ4MTk1Li4uLgoKPiAgICNkZWZpbmUgTFZUU19I V19TSFVURE9XTl9NVDgxOTUJCTEwNTAwMAo+ICAgCj4gICAjZGVmaW5lIExWVFNfTUlOSU1VTV9U SFJFU0hPTEQJCTIwMDAwCj4gQEAgLTEyNjksNiArMTI3Miw0MSBAQCBzdGF0aWMgaW50IGx2dHNf cmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAJcmV0dXJuIDA7Cj4gICB9 Cj4gICAKPiArLyoKPiArICogTFZUUyBNVDc5ODgKPiArICovCj4gKwoKUGxlYXNlIHJlbW92ZSB0 aGlzIGJpZyBjb21tZW50IGJsb2NrLCB0aGF0J3Mgbm90IG5lZWRlZC4KCj4gK3N0YXRpYyBjb25z dCBzdHJ1Y3QgbHZ0c19jdHJsX2RhdGEgbXQ3OTg4X2x2dHNfYXBfZGF0YV9jdHJsW10gPSB7Cj4g Kwl7Cj4gKwkJLmNhbF9vZmZzZXQgPSB7IDB4MDAsIDB4MDQsIDB4MDgsIDB4MGMgfSwgLy85MTgs OTFDLDkyMCw5MjQKClRoaXMgOTE4LDkxYyxldGMgY29tbWVudCBpcyBub3QgbmVjZXNzYXJ5Cgo+ ICsJCS5sdnRzX3NlbnNvciA9IHsKPiArCQkJeyAuZHRfaWQgPSBNVDc5ODhfQ1BVXzAgfSwgLy8g Q1BVIDAsMQoKSWYgeW91IHdhbnQgdG8gcmV0YWluIHRob3NlIGNvbW1lbnRzLCB5b3Ugc2hhbGwg dXNlIHRoZSByaWdodCBzdHlsZS4KCnsgLmR0X2lkID0gTVQ3OTg4X0NQVV8wIH0sIC8qIENQVSAw LDEgKi8KeyAuLiB9IC8qIENQVSAyLDMgKi8KeyAuLiB9IC8qIEludGVybmFsIDIuNUcgUEhZIDEg Ki8KCmV0YwoKPiArCQkJeyAuZHRfaWQgPSBNVDc5ODhfQ1BVXzEgfSwgLy8gQ1BVIDIsMwo+ICsJ CQl7IC5kdF9pZCA9IE1UNzk4OF9FVEgyUDVHXzAgfSwgLy8gaW50ZXJuYWwgMi41RyBQaHkgMQo+ ICsJCQl7IC5kdF9pZCA9IE1UNzk4OF9FVEgyUDVHXzEgfSAgLy8gaW50ZXJuYWwgMi41RyBQaHkg Mgo+ICsJCX0sCj4gKwkJLm51bV9sdnRzX3NlbnNvciA9IDQsCj4gKwkJLm9mZnNldCA9IDB4MCwK PiArCQkuaHdfdHNodXRfdGVtcCA9IExWVFNfSFdfU0hVVERPV05fTVQ3OTg4LAo+ICsJfSwKPiAr CXsKPiArCQkuY2FsX29mZnNldCA9IHsgMHgxNCwgMHgxOCwgMHgxYywgMHgyMCB9LCAvLzkyQyw5 MzAsOTM0LDkzOAoKY29tbWVudCBub3QgbmVlZGVkCgo+ICsJCS5sdnRzX3NlbnNvciA9IHsKPiAr CQkJeyAuZHRfaWQgPSBNVDc5ODhfVE9QU18wfSwgLy8gVE9QUyA+ICsJCQl7IC5kdF9pZCA9IE1U Nzk4OF9UT1BTXzF9LCAvLyBUT1BTCgpUaGUgZHRfaWQgZGVmaW5pdGlvbiBhbHJlYWR5IHNheXMg IlRPUFMiLCB0aGlzIGNvbW1lbnQgaXMgbm90IG5lZWRlZC4KCj4gKwkJCXsgLmR0X2lkID0gTVQ3 OTg4X0VUSFdBUlBfMH0sIC8vIFdFRCAxCj4gKwkJCXsgLmR0X2lkID0gTVQ3OTg4X0VUSFdBUlBf MX0gIC8vIFdFRCAyCgpTYW1lIGNvbW1lbnQgYWJvdXQgdGhlIGZvcm1hdDsgLyogV0VEIDEgKi8K Cj4gKwkJfSwKPiArCQkubnVtX2x2dHNfc2Vuc29yID0gNCwKPiArCQkub2Zmc2V0ID0gMHgxMDAs Cj4gKwkJLmh3X3RzaHV0X3RlbXAgPSBMVlRTX0hXX1NIVVRET1dOX01UNzk4OCwKPiArCX0KPiAr fTsKPiArCj4gKy8qCj4gKyAqIExWVFMgTVQ4MTk1Cj4gKyAqLwoKUGxlYXNlIGFsc28gcmVtb3Zl IHRoaXMgYmlnIGNvbW1lbnQgYmxvY2ssIGl0J3Mgbm90IG5lZWRlZC4KCkFwYXJ0IGZyb20gdGhh dCwgdGhpcyBwYXRjaCBsb29rcyBnb29kOyB2MyB3aWxsIGJlIHRoZSBnb2xkZW4gb25lIDotKQoK Q2hlZXJzLApBbmdlbG8KCj4gKwo+ICAgc3RhdGljIGNvbnN0IHN0cnVjdCBsdnRzX2N0cmxfZGF0 YSBtdDgxOTVfbHZ0c19tY3VfZGF0YV9jdHJsW10gPSB7Cj4gICAJewo+ICAgCQkuY2FsX29mZnNl dCA9IHsgMHgwNCwgMHgwNyB9LAo+IEBAIC0xMzQ4LDYgKzEzODYsMTMgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBsdnRzX2N0cmxfZGF0YSBtdDgxOTVfbHZ0c19hcF9kYXRhX2N0cmxbXSA9IHsKPiAg IAl9Cj4gICB9Owo+ICAgCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgbHZ0c19kYXRhIG10Nzk4OF9s dnRzX2FwX2RhdGEgPSB7Cj4gKwkubHZ0c19jdHJsCT0gbXQ3OTg4X2x2dHNfYXBfZGF0YV9jdHJs LAo+ICsJLm51bV9sdnRzX2N0cmwJPSBBUlJBWV9TSVpFKG10Nzk4OF9sdnRzX2FwX2RhdGFfY3Ry bCksCj4gKwkudGVtcF9mYWN0b3IJPSBMVlRTX0NPRUZGX0FfTVQ3OTg4LAo+ICsJLnRlbXBfb2Zm c2V0CT0gTFZUU19DT0VGRl9CX01UNzk4OCwKPiArfTsKPiArCj4gICBzdGF0aWMgY29uc3Qgc3Ry dWN0IGx2dHNfZGF0YSBtdDgxOTVfbHZ0c19tY3VfZGF0YSA9IHsKPiAgIAkubHZ0c19jdHJsCT0g bXQ4MTk1X2x2dHNfbWN1X2RhdGFfY3RybCwKPiAgIAkubnVtX2x2dHNfY3RybAk9IEFSUkFZX1NJ WkUobXQ4MTk1X2x2dHNfbWN1X2RhdGFfY3RybCksCj4gQEAgLTEzNjMsNiArMTQwOCw3IEBAIHN0 YXRpYyBjb25zdCBzdHJ1Y3QgbHZ0c19kYXRhIG10ODE5NV9sdnRzX2FwX2RhdGEgPSB7Cj4gICB9 Owo+ICAgCj4gICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBsdnRzX29mX21hdGNo W10gPSB7Cj4gKwl7IC5jb21wYXRpYmxlID0gIm1lZGlhdGVrLG10Nzk4OC1sdnRzLWFwIiwgLmRh dGEgPSAmbXQ3OTg4X2x2dHNfYXBfZGF0YSB9LAo+ICAgCXsgLmNvbXBhdGlibGUgPSAibWVkaWF0 ZWssbXQ4MTk1LWx2dHMtbWN1IiwgLmRhdGEgPSAmbXQ4MTk1X2x2dHNfbWN1X2RhdGEgfSwKPiAg IAl7IC5jb21wYXRpYmxlID0gIm1lZGlhdGVrLG10ODE5NS1sdnRzLWFwIiwgLmRhdGEgPSAmbXQ4 MTk1X2x2dHNfYXBfZGF0YSB9LAo+ICAgCXt9LAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK