From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD5A2C282EC for ; Tue, 18 Mar 2025 10:01:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tuTkk-0006wZ-Kc; Tue, 18 Mar 2025 06:00:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuTkj-0006wF-DJ for qemu-devel@nongnu.org; Tue, 18 Mar 2025 06:00:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tuTkh-0003Ba-K6 for qemu-devel@nongnu.org; Tue, 18 Mar 2025 06:00:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742292050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1TC2Dyz81USdQukxOrzg4t7C8B+Y4A/B3MSVaP6VNfE=; b=XKTu9DW+DAHbuvrK80zHlxi7BBYlS8D2tAHYdhlWI2zqH0UATFTfJ2VwhmRq5ldKrfqi55 0EAg3kkliKtNl6fgLosMwcbxrhPvM8Br7Ouj+V0uabtj4odkkLD5hiA3tkb7sxG8OLQwz5 ixaP4sSG1vRHu8ec+NZYgtmNoehjMrk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-601-LJRStcJjNlStuJf28NqcZA-1; Tue, 18 Mar 2025 06:00:48 -0400 X-MC-Unique: LJRStcJjNlStuJf28NqcZA-1 X-Mimecast-MFC-AGG-ID: LJRStcJjNlStuJf28NqcZA_1742292047 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3912d9848a7so3292710f8f.0 for ; Tue, 18 Mar 2025 03:00:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742292047; x=1742896847; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1TC2Dyz81USdQukxOrzg4t7C8B+Y4A/B3MSVaP6VNfE=; b=FcBUXNZN+2IdfuzE/HzcfCYfMmFVvuY09WorPDb1EL8rdwjA74SU6H049lT3DfQ5vm GA4kWzuBzKX2Yg4/0zNYnq+D++KBEGCP8/whmc4p1Ew72rrSocTuoBov6JoHMohwxluI WbOKfgz8p4QeI8vkqg81sKW62SZgbDXAhjED+YMcFRdd2rCl7adsw93+DO27dmICG9/I J5V+x7bjonqD4bamxfZybeYugVf+dRwNuXoZLKrsMvw6Fu/ZAfsW2upfY4+kX4+LU4kN EtfRYOZn1L6n0Eb3hTvQZNOASm3Zpbj8z7vYH9HquUUCC7vpDdoR9CGnqgggcYnUPUdd zl8w== X-Forwarded-Encrypted: i=1; AJvYcCVCMpc1p+SelkF67ikIAhvFVZjfrlracW6w1d7QPafDtqN3KY96AvAqjzpvQdL8evJxATGrkvK43n3r@nongnu.org X-Gm-Message-State: AOJu0YyH6v/g5we+ovjZ8ASVk8xuxUlolgxXRDS9cB9dQcbvtqEL/iZ/ GDsh6ER0l0rLWdyGfcHKYZqE3oDP8DuqiCid7XIIacwSD9koJrMTFpUp8Lw/KRdpEWhS10PuvrS D0N9bIUYcg/8+oFJxYRvIqxzk210LsElZw7TQyGrlLvTnypuOTW9Q X-Gm-Gg: ASbGncv9HQh5xGsGVepjNu3XjrUxojSVCNZaH/CDPHATBmiyRTawNRb479tuK5mKsgX 3+HgePUvZ+s9kjHFiJ4jBAza0kOoTPchQX2nlwnOfL0N2+EV6tu+PtsDHk/XIuOJQMUB1ci88AH 0OItaiOK4PKg5L2DIvbMhb5aNn7acCt0tW2pmlKhjbkNYGg/yLi63epSvC+3C2LotsrcuL84h2F Tyf9lygHpkn6svuNsvykHHoWVamppSj4CP6odg1e9LX8Ws8NV7hlEx4Vs9d+GpaY/AvY0gTa4LD /ZVaZPIm1whShAkwY20jMswKfIrTeIGX7p4cJtEhuPIy5XXiJdIkCQ== X-Received: by 2002:a05:6000:2ce:b0:391:bc8:564a with SMTP id ffacd0b85a97d-3996bb7747dmr2348192f8f.22.1742292047441; Tue, 18 Mar 2025 03:00:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1BfmPotmdZaZUcjrNF6vUlSoQeuo81vGEyDtTmqrn9IGKG/lDnmM0sQ6uxlicYbpO1DZZpg== X-Received: by 2002:a05:6000:2ce:b0:391:bc8:564a with SMTP id ffacd0b85a97d-3996bb7747dmr2348141f8f.22.1742292047012; Tue, 18 Mar 2025 03:00:47 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:9db0:474c:ff43:9f5c? ([2a01:e0a:280:24f0:9db0:474c:ff43:9f5c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fe60b46sm128298165e9.32.2025.03.18.03.00.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Mar 2025 03:00:45 -0700 (PDT) Message-ID: Date: Tue, 18 Mar 2025 11:00:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 00/28] vfio-user client To: Steven Sistare , John Levon , qemu-devel@nongnu.org Cc: Jason Herne , Thanos Makatos , Halil Pasic , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eric Farman , Tony Krowiak , Thomas Huth , qemu-s390x@nongnu.org, Matthew Rosato , Paolo Bonzini , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , Stefano Garzarella , Alex Williamson , David Hildenbrand , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" References: <20250219144858.266455-1-john.levon@nutanix.com> <5910cf36-ca6f-489b-a7f6-b720733f16e1@redhat.com> Content-Language: en-US, fr From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.335, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/14/25 15:48, Steven Sistare wrote: > > > On 3/14/2025 10:25 AM, Cédric Le Goater wrote: >> John, >> >> +Steven, for the Live upsate series. >> >> On 2/19/25 15:48, John Levon wrote: >>> This is the 8th revision of the vfio-user client implementation. The vfio-user >>> protocol allows for implementing (PCI) devices in another userspace process; >>> SPDK is one example, which includes a virtual NVMe implementation. >>> >>> The vfio-user framework consists of 3 parts: >>>   1) The VFIO user protocol specification. >>>   2) A client - the VFIO device in QEMU that encapsulates VFIO messages >>>      and sends them to the server. >>>   3) A server - a remote process that emulates a device. >>> >>> This patchset implements parts 1 and 2. >>> >>> It has been tested against libvfio-user test servers as well as SPDK. >>> >>> Thanks for previous reviews & comments. >> >> This series is going in the right direction. Thanks for all the >> changes. However, I will postpone my review for the reasons below. >> >> VFIO initial commit in 2012 was a single file adding support for a >> "vfio-pci" device. Since, the subsystem has changed a lot and it grew >> to +16K line of code. Over the years, we've had numerous additions, >> VFIO platform devices, s390x VFIO AP and CCW devices, migration >> support with dirty tracking, support for different host IOMMU backend >> devices, multifd, etc. All these additions never took the opportunity >> to introduce a VFIO interface for external usage and PPC, s390x, >> migration, backends subsystems happily and randomly peek and poke into >> it. The subsystem is now a happy jumble of disparate functions, with >> weak organization and names. The vfio-common.h header file is >> good example of the result. >> >> It's time for a global code reshuffling. I'll take care of it (and >> I've already started) and this means nothing new (fixes are OK) will >> be merged before this is done. I hope I have made enough progress >> before the start of the QEMU 10.1 cycle. There won't be any functional >> changes, but there will be new files and new function names, so it's >> probably a real earthquake for your series. > > Hi Cedric, as part of your reshuffling, can you incorporate the code cleanup > patches that I submitted in the live update series? I will try when this series has had some reviews : https://lore.kernel.org/qemu-devel/20250318095415.670319-1-clg@redhat.com/ Thanks, C.