From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2518CF9C6B for ; Tue, 24 Sep 2024 16:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JkE5EEVz39h0z7D6mTZGqT98JRMrECJ/HNlNwqISMrg=; b=oiztvUBMPTIAc1jbocAncQF7+g dByXAaKYrsbk+5H0OKum5MzANSFOiM9TDE+R5in5ZsYXs5+/xatblTmaY+C/71xGZsPIPFQ9DguY8 +a4fajkbNQPueE94hrQAkG/HYL6gkEXYgt0HAeuiCoshTn/wwPYtaBiSQyz/jAXIVKQt5yJTIBP/g vblI+n7pvPy6FSNeULMehvqfgAfVfH8GtDl0vktChRppvehsbxcOqvAumS0BwWJ621Ey7o+PtTL2e zjZiy+cO+SivdptoHz1Wn0JzLkGJECabVFphntxpvBFGdcnF+NVMQI+DmcHFlvf4CVJu7cJgpKa7Y I6GYZDvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1st8IY-00000002oBQ-2p7B; Tue, 24 Sep 2024 16:21:58 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1st8H5-00000002nny-0YPh for linux-arm-kernel@lists.infradead.org; Tue, 24 Sep 2024 16:20:28 +0000 Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-8323dddfca2so55472239f.2 for ; Tue, 24 Sep 2024 09:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727194825; x=1727799625; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JkE5EEVz39h0z7D6mTZGqT98JRMrECJ/HNlNwqISMrg=; b=CKSuuheYPCQm38dmQ8DMgomxKb6NW1kuG1Dj5YW3DEh3kggs5f9Qldb2Jfbr+9AZbD 5DTi1/6jwNNz4fnhAqRoflsIrh7jheb+Gng8tplPUsG5cAXunSHIbM1U1cTuYyOYV8ir Rv9nQV1YhvkUoNJtsDc2chFezLIP7JnzDYu/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727194825; x=1727799625; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JkE5EEVz39h0z7D6mTZGqT98JRMrECJ/HNlNwqISMrg=; b=jGkd30KUUGh80B0gOkjWxjHS0Xz7zLw+1aAO4llaBuPJys7VHMHoR8edWNkDsBpdzk y7YJdL0Og+LcmRfFfS9n/WAQtYJbBoFvOr8meKSvQuIvC9EKBweEv0yqp/viv/Hpgfuq cdIs6+/ThGTw5gJz4BoGG0WINifSA1sYZYKN8fLyPy9TN7XmQuZrE+rhZrOAZg/FXPfp fJFNIyxmDCOms0/KTpX75NH8dMzs9+t6sxSQK6OCOw8CaRUhGXPACHMA3TsVLdbitJGU ryigBYNBznc2YIgvDYlbJH797XGpwYnRI9uj51hichZ3qda/tTJrBuxGpz58mdVVarKH W19g== X-Forwarded-Encrypted: i=1; AJvYcCUZ0OVW9fIiCYxB2xv+PWD/54Rs3wuCB67hnCUG+gec9Kv7VLdkeN7Btf4A0yVTly0h0J6qb41RelBke0OI7Zwl@lists.infradead.org X-Gm-Message-State: AOJu0Yz7S5wJC/gyfZFE1hxMRRLNgoLAnr67kaxKayQucREI+3xLJl2Q k+kR98IIlrtFteZeY82vpC8rv6ZQ/WzR6Fz3f6b/dqI7PHkYdFym3rQfHoEEhl8= X-Google-Smtp-Source: AGHT+IFYkn1+9ENAiRN9ADnr88Pk7qHZFLKOsJb7eXEADSOPGQOc8ujHHxUnWVRGg7bQR/m3wAHksg== X-Received: by 2002:a05:6602:1586:b0:82b:42f:41d5 with SMTP id ca18e2360f4ac-83247f88e3amr2796439f.16.1727194825191; Tue, 24 Sep 2024 09:20:25 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d40f416082sm490982173.174.2024.09.24.09.20.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Sep 2024 09:20:23 -0700 (PDT) Message-ID: Date: Tue, 24 Sep 2024 10:20:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: ti: knav_qmss_queue: remove useless statement To: Alessandro Zanni , nm@ti.com, ssantosh@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, anupnewsmail@gmail.com, Shuah Khan References: <20240924132025.22046-1-alessandro.zanni87@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240924132025.22046-1-alessandro.zanni87@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240924_092027_328981_AAC7C62E X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/24/24 07:20, Alessandro Zanni wrote: > Remove the statement "continue" at the end of the loop where it > becomes useless. How did you find the problem? Change log should say how you found it. > > Signed-off-by: Alessandro Zanni > --- > drivers/soc/ti/knav_qmss_queue.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c > index 6c98738e548a..1cc54905b398 100644 > --- a/drivers/soc/ti/knav_qmss_queue.c > +++ b/drivers/soc/ti/knav_qmss_queue.c > @@ -723,7 +723,6 @@ static void kdesc_empty_pool(struct knav_pool *pool) > if (!desc) { > dev_dbg(pool->kdev->dev, > "couldn't unmap desc, continuing\n"); > - continue; > } > } > WARN_ON(i != pool->num_desc); thanks, -- Shuah