All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: "Ruoyu Wang" <ruoyuw560@gmail.com>,
	iommu@lists.linux.dev, "Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jörg Rödel" <joro@8bytes.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
	"Vasant Hegde" <vasant.hegde@amd.com>,
	"Wei Huang" <wei.huang2@amd.com>, "Will Deacon" <will@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: Fix PCI device reference leak in PPR handling
Date: Sun, 16 Aug 2026 16:48:24 +0200	[thread overview]
Message-ID: <eb7b71c6-bc93-4807-9d63-bebf804d3e3e@web.de> (raw)
In-Reply-To: <20260814133938.1385879-1-ruoyuw560@gmail.com>

…
> Call pci_dev_put() after the final use of the lookup reference on both
> paths.
…

How do you think about to apply the attribute “__free(pci_dev_put)”
also in the implementation of the function “iommu_call_iopf_notifier”?
https://elixir.bootlin.com/linux/v7.2-rc7/source/include/linux/pci.h#L1269

https://elixir.bootlin.com/linux/v7.2-rc7/source/drivers/iommu/amd/ppr.c#L107-L162

Regards,
Markus


  reply	other threads:[~2026-08-16 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 13:39 [PATCH] iommu/amd: Fix PCI device reference leak in PPR handling Ruoyu Wang
2026-08-16 14:48 ` Markus Elfring [this message]
2026-08-22 14:09 ` Vasant Hegde
2026-08-23  6:20   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb7b71c6-bc93-4807-9d63-bebf804d3e3e@web.de \
    --to=markus.elfring@web.de \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=ruoyuw560@gmail.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=vasant.hegde@amd.com \
    --cc=wei.huang2@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.