Re: [PATCH] blk-mq: cleanup terminal request when it could not be queued

[Bart Van Assche <bvanassche@acm.org>]

On 9/11/26 12:54 AM, John Garry wrote:
> Sashiko points out that the SCSI midlayer error handling misses some
> cleanup for when a request could not be queued and won't be requeued [0].
> Specifically, clearing the SCSI cmd flags member is missing. Normally that
> would be cleared in the non-error path in scsi_end_request() (which also
> calls __blk_mq_end_request()).
> 
> Callchain blk_mq_cleanup_rq() -> scsi_cleanup_rq() does all the necessary
> cleanup, so call that in blk_mq_dispatch_rq_list() for when there was an
> error in the dispatch and the rq will be ended.
> 
> Note that dm-rq code calls blk_mq_cleanup_rq() for a cloned rq (or SCSI rq)
> for when the clone could not be queued and will be retried, but that path
> does not use the sched code (and blk_mq_dispatch_rq_list()).
> 
> [0] https://lore.kernel.org/linux-scsi/20260729161243.C918D1F00A3A@smtp.kernel.org/
> 
> Suggesested-by: Bart Van Assche <bvanassche@acm.org>
> Signed-off-by: John Garry <john.garry@linux.dev>
Does this patch need a Fixes: tag? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>