From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48799C433EF for ; Wed, 24 Nov 2021 07:13:16 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 76E651767; Wed, 24 Nov 2021 08:12:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 76E651767 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637737994; bh=ujd/or5iN565wDOdChsLFPi0FyAOQXdkKmmiQ6KiHyg=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rWxFV7GPbQdhGZ8O2T2qTsFV+Jd5hCZFuz0uh/YoEG4sunsI6zoqB680LCMPxxFzv u8vizMp5QeBJAv/6eJoJxBhv/Yxs4bQj+GL+Sm2y8tF9jD+B55Cs7Zml2pf9Njipa5 /FTiZB1MYKYwK0ZlvZe09bvCNTh2FKbwwRlAJJAc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 235E7F805AA; Wed, 24 Nov 2021 08:06:12 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30D2BF804B1; Tue, 23 Nov 2021 18:06:42 +0100 (CET) Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6E725F80154 for ; Tue, 23 Nov 2021 18:06:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6E725F80154 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="d9ATGvqg" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 1AN7k0DE013868; Tue, 23 Nov 2021 11:06:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=message-id : date : mime-version : from : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=PODMain02222019; bh=amQU7FZ/5g8QJDCHA86K0HOZeFaQBYccT1e3/wxVmZo=; b=d9ATGvqg538Vpg4nOsV8jFtKyuj/+QUi/oPnQKYM4FEtAnqyikfeJyXi7Fdx0JuuCjXn uSBbDQlfWDBhm77fbn6zkIkzB0sKN1WDaoBh3L0WQLeBVVkCS8j3GDoJ17gt3jMlY/7f 7+RsPnwN+7OjmE87M1ZRA+0qiqA/pGj3UcWclyR//evlP554a1bPhS893LQnWRpdqidT V1YgKIwoG3pXFfE50PqzP0c84joCr6CEFCaoepst4dmyCVyepgXL5QX3axNHu9nqjFN2 ZLiDCIeLXLCTj8TOFpd/yYsO38lxo8yvG/U9fzmcPzpESEmpZKmW93L/FSPyJMi4o2x2 6w== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3cg3v7a3ee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 23 Nov 2021 11:06:32 -0600 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Tue, 23 Nov 2021 17:06:30 +0000 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Tue, 23 Nov 2021 17:06:30 +0000 Received: from [198.61.65.11] (unknown [198.61.65.11]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 5DFFB2A3; Tue, 23 Nov 2021 17:06:30 +0000 (UTC) Message-ID: Date: Tue, 23 Nov 2021 17:06:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 From: To: Pierre-Louis Bossart , "Rafael J.Wysocki" , Len Brown , Hans de Goede , Mark Gross , Liam Girdwood , Jaroslav Kysela , Mark Brown , Takashi Iwai , Kailang Yang , Shuming Fan , David Rhodes , Vitaly Rodionov , Jeremy Szu , Hui Wang , Werner Sembach , Chris Chiu , Cameron Berkenpas , Sami Loone , Elia Devito , Srinivas Kandagatla , Jack Yu , "Arnd Bergmann" , Lars-Peter Clausen , "Alexandre Belloni" , , , , , Subject: Re: [PATCH 10/11] hda: cs35l41: Add support for CS35L41 in HDA systems References: <20211123163149.1530535-1-tanureal@opensource.cirrus.com> <20211123163149.1530535-11-tanureal@opensource.cirrus.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: jNP0KH8DmaKZaqeUPB5H2Q11BR3PWT0N X-Proofpoint-ORIG-GUID: jNP0KH8DmaKZaqeUPB5H2Q11BR3PWT0N X-Proofpoint-Spam-Reason: safe X-Mailman-Approved-At: Wed, 24 Nov 2021 08:05:53 +0100 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 11/23/21 4:59 PM, Pierre-Louis Bossart wrote: > > > +#ifdef CONFIG_ACPI > > +static const struct acpi_device_id cs35l41_acpi_hda_match[] = { > > + {"CLSA0100", 0 }, > > I could be wrong but this doesn't look like a legit ACPI _HID? > > Cirrus Logic can use 'CIR', "CLI", or 'CSC' PNP ID, or an PCI ID. > > in the past you used > > +#ifdef CONFIG_ACPI > +static const struct acpi_device_id cs35l41_acpi_match[] = { > + { "CSC3541", 0 }, /* Cirrus Logic PnP ID + part ID */ > + {}, > +}; > +MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match); > +#endif > > > This ACPI _HID is already released, there is nothing I can do about it. Future devices will use 'CSC' PnP ID.