All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gal Pressman <pressmangal@gmail.com>
To: Yuval Shaia <yuval.shaia@oracle.com>,
	saeedm@mellanox.com, leon@kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2] net/mlx5: Delete unneeded function argument
Date: Thu, 16 Aug 2018 09:41:34 +0300	[thread overview]
Message-ID: <ebbc0eff-eacf-fd30-bb03-bd7ef9e6c3c0@gmail.com> (raw)
In-Reply-To: <20180815150854.30993-1-yuval.shaia@oracle.com>

On 15-Aug-18 18:08, Yuval Shaia wrote:
> priv argument is not used by the function, delete it.
> 
> Fixes: a89842811ea98 ("net/mlx5e: Merge per priority stats groups")
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>

nit: prefix should be net/mlx5e.

> ---
> v1 -> v2:
> 	* Remove blank line as pointed by Leon.
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> index 1646859974ce..4c4d779dafa8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> @@ -813,7 +813,7 @@ static const struct counter_desc pport_per_prio_traffic_stats_desc[] = {
>  
>  #define NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS	ARRAY_SIZE(pport_per_prio_traffic_stats_desc)
>  
> -static int mlx5e_grp_per_prio_traffic_get_num_stats(struct mlx5e_priv *priv)
> +static int mlx5e_grp_per_prio_traffic_get_num_stats(void)
>  {
>  	return NUM_PPORT_PER_PRIO_TRAFFIC_COUNTERS * NUM_PPORT_PRIO;
>  }
> @@ -971,7 +971,7 @@ static int mlx5e_grp_per_prio_pfc_fill_stats(struct mlx5e_priv *priv,
>  
>  static int mlx5e_grp_per_prio_get_num_stats(struct mlx5e_priv *priv)
>  {
> -	return mlx5e_grp_per_prio_traffic_get_num_stats(priv) +
> +	return mlx5e_grp_per_prio_traffic_get_num_stats() +
>  		mlx5e_grp_per_prio_pfc_get_num_stats(priv);
>  }
>  
> 

  reply	other threads:[~2018-08-16  6:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 15:08 [PATCH v2] net/mlx5: Delete unneeded function argument Yuval Shaia
2018-08-16  6:41 ` Gal Pressman [this message]
2018-08-16  9:00   ` Yuval Shaia
2018-08-16 10:31     ` Gal Pressman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebbc0eff-eacf-fd30-bb03-bd7ef9e6c3c0@gmail.com \
    --to=pressmangal@gmail.com \
    --cc=davem@davemloft.net \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.