From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDBDF7F6 for ; Thu, 31 Mar 2022 10:29:08 +0000 (UTC) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-263-wT2Z8KTZO1SBLQAzOKJ3pQ-1; Thu, 31 Mar 2022 11:29:05 +0100 X-MC-Unique: wT2Z8KTZO1SBLQAzOKJ3pQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Thu, 31 Mar 2022 11:29:04 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Thu, 31 Mar 2022 11:29:04 +0100 From: David Laight To: 'Alaa Mohamed' , "outreachy@lists.linux.dev" CC: "gregkh@linuxfoundation.org" , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] staging: gdm724x: Fix Duplication of Side Effects Thread-Topic: [PATCH] staging: gdm724x: Fix Duplication of Side Effects Thread-Index: AQHYROi924sZ22xfrE+zbiso9jQv5KzZSk9w Date: Thu, 31 Mar 2022 10:29:04 +0000 Message-ID: References: <20220331101849.71046-1-eng.alaamohamedsoliman.am@gmail.com> In-Reply-To: <20220331101849.71046-1-eng.alaamohamedsoliman.am@gmail.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: Alaa Mohamed > Sent: 31 March 2022 11:19 >=20 > Fix Duplication of Side Effects for GDM_TTY_READY(gdm) macro > reported by checkpatch > "CHECK: Macro argument reuse 'gdm' - possible side-effects?" >=20 > Signed-off-by: Alaa Mohamed > --- > drivers/staging/gdm724x/gdm_tty.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/= gdm_tty.c > index 04df6f9f5403..6f0274470e69 100644 > --- a/drivers/staging/gdm724x/gdm_tty.c > +++ b/drivers/staging/gdm724x/gdm_tty.c > @@ -27,7 +27,9 @@ >=20 > #define MUX_TX_MAX_SIZE 2048 >=20 > -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count) > +#define GDM_TTY_READY(_gdm) \ > +=09({ typeof(_gdm) (gdm) =3D (_gdm); \ > +=09(gdm && gdm->tty_dev && gdm->port.count); }) Did you test this? see https://godbolt.org/z/cazPrrzPv =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)