From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Enze Li <lienze@kylinos.cn>,
muchun.song@linux.dev, osalvador@suse.de,
akpm@linux-foundation.org
Cc: linux-mm@kvack.org, enze.li@gmx.com
Subject: Re: [PATCH v2] mm/hugetlb: move hugetlb_sysfs_initialized into hugetlb_register_all_nodes()
Date: Fri, 9 Oct 2026 20:02:04 +0200 [thread overview]
Message-ID: <ec0072e0-0fba-41e2-948e-a89ae3bfde38@kernel.org> (raw)
In-Reply-To: <20261009142010.552614-1-lienze@kylinos.cn>
On 10/9/26 16:20, Enze Li wrote:
> hugetlb_sysfs_init() guards the "hugetlb_sysfs_initialized = true"
> assignment with an #ifdef CONFIG_NUMA block, while the following
> hugetlb_register_all_nodes() call is left unguarded and relies on the empty
> !CONFIG_NUMA stub.
>
> Move the assignment into the NUMA version of hugetlb_register_all_nodes(),
> before it registers the online nodes, so the #ifdef in hugetlb_sysfs_init()
> can go away. Keep the !CONFIG_NUMA stub, so the call site is unconditional
> in both configurations.
>
> Suggested-by: Muchun Song <muchun.song@linux.dev>
> Signed-off-by: Enze Li <lienze@kylinos.cn>
> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
next prev parent reply other threads:[~2026-10-09 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 14:20 [PATCH v2] mm/hugetlb: move hugetlb_sysfs_initialized into hugetlb_register_all_nodes() Enze Li
2026-10-09 18:02 ` David Hildenbrand (Arm) [this message]
2026-10-10 2:51 ` Muchun Song
2026-10-10 22:41 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec0072e0-0fba-41e2-948e-a89ae3bfde38@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=enze.li@gmx.com \
--cc=lienze@kylinos.cn \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.