From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22F92C00140 for ; Fri, 12 Aug 2022 17:53:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K3uZJG6RuQvpp6qEYeph1pvyd293qv//Yaz/oNMLtyA=; b=g4JzXqkfmhSKvJ 0yAPsJMrvauPeF+qanXecaMEty2X3T+3wHVKB5Jr88cSWi0zw79lx10L7dhOJ84BMFtdaYcQe4Afb dy+Kfbqyie/zJOQWeTrYCI5Tqei5WhNnrvK4wSQx2U8mGuvstPLhOZo+LZGAYVAau7PC/hHg2S/RR DHNps5B8O4q0K4vtksYqscSoz9ruUcKakkdepjKp3RIvoroZJHpFKJxELlunFEG8A7ZEV97DgKciO smho1CY6cv+ZsXKaRwdxiqmGK0BWO8lImwzBp7Crh0/k6s0+oL/6copih9KAMftCE3Ws6hdhn5K9E UOJS3rqzlAsYwaMAXUpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMYqC-00BkpQ-B5; Fri, 12 Aug 2022 17:53:00 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMYq9-00Bkn9-7m for linux-arm-kernel@lists.infradead.org; Fri, 12 Aug 2022 17:52:58 +0000 Received: by mail-qk1-x72c.google.com with SMTP id c28so1319278qko.9 for ; Fri, 12 Aug 2022 10:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=hTbq319S2HqQfUvndHpgKaA8H0ceRNDXupwwPdukCdQ=; b=Ctco/O6u6/JrwISnAd8hrYNtPb/a/VDmUpBts4Voy050o7YASgw0wquCcH4ReUj96B JtrmT659rZseW76eZX1HTQcxVHQlDywx/44yC658maQMatxamLNzglBmQS1KbanrUQ8H L4QjRAt6Gv0CDm92uzO7uSREJ7hYF/o0cIjsYjB2pcXsRVpKPe8qsoRkfJjnJYqNsVRb wxDdvgNoB5XDRuqq8yYBQIgq8Rc7mDdRLpmY14Xb+MP63UbQaXZ2eGJl9AS/uj28ggdb aqhvgGmnuzeWpg7DRfau7R4Nv6H5u8UCJ1yKGxPKrPm7yVjcTkR6T5yjFpBx4w0Bbd6B hopQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=hTbq319S2HqQfUvndHpgKaA8H0ceRNDXupwwPdukCdQ=; b=0Y+V8F8LyJgaDrdGpiq+j8lXlXk/nM0lLPhCsevqLfpBT4O3pW5NaujmWEVkUuvA+y Wq1sa3OGwDsMWb/ZP2WvuaNRvs4V4J9ZMWPnFq0M3yddviuS9YMNXz4BCxlCJ6d37W5F dpn6nyqlsEUCwue6bChS2DI0RfUdcmXZric6dCDT+gexze9vXzFqJAb6L6NuJQP651+5 9uja0J9BVxFu0CKTDA+Z2ZWF5yQ98OJCmoxVJA5QENh7bwwirdue44VIwaDewNpK80TG L6xO641T9iXMya36gNNBv+W8wxhtPWGYmGvMhvJGqs+S1pF1c3r0ZXzf2LqNOxp8EoVv Iz+w== X-Gm-Message-State: ACgBeo0F9U+ludQCI3tPBnmWjuwAYJwyB1C/YV/08+JimCuzcB2r6hnR lDz3t2xpSUZeAJufPg11sf1DmrMfR9o= X-Google-Smtp-Source: AA6agR4z+Xj0gOJv1Vdjzm9SnL5FTuExSao834rEtNsBpX4uar0ThkQZ6iTE7N0Cng8AzdEOIdfzEw== X-Received: by 2002:a05:620a:4914:b0:6b9:5ae8:3f9d with SMTP id ed20-20020a05620a491400b006b95ae83f9dmr3783735qkb.335.1660326775684; Fri, 12 Aug 2022 10:52:55 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id t6-20020a05620a450600b006b9c355ed75sm2197406qkp.70.2022.08.12.10.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 10:52:55 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 10:52:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 3/3] memory: Add Broadcom STB memory controller driver Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20220801220931.181531-1-f.fainelli@gmail.com> <20220801220931.181531-4-f.fainelli@gmail.com> <26ad247d-a4b3-4051-b8d9-505c09b76f6b@linaro.org> <375eac04-dbfd-080a-3003-cae3eda1f42b@gmail.com> From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_105257_336260_382878B0 X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/12/22 10:36, Krzysztof Kozlowski wrote: > On 12/08/2022 20:29, Florian Fainelli wrote: >> On 8/9/22 02:58, Krzysztof Kozlowski wrote: >>> On 02/08/2022 01:09, Florian Fainelli wrote: >>>> Add support for configuring the Self Refresh Power Down (SRPD) >>>> inactivity timeout on Broadcom STB chips. This is used to conserve power >>>> when the DRAM activity is reduced. >>>> >>> >>> >>>> +static int __maybe_unused brcmstb_memc_resume(struct device *dev) >>>> +{ >>>> + struct brcmstb_memc *memc = dev_get_drvdata(dev); >>>> + >>>> + if (memc->timeout_cycles == 0) >>>> + return 0; >>>> + >>>> + return brcmstb_memc_srpd_config(memc, memc->timeout_cycles); >>>> +} >>>> + >>>> +static SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend, >>>> + brcmstb_memc_resume); >>>> + >>>> +static struct platform_driver brcmstb_memc_driver = { >>>> + .probe = brcmstb_memc_probe, >>>> + .remove = brcmstb_memc_remove, >>>> + .driver = { >>>> + .name = "brcmstb_memc", >>>> + .owner = THIS_MODULE, >>> >>> No need, run coccinelle. >>> >>>> + .of_match_table = brcmstb_memc_of_match, >>>> + .pm = &brcmstb_memc_pm_ops, >>> >>> Shouldn't this be pm_ptr()? and then no need for __maybe_unused in >>> brcmstb_memc_resume/suspend. >> >> How can one can remove __maybe_unused without causing a warning for the >> CONFIG_PM=n case, not that I needed to build to convince myself, but >> still did anyway: >> >> drivers/memory/brcmstb_memc.c:275:12: warning: 'brcmstb_memc_resume' >> defined but not used [-Wunused-function] >> static int brcmstb_memc_resume(struct device *dev) >> ^~~~~~~~~~~~~~~~~~~ >> drivers/memory/brcmstb_memc.c:252:12: warning: 'brcmstb_memc_suspend' >> defined but not used [-Wunused-function] >> static int brcmstb_memc_suspend(struct device *dev) >> ^~~~~~~~~~~~~~~~~~~~ >> >> unless you also implied enclosing those functions under an #if >> IS_ENABLED(CONFIG_PM) or something which is IMHO less preferable. > > Are you sure you added also pm_ptr()? I don't see such warnings with W=1 > and final object does not have the functions (for a different driver but > same principle). Yes I am sure I added pm_ptr() see the v4 I just submitted. I don't see how the compiler cannot warn about the functions being unused the day they stop being referenced by the pm_ops structure which is eliminated? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBE59C00140 for ; Fri, 12 Aug 2022 17:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237168AbiHLRw6 (ORCPT ); Fri, 12 Aug 2022 13:52:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbiHLRw5 (ORCPT ); Fri, 12 Aug 2022 13:52:57 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9110060E1; Fri, 12 Aug 2022 10:52:56 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id a12so448807qkk.7; Fri, 12 Aug 2022 10:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=hTbq319S2HqQfUvndHpgKaA8H0ceRNDXupwwPdukCdQ=; b=Ctco/O6u6/JrwISnAd8hrYNtPb/a/VDmUpBts4Voy050o7YASgw0wquCcH4ReUj96B JtrmT659rZseW76eZX1HTQcxVHQlDywx/44yC658maQMatxamLNzglBmQS1KbanrUQ8H L4QjRAt6Gv0CDm92uzO7uSREJ7hYF/o0cIjsYjB2pcXsRVpKPe8qsoRkfJjnJYqNsVRb wxDdvgNoB5XDRuqq8yYBQIgq8Rc7mDdRLpmY14Xb+MP63UbQaXZ2eGJl9AS/uj28ggdb aqhvgGmnuzeWpg7DRfau7R4Nv6H5u8UCJ1yKGxPKrPm7yVjcTkR6T5yjFpBx4w0Bbd6B hopQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=hTbq319S2HqQfUvndHpgKaA8H0ceRNDXupwwPdukCdQ=; b=Bf4R8AatqKdzNHsoJDV5J2To8zcNTNcjrKq5qk41A1wQpPiYwefZo74VEuio1Wx7XO T99vePwH0oT+SY/TfONG6f2/iFFdWNKIa0zDliM7LUPkD7OTlay7iq+uH74GDuSbh7Zh KhLivRg3MubrxkGWpR1DLGvPIX6mhCJ78Gk7e20oi0MtQF8L1pRGOQn1ioHYcKfw5BdQ +JSEQYqyCvsDv0VgPgB9ibVR3Vyn0Lu2Vd28Aw9zTSNaVmkldHO1IbCOUWi4lZzHoxc/ NuMdfFu2FTLCyjUSQXvEg7sFKcGRHGpvwePdN6VwyvXMmJ5CUPAOrLb0Kz4z6Q8v9J80 X3rA== X-Gm-Message-State: ACgBeo2G0D6uQv80wF8Wk3hnzUA1FuHiHqwuU4EVxpgtWUGoHZbzk+w5 ym0VGychBJo8t0C7oUSV7Ic= X-Google-Smtp-Source: AA6agR4z+Xj0gOJv1Vdjzm9SnL5FTuExSao834rEtNsBpX4uar0ThkQZ6iTE7N0Cng8AzdEOIdfzEw== X-Received: by 2002:a05:620a:4914:b0:6b9:5ae8:3f9d with SMTP id ed20-20020a05620a491400b006b95ae83f9dmr3783735qkb.335.1660326775684; Fri, 12 Aug 2022 10:52:55 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id t6-20020a05620a450600b006b9c355ed75sm2197406qkp.70.2022.08.12.10.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 10:52:55 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 10:52:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 3/3] memory: Add Broadcom STB memory controller driver Content-Language: en-US To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Broadcom internal kernel review list , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20220801220931.181531-1-f.fainelli@gmail.com> <20220801220931.181531-4-f.fainelli@gmail.com> <26ad247d-a4b3-4051-b8d9-505c09b76f6b@linaro.org> <375eac04-dbfd-080a-3003-cae3eda1f42b@gmail.com> From: Florian Fainelli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8/12/22 10:36, Krzysztof Kozlowski wrote: > On 12/08/2022 20:29, Florian Fainelli wrote: >> On 8/9/22 02:58, Krzysztof Kozlowski wrote: >>> On 02/08/2022 01:09, Florian Fainelli wrote: >>>> Add support for configuring the Self Refresh Power Down (SRPD) >>>> inactivity timeout on Broadcom STB chips. This is used to conserve power >>>> when the DRAM activity is reduced. >>>> >>> >>> >>>> +static int __maybe_unused brcmstb_memc_resume(struct device *dev) >>>> +{ >>>> + struct brcmstb_memc *memc = dev_get_drvdata(dev); >>>> + >>>> + if (memc->timeout_cycles == 0) >>>> + return 0; >>>> + >>>> + return brcmstb_memc_srpd_config(memc, memc->timeout_cycles); >>>> +} >>>> + >>>> +static SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend, >>>> + brcmstb_memc_resume); >>>> + >>>> +static struct platform_driver brcmstb_memc_driver = { >>>> + .probe = brcmstb_memc_probe, >>>> + .remove = brcmstb_memc_remove, >>>> + .driver = { >>>> + .name = "brcmstb_memc", >>>> + .owner = THIS_MODULE, >>> >>> No need, run coccinelle. >>> >>>> + .of_match_table = brcmstb_memc_of_match, >>>> + .pm = &brcmstb_memc_pm_ops, >>> >>> Shouldn't this be pm_ptr()? and then no need for __maybe_unused in >>> brcmstb_memc_resume/suspend. >> >> How can one can remove __maybe_unused without causing a warning for the >> CONFIG_PM=n case, not that I needed to build to convince myself, but >> still did anyway: >> >> drivers/memory/brcmstb_memc.c:275:12: warning: 'brcmstb_memc_resume' >> defined but not used [-Wunused-function] >> static int brcmstb_memc_resume(struct device *dev) >> ^~~~~~~~~~~~~~~~~~~ >> drivers/memory/brcmstb_memc.c:252:12: warning: 'brcmstb_memc_suspend' >> defined but not used [-Wunused-function] >> static int brcmstb_memc_suspend(struct device *dev) >> ^~~~~~~~~~~~~~~~~~~~ >> >> unless you also implied enclosing those functions under an #if >> IS_ENABLED(CONFIG_PM) or something which is IMHO less preferable. > > Are you sure you added also pm_ptr()? I don't see such warnings with W=1 > and final object does not have the functions (for a different driver but > same principle). Yes I am sure I added pm_ptr() see the v4 I just submitted. I don't see how the compiler cannot warn about the functions being unused the day they stop being referenced by the pm_ops structure which is eliminated? -- Florian